From: Jan Beulich <jbeulich@suse.com>
To: dmkhn@proton.me
Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech,
julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 1/3] xen/console: cleanup conring management
Date: Tue, 8 Apr 2025 17:10:56 +0200 [thread overview]
Message-ID: <bff7ddac-9072-4cfc-a4ef-b73c87b98d18@suse.com> (raw)
In-Reply-To: <20250403000604.169619-2-dmukhin@ford.com>
On 03.04.2025 02:06, dmkhn@proton.me wrote:
> From: Denis Mukhin <dmukhin@ford.com>
>
> Move console_locks_busted handling inside conring_puts() to remove
> tasklet code duplication.
I for one wouldn't expect tasklet scheduling to happen in a function of
this name. IOW I think the little bit of duplication is warranted here.
Jan
next prev parent reply other threads:[~2025-04-08 15:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 0:06 [PATCH v1 0/3] xen/console: few cleanups in console driver dmkhn
2025-04-03 0:06 ` [PATCH v1 1/3] xen/console: cleanup conring management dmkhn
2025-04-08 15:10 ` Jan Beulich [this message]
2025-04-25 22:18 ` Stefano Stabellini
2025-04-28 6:47 ` Jan Beulich
2025-04-28 20:10 ` dmkhn
2025-04-03 0:06 ` [PATCH v1 2/3] xen/console: introduce console_puts() dmkhn
2025-04-25 22:35 ` Stefano Stabellini
2025-04-25 22:47 ` Stefano Stabellini
2025-04-28 1:47 ` dmkhn
2025-04-03 0:06 ` [PATCH v1 3/3] xen/console: introduce conring_flush() dmkhn
2025-04-25 22:53 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bff7ddac-9072-4cfc-a4ef-b73c87b98d18@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmkhn@proton.me \
--cc=dmukhin@ford.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.