[bluez/bluez] 421aab: sdp-xml: Use a queue to collect sequence members

[bluez/bluez] 421aab: sdp-xml: Use a queue to collect sequence members

[Luiz Augusto von Dentz]

  Branch: refs/heads/1146222
  Home:   https://github.com/bluez/bluez
  Commit: 421aab1b5c48db683d1d5d41d46acdbdf078fb15
      https://github.com/bluez/bluez/commit/421aab1b5c48db683d1d5d41d46acdbdf078fb15
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-08-14 (Fri, 14 Aug 2026)

  Changed paths:
    M src/sdp-xml.c

  Log Message:
  -----------
  sdp-xml: Use a queue to collect sequence members

Appending a member to a sequence with sdp_seq_append() walks the
single-linked list to find its tail, so building a sequence is O(n^2).

This was previously worked around by caching the tail of the sequence in
struct sdp_xml_data, which required the caller to pick between appending
to the cached tail and initialising val.dataseq, and to keep the cache in
sync on every append.

Collect the members in a struct queue instead, which tracks its own tail,
and link them into val.dataseq once the element is closed. Appending is a
plain queue_push_tail(), and the queue is destroyed along with the rest
of the element so members that were never linked, such as on malformed
input, are still freed.

The sequence_on_squared() test stays at less than 0.1 seconds.

Assisted-by: Claude:claude-opus-5



To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications