[bluez/bluez] 1ddc62: pbap: Support calling pbap_init() after pbap_exit()

[bluez/bluez] 1ddc62: pbap: Support calling pbap_init() after pbap_exit()

[github-actions[bot]]

  Branch: refs/heads/957129
  Home:   https://github.com/bluez/bluez
  Commit: 1ddc62fa5cbe4aa7378b772fb8f9cf97d2551385
      https://github.com/bluez/bluez/commit/1ddc62fa5cbe4aa7378b772fb8f9cf97d2551385
  Author: Andrew Sayers <kernel.org@pileofstuff.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M obexd/client/pbap.c

  Log Message:
  -----------
  pbap: Support calling pbap_init() after pbap_exit()

pbap_exit() didn't previously unregister itself thoroughly.  That
was fine if it was only called when the service was about to exit,
because everything was implicitly unregistered when the process ended.
But we need to be more scrupulous if this can be called throughout
the program's lifecycle.

Send the UnregisterProfile message directly from pbap_exit(),
then call unregister_profile().

The UnregisterProfile message can't be sent directly from
unregister_profile(), because that also needs to be called when
register_profile() fails halfway through.

Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>


  Commit: 61f5836a9a738d32eac9a3da67e5c46b218fb887
      https://github.com/bluez/bluez/commit/61f5836a9a738d32eac9a3da67e5c46b218fb887
  Author: Andrew Sayers <kernel.org@pileofstuff.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M obexd/plugins/bluetooth.c

  Log Message:
  -----------
  obexd/bluetooth: Support calling bluetooth_init() after bluetooth_exit()

bluetooth_exit() didn't previously unregister itself thoroughly.  That
was fine if it was only called when the service was about to exit,
because everything was implicitly unregistered when the process ended.
But we need to be more scrupulous if this can be called throughout
the program's lifecycle.

Send UnregisterProfile messages directly from bluetooth_exit(),
then call unregister_profile(profile).

The UnregisterProfile message can't be sent directly from
unregister_profile(), because that also needs to be called when
register_profile() fails halfway through.

Do not free profiles in bluetooth_exit() - profiles are needed
by a future call to bluetooth_init(), or will be freed by
bluetooth_stop() if necessary.

Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>


  Commit: e4829a671a616fdc99043dc1d445f57a25421bc6
      https://github.com/bluez/bluez/commit/e4829a671a616fdc99043dc1d445f57a25421bc6
  Author: Andrew Sayers <kernel.org@pileofstuff.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M obexd/src/main.c
    M obexd/src/obexd.h

  Log Message:
  -----------
  obexd: Support creating private system/session bus connections

Obexd can either connect to the system or session bus.
We mostly share a common connection to that bus, but it can be useful
to have a private connection.  For example, this allows us to quickly
unregister profiles when switching user.

Add obex_setup_dbus_connection_private(), which creates a new
connection to whichever bus was specified by the user.

Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>


  Commit: feadad7a76f9f8d5a4557321fa3f0592de10b747
      https://github.com/bluez/bluez/commit/feadad7a76f9f8d5a4557321fa3f0592de10b747
  Author: Andrew Sayers <kernel.org@pileofstuff.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M Makefile.obexd
    M obexd/client/pbap.c
    M obexd/plugins/bluetooth.c
    A obexd/src/logind.c
    A obexd/src/logind.h
    M obexd/src/main.c

  Log Message:
  -----------
  obexd: Unregister profiles when the user is inactive

Obexd is usually run as a user service, and can exhibit surprising
behaviour if two users are logged in at the same time.

Unregister profiles when the user is detected to be off-seat.

It may be impossible to detect whether a user is on-seat in some cases.
For example, a version of obexd compiled with systemd support might be
run outside of a systemd environment.  Warn and leave services
registered if that happens.

Obexd can be run as a system service, in which case this check makes no
sense.  Disable this check when called with `--system-bus`.

Obexd can also be run by a user that does not have an active session.
For example, someone could use `ssh` to access the system.  There might
be a use case where someone needs Bluetooth access but can't log in with
a keyboard, or there might be a security issue with doing so.  This isn't
handled explicitly by this patch, but a future patch could add support
by calling `logind_set(FALSE)` in the same way as is currently done
with `--system-bus`.

Unregister profiles by closing private connections instead of sending
UnregisterProfile on the shared connection.  Pipewire has apparently
found the latter to cause long shutdown delays, because bluetoothd
may be shutting down and unable to handle this message.

Based in large part on the wireplumber code mentioned by Pauli Virtanen:
https://gitlab.freedesktop.org/pipewire/wireplumber/-/blob/master/modules/module-logind.c#L52

Other services are likely to need similar functionality,
so I have created a gist to demonstrate the basic technique:
https://gist.github.com/andrew-sayers/1c4a24f86a9a4c1b1e38d109f1bd1d1e

Suggested-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>


  Commit: b8068a1c6ef32530d05bf892dd1c027ed1aeb2ce
      https://github.com/bluez/bluez/commit/b8068a1c6ef32530d05bf892dd1c027ed1aeb2ce
  Author: Andrew Sayers <kernel.org@pileofstuff.org>
  Date:   2025-04-25 (Fri, 25 Apr 2025)

  Changed paths:
    M obexd/src/obex.service.in

  Log Message:
  -----------
  Revert "obexd: only run one instance at once"

No longer needed now services can share resources.

This reverts commit 8d472b8758dcdd89bf13cf2fb06a8846e1f483a0.

Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>


Compare: https://github.com/bluez/bluez/compare/1ddc62fa5cbe%5E...b8068a1c6ef3

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications