[bluez/bluez] 58b257: audio: Don't initialize media transport volume fro...

[bluez/bluez] 58b257: audio: Don't initialize media transport volume fro...

[Myrrh Periwinkle]

  Branch: refs/heads/988599
  Home:   https://github.com/bluez/bluez
  Commit: 58b2575f863242a2fdd79f1fd34febd9670581d4
      https://github.com/bluez/bluez/commit/58b2575f863242a2fdd79f1fd34febd9670581d4
  Author: Myrrh Periwinkle <myrrhperiwinkle@qtmlabs.xyz>
  Date:   2025-08-06 (Wed, 06 Aug 2025)

  Changed paths:
    M profiles/audio/avrcp.c
    M profiles/audio/media.c
    M profiles/audio/media.h

  Log Message:
  -----------
  audio: Don't initialize media transport volume from media player

Media player objects may be shared between devices. As a result,
a device without support for hardware volume that is connected after one
that does may end up being erroneously considered hardware
volume-capable.

fa7828bdd ("transport: Fix not being able to initialize volume properly")
introduced btd_device_{get,set}_volume that is used as an alternative in
case no media player objects are present. Therefore, we can remove
media_player_get_device_volume and instead use btd_device_get_volume to
determine the initial volume.


  Commit: 784cb28e8c8b548ff0c3189dd9a1a1f7594dab14
      https://github.com/bluez/bluez/commit/784cb28e8c8b548ff0c3189dd9a1a1f7594dab14
  Author: Myrrh Periwinkle <myrrhperiwinkle@qtmlabs.xyz>
  Date:   2025-08-06 (Wed, 06 Aug 2025)

  Changed paths:
    M profiles/audio/avrcp.c
    M profiles/audio/avrcp.h
    M profiles/audio/media.c

  Log Message:
  -----------
  audio: Remove media_player.volume

With the previous commit, the media_player.volume field is now
completely unused. As this was never the right place to store the
initial volume to begin with, remove this field entirely as well as its
associated supporting methods to prevent confusion.


Compare: https://github.com/bluez/bluez/compare/58b2575f8632%5E...784cb28e8c8b

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications