[Bug 101977] UE4 4.17 causes hang in amdgpu_cs_query_fence_status

[Bug 101977] UE4 4.17 causes hang in amdgpu_cs_query_fence_status

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1655 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

            Bug ID: 101977
           Summary: UE4 4.17 causes hang in amdgpu_cs_query_fence_status
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: ttimo@ttimo.net
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 133142
  --> https://bugs.freedesktop.org/attachment.cgi?id=133142&action=edit
backtrace and dmesg

Ubuntu 16.04.2 LTS x86_64
kernel 4.12.4-041204-generic
Latest mesa git as of today 07/30
Latest UE4 4.17 out git branch as of today (4.17 not officially released yet)
clang 3.9 3.9.1-4ubuntu3~16.04.1 (tags/RELEASE_391/rc2) (used for mesa and UE4)

Starting the editor, or starting directly on a game, either in gl3 or gl4 mode
causes a hang. You have to use -NOSPLASH to avoid another, unrelated issue. My
typical command line looks like this:

UnrealEngine> set ver 3.9 ; env
LD_LIBRARY_PATH=$HOME/usr/lib:/usr/lib/llvm-$ver/lib
LIBGL_DRIVERS_PATH=$HOME/usr/lib/dri:/usr/lib/i386-linux-gnu/dri
LIBGL_DEBUG=verbose
VK_ICD_FILENAMES=/opt/Valve/mesa/src/amd/vulkan/dev_icd.json
./Engine/Binaries/Linux/UE4Editor-Linux-Debug -opengl4 -NOSPLASH

For GL3, pass -opengl3 on the command line and set env var
MESA_GL_VERSION_OVERRIDE=3.2 (results are the same)

Attaching backtrace and dmesg

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3165 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 997 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

Timothee Besset <ttimo@ttimo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|UE4 4.17 causes hang in     |UE4 4.17 causes Assertion
                   |amdgpu_cs_query_fence_statu |`G_0286CC_LINEAR_CENTER_ENA
                   |s                           |(shader->config.spi_ps_inpu
                   |                            |t_addr)' failed

--- Comment #1 from Timothee Besset <ttimo@ttimo.net> ---
Default/release config drivers will cause a system hang.
Debug drivers will cause an assert:

si_shader.c:7417: _Bool si_shader_select_ps_parts(struct si_screen *,
LLVMTargetMachineRef, struct si_shader *, struct pipe_debug_callback *):
Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)'
failed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2355 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 746 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #2 from Timothee Besset <ttimo@ttimo.net> ---
hakzsam on irc was able to reproduce the issue on his system.
also to note, hakzam uses a different LLVM version than I do.

problem does not reproduce with nouveau driver, only radeonsi

ran with MESA_GLSL=dump R600_DEBUG=ps,vs,tcs,tes,cs,gs to extract more
information:

https://gist.github.com/TTimo/4f08718e1c5d9de003d617e3f0daea2a

after debugging some more, to the best of my understanding, the assertion
happens against the config of 'shader 3'
(https://gist.github.com/TTimo/4f08718e1c5d9de003d617e3f0daea2a#file-gistfile1-txt-L411)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1804 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #3 from Timothee Besset <ttimo@ttimo.net> ---
Created attachment 133372
  --> https://bugs.freedesktop.org/attachment.cgi?id=133372&action=edit
apitrace

Stepped through and commented out code until I could narrow down the last GL
call that leads to a crash. Captured an apitrace up until the call that will
ultimately cause the problem.

https://gist.github.com/TTimo/05222bd524b534977c5e72bcb3df3dfc

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1622 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 633 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #4 from Timothee Besset <ttimo@ttimo.net> ---
Created attachment 133373
  --> https://bugs.freedesktop.org/attachment.cgi?id=133373&action=edit
apitrace FBlackCubeArrayTexture::InitRHI

Another trace: same crash, but initializing a different resource
(FBlackCubeArrayTexture::InitRHI).

The skipped call triggering the crash:

TexSubImage3D #2: target = 36873 level = 0 xoffset = 0 yoffset = 0 zoffset = 0
width = 1 height = 1 depth = 1 format = 32993 type = 33639 pixels = 0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1685 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 269 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #5 from Marek Olšák <maraeo@gmail.com> ---
This can't be reproduce with LLVM 6.0svn and Radeon Fury. Trying LLVM 3.9...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1148 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 354 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #6 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
The issue can't be reproduced with the traces here as well. But if you build
the UE4 editor from github, the issue can be reproduced with LLVM6.0svn.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1244 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 276 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #7 from Marek Olšák <maraeo@gmail.com> ---
Does the issue occur with any of these:

R600_DEBUG=mono
R600_DEBUG=nooptvariant

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1155 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #8 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Yes for both.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1107 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 648 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #9 from Timothee Besset <ttimo@ttimo.net> ---
(In reply to Samuel Pitoiset from comment #6)
> The issue can't be reproduced with the traces here as well. But if you build
> the UE4 editor from github, the issue can be reproduced with LLVM6.0svn.

Have you modified the traces to include the call that triggers the crash? The
traces I uploaded only recorded the GL calls up to the last call before the
crash is triggered, so unless you know how to manually add a call, they won't
cause a crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1602 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 471 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #10 from Timothee Besset <ttimo@ttimo.net> ---
A similar crash happens if UE4 is started in Vulkan mode:

https://gist.github.com/TTimo/28fa434142fb59e66ae469ed7f7ef034

SIGFPE happens because pipeline->shaders[4]->config.num_vgprs == 0, which is
consistent with the empty config reads from the LLVM shader compilation

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1435 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 286 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #11 from Marek Olšák <maraeo@gmail.com> ---
Samuel, can you share here what you found out when you were looking into the
issue? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1166 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1049 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #12 from Marek Olšák <maraeo@gmail.com> ---
.AMDGPU.config coming from LLVM is empty with UE4Editor. This assertion fails:

diff --git a/src/amd/common/ac_binary.c b/src/amd/common/ac_binary.c
index 618b5cf..2fbb575 100644
--- a/src/amd/common/ac_binary.c
+++ b/src/amd/common/ac_binary.c
@@ -148,6 +148,7 @@ void ac_elf_read(const char *elf_data, unsigned elf_size,
                } else if (!strcmp(name, ".AMDGPU.config")) {
                        section_data = elf_getdata(section, section_data);
                        binary->config_size = section_data->d_size;
+                       assert(binary->config_size);
                        binary->config = MALLOC(binary->config_size *
sizeof(unsigned char));
                        memcpy(binary->config, section_data->d_buf,
binary->config_size);
                } else if (!strcmp(name, ".AMDGPU.disasm")) {

Any ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1989 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 356 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #13 from Dave Airlie <airlied@freedesktop.org> ---
llvm seems fine, it seems to be libelf that is broken.

I've noticed UE4 exports it's own libelf symbols but I haven't determined that
is the problem yet.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1241 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 247 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #14 from Dave Airlie <airlied@freedesktop.org> ---
Yup once I hid the libelf symbols, it all works.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1132 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1321 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #15 from Marek Olšák <maraeo@gmail.com> ---
Interesting. So it's a UE4 bug after all. If UE4 didn't export its own libelf
functions, it would work.

When the driver is loaded, the dynamic linker loads libelf, but since UE4
exports the same function names as libelf does, libelf functions are not loaded
at all and the functions from UE4 are exposed to the driver instead. The
driver, thinking it's calling libelf, is actually invoking the UE4 functions of
the same name.

A temporary workaround is to load the system libelf first by doing:

LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libelf.so ./UE4Editor

It will have the opposite effect. UE4 will use system libelf instead of its
own, because the symbols conflict and the system one is loaded first.

This bug should be fixed in UE4 though.

I'm closing this bug, because there is nothing Mesa can do here.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2977 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 313 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #16 from Timothee Besset <ttimo@ttimo.net> ---
Thanks for the help and thorough investigation! I will follow up from there
with Epic to get this addressed UE4 side.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1254 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 330 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #17 from Dave Airlie <airlied@freedesktop.org> ---
Enabling the UE4 linker script fixes this also. (It got disabled for 4.17).

It appears that versions the symbols on the UE side.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1275 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 101977] UE4 4.17 causes Assertion `G_0286CC_LINEAR_CENTER_ENA(shader->config.spi_ps_input_addr)' failed

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 246 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=101977

--- Comment #18 from Timothee Besset <ttimo@ttimo.net> ---
https://github.com/EpicGames/UnrealEngine/pull/3901

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1253 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel