[Bug 102382] New: nv50ir: isImmediate doesn't properly work for integers if Value is typed as float

[Bug 102382] New: nv50ir: isImmediate doesn't properly work for integers if Value is typed as float

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1451 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102382

            Bug ID: 102382
           Summary: nv50ir: isImmediate doesn't properly work for integers
                    if Value is typed as float
           Product: xorg
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
          Reporter: karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
        QA Contact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org

Created attachment 133728
  --> https://bugs.freedesktop.org/attachment.cgi?id=133728&action=edit
TGSI

codegen should generate a texfetch instruction with a lod according to
IMM[1].xxxx, which is of value 2, but in
https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp#n140
the isInteger(0) call assumes the Value being a F32, which leads to a is
2.8E-45 == 0 check returning true resulting into the lod argument being removed
from texfetch.

This causes a fail in the KHR-GL44.robust_buffer_access_behavior.texel_fetch
CTS test.

Other isInteger calls might be broken as well where an immediate of type float
is interpreted as int by the instruction.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2975 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 102382] nv50ir: isImmediate doesn't properly work for integers if Value is typed as float

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 666 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102382

Karol Herbst <karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Karol Herbst <karolherbst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
nothing was wrong with isImmediate, but the tetexfetch was fixed in
96be442b7795a6eb3d50f4061f2b98dddc39aa4d

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2206 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau