[Bug 102633] Running ConeStepMap in wine freezes the system

[Bug 102633] Running ConeStepMap in wine freezes the system

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1118 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102633

            Bug ID: 102633
           Summary: Running ConeStepMap in wine freezes the system
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: dark.shadow4@web.de
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 134106
  --> https://bugs.freedesktop.org/attachment.cgi?id=134106&action=edit
Apitrace that will freeze the system

ConeStepMap is a small OpenGL demo, but when run under wine with mesa it
freezes the system. I created and attached an apitrace to reproduce, simply
replaying it freezes my system and forces me to make a hard-reset.


System the bug was tested on:
- Arch Linux 64bit
- Linux 4.12.10, AMDGPU driver
- Mesa 17.3.0-devel (git-b33b85cdd4) / 17.1.8
- Radeon R9 285

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2653 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102633] Running ConeStepMap in wine freezes the system

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102633

--- Comment #1 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Created attachment 134252
  --> https://bugs.freedesktop.org/attachment.cgi?id=134252&action=edit
hacky patch

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1301 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102633] Running ConeStepMap in wine freezes the system

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2093 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102633

Samuel Pitoiset <samuel.pitoiset@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #2 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Thanks for reporting this.

I'm able to reproduce the hang with the following environment:

OpenGL renderer string: AMD Radeon (TM) RX 480 Graphics (POLARIS10 / DRM 3.19.0
/ 4.13.0-rc5-ARCH+, LLVM 6.0.0)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 17.3.0-devel
(git-8e8c7c6703)

No VM faults are reported, but it appears that one shader is stucked because
some uniform variables are undefined and it loops indefinitely.

When replaying the trace, I get a bunch of errors like:

Mesa: User error: GL_INVALID_OPERATION in glUniform(location=18)
4867496: message: major api error 3: GL_INVALID_OPERATION in
glUniform(location=18)
4867496 @0 glUniform1ivARB(location = 18, count = 1, value = &0)
4867496: warning: glGetError(glUniform1ivARB) = GL_INVALID_OPERATION

Basically, the app is trying to update a uniform variable with an invalid
location.

After looking at the trace, the app assumes that uniform locations are fixed,
which is wrong (except if they are explicitly set inside the shader). Instead,
new locations are generated after each successful re-link, which is why
GetUniformLocation exists (and the app never calls it).

The GLSL compiler doesn't allocate locations for built-in uniform variables
like gl_ModelViewMatrix which explains the above errors. The attached (hacky)
patch fixes the hang but don't except this to be upstream, the application is
buggy.

Though, it would be doable to add new drirc option like
glsl_force_fixed_locations but I personally don't want to introduce new hacks
in Mesa.

Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3622 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102633] Running ConeStepMap in wine freezes the system

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 405 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102633

--- Comment #3 from Fabian Maurer <dark.shadow4@web.de> ---
Thanks for looking into this.
I can't really agree with the resolution though, it not working is one thing,
but it freezing the whole system is another. Can't something be done to at
least avoid the latter?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1243 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102633] Running ConeStepMap in wine freezes the system

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 240 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102633

--- Comment #4 from Samuel Pitoiset <samuel.pitoiset@gmail.com> ---
Fix the app would be much better. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1086 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 102633] Running ConeStepMap in wine freezes the system

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 275 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=102633

--- Comment #5 from Fabian Maurer <dark.shadow4@web.de> ---
Sure thing, but a driver shouldn't allow to bring down the whole system, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1113 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel