[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1322 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

            Bug ID: 104275
           Summary: Stoney Ridge laptop display goes blank after HDMI gets
                    plugged/unplugged in extended mode.
           Product: DRI
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: kai.heng.feng@canonical.com

Hi,

We are enabling a new Stoney Ridge laptop.
The issue can be reproduced on branch drm-next-4.16-wip and
amd-staging-drm-next.

Reproduce steps:

1. Plug HDMI monitor.
2. Change to extended mode.
3. Unplug the HDMI monitor
4. Plug the HDMI monitor

Internal display may go blank in step 3.

The internal display may also go blank in step 4. The external one shows
desktop correctly though.

I can see lots of message flooding once I plugged HDMI:
[  120.933668] amdgpu 0000:00:01.0: 0000000030e07f1f pin failed
[  120.933859] [drm:amdgpu_crtc_page_flip_target [amdgpu]] *ERROR* failed to
pin new abo buffer before flip

These messages stop as soon as the HDMI is unplugged.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2639 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 309 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #1 from Kai-Heng Feng <kai.heng.feng@canonical.com> ---
Created attachment 136186
  --> https://bugs.freedesktop.org/attachment.cgi?id=136186&action=edit
lspci

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1285 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 329 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #2 from Kai-Heng Feng <kai.heng.feng@canonical.com> ---
Created attachment 136187
  --> https://bugs.freedesktop.org/attachment.cgi?id=136187&action=edit
dmesg with drm.debug=0x0e

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1345 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 371 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #3 from Michel Dänzer <michel@daenzer.net> ---
The fundamental issue here is that only 32 MB of memory are reserved as VRAM
for the GPU.

https://patchwork.freedesktop.org/patch/192451/ should fix it (with DC
enabled).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1299 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 675 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #4 from Kai-Heng Feng <kai.heng.feng@canonical.com> ---
(In reply to Michel Dänzer from comment #3)
> The fundamental issue here is that only 32 MB of memory are reserved as VRAM
> for the GPU.
> 
> https://patchwork.freedesktop.org/patch/192451/ should fix it (with DC
> enabled).

I applied both [1] and [2], also enabled DC for it, now the Unity Desktop is
garbled.
Unity Greeter in LightDM is fine though.

[1] https://patchwork.freedesktop.org/patch/192451/
[2] https://patchwork.freedesktop.org/patch/192450/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 320 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #5 from Kai-Heng Feng <kai.heng.feng@canonical.com> ---
Created attachment 136191
  --> https://bugs.freedesktop.org/attachment.cgi?id=136191&action=edit
Garbled display.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1318 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 574 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

Michel Dänzer <michel@daenzer.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ckoenig.leichtzumerken@gmai
                   |                            |l.com

--- Comment #6 from Michel Dänzer <michel@daenzer.net> ---
Hmm, maybe a separate DC patch is needed as well. Christian?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1977 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 499 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #7 from Alex_Zhang1@Dell.com ---
Hi Michel,
  Before the buffer been pined to a location, can the buffer be moved to other
place? My opinion, this is not about VRAM size, it is the mechanism of buffer
move. Is this buffer content of rendering output or source or it is GPU command
buffer? Is there any better way we can narrow down or investigate?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1346 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 704 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #8 from Michel Dänzer <michel@daenzer.net> ---
(In reply to Alex_Zhang1 from comment #7)

Without the patch referenced in comment 3, a buffer must be pinned to VRAM
before it can be scanned out (displayed). The problem described in this report
happens because pinning to VRAM fails, because there isn't enough space in
VRAM. The patch allows buffers to be pinned to GTT instead of VRAM for scanout.
Another DC patch is probably needed to fix the garbled display described in
comment 4. Maybe try the patch on top of the amd-staging-drm-next branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1690 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 353 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #9 from Harry Wentland <harry.wentland@amd.com> ---
Created attachment 136321
  --> https://bugs.freedesktop.org/attachment.cgi?id=136321&action=edit
DC scatter gather patch

You'll need this DC patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1447 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 283 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #10 from AceLan Kao <acelan@gmail.com> ---
Hi Harry,

I'm wondering if there is also an equivalence method to fix it on v4.13 kernel.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1144 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 848 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #11 from Alex_Zhang1@Dell.com ---
(In reply to Harry Wentland from comment #9)
> Created attachment 136321 [details] [review]
> DC scatter gather patch
> 
> You'll need this DC patch.

Hi Harry,
  As patch below,

+       /*
+        * TODO debug why this doesn't work on Raven
+        */
+       if (adev->flags & AMD_IS_APU &&
+           adev->asic_type >= CHIP_CARRIZO &&
+           adev->asic_type < CHIP_RAVEN)
+               init_data.flags.gpu_vm_support = true;

  Seems this is just for debug, if I am wrong, please correct me. Do the flags
gpu_vm_support has support on 4.13 kernel? Could you please help to confirm if
this patch can be used on 4.13 kernel?

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2098 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 466 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #12 from Kai-Heng Feng <kai.heng.feng@canonical.com> ---
(In reply to Harry Wentland from comment #9)
> Created attachment 136321 [details] [review]
> DC scatter gather patch
> 
> You'll need this DC patch.

I can confirm that the issue is fixed by this patch (with the additional two
patches above).

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1708 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 579 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

--- Comment #13 from Harry Wentland <harry.wentland@amd.com> ---
(In reply to AceLan Kao from comment #10)
> Hi Harry,
> 
> I'm wondering if there is also an equivalence method to fix it on v4.13
> kernel.

You could try applying the patches mentioned by Michel, plus my patch. I'm not
sure whether they'll apply well or work. The DC patch shouldn't be a problem if
it applies but I'm not sure about the other patches Michel mentioned.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1531 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 104275] Stoney Ridge laptop display goes blank after HDMI gets plugged/unplugged in extended mode.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 438 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=104275

Kai-Heng Feng <kai.heng.feng@canonical.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1315 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel