[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1014 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

            Bug ID: 106548
           Summary: Failed
                    GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAP
                    I
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i915
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: kishore.kadiyala@intel.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 139610
  --> https://bugs.freedesktop.org/attachment.cgi?id=139610&action=edit
GL_GPU_FREQ_OVERRIDE_MDAPI Acceptance failure

On Ubuntu 18.04, with latest MESA + MDAPI from here
https://gerrit-gfx.intel.com/#/admin/projects/gfx/core/metrics-discovery

The testacceptance is failing for GL_GPU_FREQ_OVERRIDE_MDAPI

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2627 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 262 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #1 from Chris Wilson <chris@chris-wilson.co.uk> ---
*** Bug 106549 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1275 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 484 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #2 from Chris Wilson <chris@chris-wilson.co.uk> ---
/home/kk/workspace/gpa_extensions/src/GfxDrvDriverAcceptanceTest/test_GfxDrv_DriverAcceptanceQuery.cpp:1438:
Failure
Value of: pOverride->SetOverride(&freqParam, sizeof(freqParam))
  Actual: 43
Expected: CC_OK
Which is: 0

Looks like the test case needs improving for starters.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1305 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #3 from Vyacheslav Bogdanov <vyacheslav.y.bogdanov@intel.com> ---
(In reply to Chris Wilson from comment #2)
> /home/kk/workspace/gpa_extensions/src/GfxDrvDriverAcceptanceTest/
> test_GfxDrv_DriverAcceptanceQuery.cpp:1438: Failure
> Value of: pOverride->SetOverride(&freqParam, sizeof(freqParam))
>   Actual: 43
> Expected: CC_OK
> Which is: 0
> 
> Looks like the test case needs improving for starters.

Could you please explain? The function call fails, test checks that. Syslog
typically provides more logs that will help understanding the cause of the
failure.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1651 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

Joonas Lahtinen <joonas.lahtinen@linux.intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #4 from Joonas Lahtinen <joonas.lahtinen@linux.intel.com> ---
What exactly is being reported here? If there's a regression after a kernel
update, please provide a bisect between last known good and drm-tip.

There's nothing MDAPI related in the kernel and you're not specifying any link
to the testing suite, so this bug report is hardly useful.

Providing a dmesg with debug options from running just the failing subtest
would be a good start to guess something.

For proper bug reporting, please see:

https://01.org/linuxgraphics/documentation/how-report-bugs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2459 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 399 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #5 from Francesco Balestrieri <francesco.balestrieri@intel.com> ---
Additional comment from Kishore in the duplicate bug #106549:

"I have tried on default kernel version on ubuntu 18.04 is 4.15-rc20.
and also on the drm-tip, i can see the failure"

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1458 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 528 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #6 from Francesco Balestrieri <francesco.balestrieri@intel.com> ---
Kishore, could you point to an easy way to reproduce the failure without
running the full test suite, or at least which MDAPI is called when this
happens and it source code. Also, please include dmesg output showing the
kernel failure (make sure to enable debug information with drm.debug=0x1e
log_buf_len=4M

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1378 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 390 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

Francesco Balestrieri <francesco.balestrieri@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|medium                      |high

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1127 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #7 from Francesco Balestrieri <francesco.balestrieri@intel.com> ---
Created attachment 139741
  --> https://bugs.freedesktop.org/attachment.cgi?id=139741&action=edit
DMESG output

Kernel logs

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1309 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 304 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #8 from Francesco Balestrieri <francesco.balestrieri@intel.com> ---
I attached the log I got from Kishore. I wasn't able to spot any kernel failure
though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1154 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 706 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #9 from Chris Wilson <chris@chris-wilson.co.uk> ---
There's no user API that corresponds to a naive interpretation of
"GL_GPU_FREQ_OVERRIDE_MDAPI" (I assume that means to set the gpu frequency).
There is a root-only interface to set the global frequency limits and a
proposed CONTEXT_SETPARAM to set per-context frequency requests, but that is
pending review and has no userspace.

Hence, my request for the test case to be improved to report what it actually
tried and what actually happened, because at the moment this bug report is not
actionable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1550 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1794 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #10 from Francesco Balestrieri <francesco.balestrieri@intel.com> ---
Indeed, after some more investigation I found out that the test case uses (via
MDAPI) the root-only interface:

/sys/devices/pci0000:00/0000:00:02.0/drm/card0/gt_boost_freq_mhz
/sys/devices/pci0000:00/0000:00:02.0/drm/card0/gt_max_freq_mhz
/sys/devices/pci0000:00/0000:00:02.0/drm/card0/gt_min_freq_mhz 

to ask the kernel to maintain a static GPU frequency, and then reads it back to
check that it stays within a range of the requested value. The test fails
because the value it reads back is not what it requested (reproduced with
drm-tip). I still don't have dmesg output with debug logs enabled but I'l try
to get it next week.

For the records, this is what the test prints out once it is run as root:

[ RUN      ] GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI
AvgGpuCoreFrequencyMHz    =        947   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        948   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        948   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        947   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        948   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        947   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        948   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        947   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        947   ( expected in range [855, 950] )

AvgGpuCoreFrequencyMHz    =        797   ( expected in range [855, 950] ) =>
OUT OF RANGE!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2648 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 428 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #11 from Chris Wilson <chris@chris-wilson.co.uk> ---
An idle gpu is always reported as running at the min(idle) freq. You have to be
very careful in the workload you construct that it does indeed keep the gpu
busy if you want to use a sampling method.

No sign of a bug yet...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1263 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 717 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #12 from Francesco Balestrieri <francesco.balestrieri@intel.com> ---
(In reply to Chris Wilson from comment #11)
> An idle gpu is always reported as running at the min(idle) freq. You have to
> be very careful in the workload you construct that it does indeed keep the
> gpu busy if you want to use a sampling method.
> 

Apparently the test case uses queries, not the sampled method of metrics
measurement.

> No sign of a bug yet...

No disagreement there, however any further suggestion as to what to look at to
figure out what is going wrong is welcome.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1680 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 559 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

--- Comment #13 from Chris Wilson <chris@chris-wilson.co.uk> ---
Frequency changes are accompanied by a tracepoint (though note we only say what
we ask the hw to do, the hw is at liberty to do whatever it wants), and you can
enable the tracepoints for batch submission, so if you have the time and
patience to correlate them with the test you can draw pretty a graph. For
something along those lines, intel-gpu-overlay.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1394 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 106548] Failed GfxDrv_DriverAcceptanceQuery.GL_GPU_FREQ_OVERRIDE_MDAPI

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=106548

GitLab Migration User <gitlab-migration@fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |RESOLVED
         Resolution|---                         |MOVED

--- Comment #14 from GitLab Migration User <gitlab-migration@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/784.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2489 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel