[Bug 108668] drm/amd/display: set backlight level limit to 1: breaks userspace programs assuming 0 is the minimum brightness

[Bug 108668] drm/amd/display: set backlight level limit to 1: breaks userspace programs assuming 0 is the minimum brightness

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1144 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108668

            Bug ID: 108668
           Summary: drm/amd/display: set backlight level limit to 1:
                    breaks userspace programs assuming 0 is the minimum
                    brightness
           Product: DRI
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: samantham@posteo.net

This commit
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0cafc82fae41531b0162150f9a97f2c74f97118f
breaks KDE and any other software that assumes setting 0 will induce the
minimum brightness. Maybe it would make more sense to set the brightness level
to "1" if userspace requests brightness level "0" so programs still function
correctly.

If desired the call could still return false to indicate it was out of bounds,
but still lower brightness.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2614 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108668] drm/amd/display: set backlight level limit to 1: breaks userspace programs assuming 0 is the minimum brightness

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 625 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108668

--- Comment #1 from Samantha McVey <samantham@posteo.net> ---
In addition, even though there is a write error, when you read back the
brightness value, it shows that the backlight is at level 0, while its
brightness has actually been unchanged from before:

echo 0 >
/sys/devices/pci0000:00/0000:00:08.1/0000:05:00.0/backlight/amdgpu_bl0/brightness
bash: echo: write error: Invalid argument

cat
/sys/devices/pci0000:00/0000:00:08.1/0000:05:00.0/backlight/amdgpu_bl0/brightness
0

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1538 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108668] drm/amd/display: set backlight level limit to 1: breaks userspace programs assuming 0 is the minimum brightness

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 267 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108668

--- Comment #2 from Harry Wentland <harry.wentland@amd.com> ---
This should fix it: https://patchwork.freedesktop.org/patch/260537/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1241 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108668] drm/amd/display: set backlight level limit to 1: breaks userspace programs assuming 0 is the minimum brightness

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 536 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108668

Samantha McVey <samantham@posteo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Samantha McVey <samantham@posteo.net> ---
Closing this since it has been fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel