[Bug 108825] Raven Ridge: Banding on eDP display

[Bug 108825] Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 838 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

            Bug ID: 108825
           Summary: Raven Ridge: Banding on eDP display
           Product: DRI
           Version: XOrg git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: samantham@posteo.net

Using this test there are 64 distinct bands rather than any smoothness:
http://www.lagom.nl/lcd-test/gradient.php

It looks like this except there are 64 bands whereas the picture shows 32
bands: http://www.lagom.nl/lcd-test/img/gradient-h-32col.png

Computer is Lenovo A485 with Ryzen PRO 2700U

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2245 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 509 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #1 from Samantha McVey <samantham@posteo.net> ---
Created attachment 142561
  --> https://bugs.freedesktop.org/attachment.cgi?id=142561&action=edit
dmesg

bpc seems to be detected as 6, but visually there does not appear to be any
kind of dithering going on, resulting in bad banding during movies etc in
addition to the test I posted in the last message.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1369 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 306 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #2 from Samantha McVey <samantham@posteo.net> ---
Created attachment 142562
  --> https://bugs.freedesktop.org/attachment.cgi?id=142562&action=edit
xorg log

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1172 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 322 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #3 from Samantha McVey <samantham@posteo.net> ---
Created attachment 142563
  --> https://bugs.freedesktop.org/attachment.cgi?id=142563&action=edit
dmesg with drm.debug=0x1

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1220 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

Samantha McVey <samantham@posteo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|XOrg git                    |unspecified
            Summary|Raven Ridge: Banding on eDP |Regression Raven Ridge:
                   |display                     |Banding on eDP display

--- Comment #4 from Samantha McVey <samantham@posteo.net> ---
Looks like this is a regression. Dithering works in 4.19.2 but does not work in
amd-staging-drm-next.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2099 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 390 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #5 from Samantha McVey <samantham@posteo.net> ---
I have bisected it to commit: drm/amd/display: Support amdgpu "max bpc"
connector property
307638884f721b02b6a54ee8b351c5b4434bd4a6 Author: Nicholas Kazlauskas
<nicholas.kazlauskas@amd.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1243 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1234 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #6 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
(In reply to Samantha McVey from comment #5)
> I have bisected it to commit: drm/amd/display: Support amdgpu "max bpc"
> connector property
> 307638884f721b02b6a54ee8b351c5b4434bd4a6 Author: Nicholas Kazlauskas
> <nicholas.kazlauskas@amd.com>

This isn't a regression from 4.19 but rather a fix for 4.18 where bpc was
uncapped from 8 unconditionally. It locked out high refresh modes for high
resolution panels with max bpc greater than 8.

The reported 6bpc in your dmesg log comes from DRM itself and not amdgpu. It's
what's being reported as being supported by your panel from its EDID. I'm not
sure if this is the panel itself reporting itself wrong or if there's a quirk
affecting it from the edid qurik list in drm_edid.c.

You can try reverting my patch on amd-staging-drm-next to see if you still get
the banding.

Or you could try setting the "max bpc" property to something higher (like 16).
You should be able to add this as an "Option" to a conf file in
/etc/X11/xorg.conf.d for your Monitor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2199 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 391 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #7 from Samantha McVey <samantham@posteo.net> ---
Nicholas,

Reverting that commit (307638884f721b02b6a54ee8b351c5b4434bd4a6) on the top of
amd-staging-drm-next resolves the banding issues. So it is that commit that is
causing the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1171 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #8 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
Created attachment 142652
  --> https://bugs.freedesktop.org/attachment.cgi?id=142652&action=edit
0001-drm-amd-display-Fix-unintialized-max_bpc-state-value.patch

Does this help fix the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1502 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 723 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #9 from Samantha McVey <samantham@posteo.net> ---
It doesn't compile with that patch:

drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function
‘dm_crtc_duplicate_state’:
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2991:7: error:
‘struct dm_crtc_state’ has no member named ‘max_bpc’
  state->max_bpc = cur->max_bpc;
       ^~
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2991:22: error:
‘struct dm_crtc_state’ has no member named ‘max_bpc’
  state->max_bpc = cur->max_bpc;
                      ^~

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1515 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #142652|0                           |1
        is obsolete|                            |

--- Comment #10 from Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> ---
Created attachment 142653
  --> https://bugs.freedesktop.org/attachment.cgi?id=142653&action=edit
v2-0001-drm-amd-display-Fix-unintialized-max_bpc-state-va.patch

I meant to copy the property for the dm connector state, sorry.

Try this patch instead.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2397 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 323 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #11 from Samantha McVey <samantham@posteo.net> ---
new_state->max_bpc = cur->max_bpc;

cur doesn't exist here (fails to compile with v2 patch). Did you mean
state->max_bpc?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1113 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 344 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

--- Comment #12 from Samantha McVey <samantham@posteo.net> ---
Nicholas,

Your last patch but with `new_state->max_bpc = state->max_bpc;` instead of
`new_state->max_bpc = cur->max_bpc;` resolves the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1137 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 108825] Regression Raven Ridge: Banding on eDP display

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 533 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=108825

Samantha McVey <samantham@posteo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Samantha McVey <samantham@posteo.net> ---
Going to close this one as fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2031 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel