[Bug 109080] Broken video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in 18.1 and 18.2

[Bug 109080] Broken video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in 18.1 and 18.2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1764 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

            Bug ID: 109080
           Summary: Broken video playback colors on AMD Ryzen 5 (PRO)
                    Mobile 2500U in 18.1 and 18.2
           Product: Mesa
           Version: 18.2
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: zajec5@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

Created attachment 142840
  --> https://bugs.freedesktop.org/attachment.cgi?id=142840&action=edit
Screenshot for Chromium with corrupted video

When playing video on YouTube using Chromium I see broken colors.

Info from the YouTube player:
Codecs vp09.00.51.08.01.01.01.01 (247) / opus (251)
Color bt709 / bt709


I experience this problem on two machines:

1) HP EliteBook 745 G5 with Ryzen 5 PRO 2500U
It runs 1.03.01 BIOS with 0x0810100b CPU microcode.

2) MateBook D with Ryzen 5 2500U
It runs 1.12 BIOS with 0x08101007 CPU microcode.


I've bisected the *fix* down to the:
commit 55e7de7b193535133d4324e9f601ae44a0cdd9a7
Author: Boyuan Zhang <boyuan.zhang@amd.com>
Date:   Wed Oct 17 15:03:30 2018 -0400

    radeonsi: enable vcn jpeg decode for raven

    Enable vcn jpeg decode for raven.

    Signed-off-by: Boyuan Zhang <boyuan.zhang@amd.com>
    Reviewed-by: Leo Liu <leo.liu@amd.com>


Is that possible to either:
1) cherry-pick those vcn/va fixes to the 18.1 and 18.2 branches
2) disable unsupported formats support in the 18.2 and 18.2 branches
please?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in 18.1 and 18.2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 544 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

--- Comment #1 from Rafał Miłecki <zajec5@gmail.com> ---
The announcement on Mesa 3D webpage says:

> NOTE: It is anticipated that 18.2.8 will be the final release in the 18.2 series. Users of 18.2 are encouraged to migrate to the 18.3 series in order to obtain future fixes.

So I guess nobody will care about cherry-picking those fixes? Should this just
get closed? Boyuan could you comment on this?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1418 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in 18.1 and 18.2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 876 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

--- Comment #2 from Boyuan Zhang <boyuan.zhang@amd.com> ---
Hi Rafal,

First of all, sorry for getting back to you late. I somehow missed this
message.

I took a look of your reported issue, but I got a little it confused here. So
you saw color corruptions when playing a VP9 video using Ryzen 5 PRO 2500U
(raven vcn), and you found that the "enable vcn jpeg deocde" patch/patch set
can actually fix the VP9 color corruption, is that what you mean? I'm a bit
confused why jpeg patch could affect VP9 decoding. Or did I misunderstand here?
Please help me to clarify.

And it seems that there is no vcn jpeg decode support in 18.1 and 18.2 branch.
I believe that vcn jpeg decode has been added to 18.3 branch.

Regards,
Boyuan

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1730 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in 18.1 and 18.2

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 207 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

--- Comment #3 from network723@rkmail.ru ---
Looks just like Bug 104597

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1170 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken VP9 video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in Chromium

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 594 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

Rafał Miłecki <zajec5@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Broken video playback       |Broken VP9 video playback
                   |colors on AMD Ryzen 5 (PRO) |colors on AMD Ryzen 5 (PRO)
                   |Mobile 2500U in 18.1 and    |Mobile 2500U in Chromium
                   |18.2                        |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1237 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken VP9 video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in Chromium

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1643 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

--- Comment #4 from Rafał Miłecki <zajec5@gmail.com> ---
Hey Boyuan,

thanks for looking at this issue! I agree it's quite confusing, but I finally
found out what's going on.

*****

Let me provide a new summary of Mesa releases & this problem:

1) Accelerated VP9 decoding in Chromium is broken with 18.1 & 18.2.
2) Video Acceleration DOESN'T WORK in Chromium with 18.3.0 - 18.3.3
3) Accelerated VP9 decoding in Chromium is broken with 18.3.4 & 19.0.

By "broken" I mean corrupted colors.

*****

Earlier confusion was due to the commit 55e7de7b1935 ("radeonsi: enable vcn
jpeg decode for raven") EXPOSING a bug 109107 which was related to reporting
profiles. That commit STOPPED Chromium from using Video Acceleration and made
it report following errors:
[21202:21202:0317/122002.223002:ERROR:vaapi_wrapper.cc(587)] :
vaQueryConfigProfiles returned: 14
[21202:21202:0317/122002.223045:ERROR:vaapi_wrapper.cc(587)] :
vaQueryConfigProfiles returned: 14

Bug 109107 got fixed with the commit 21cdb828a3f4 ("st/va: fix the incorrect
max profiles report") and since then:
1) Chromium uses Video Acceleration again
2) I see corrupted VP9 YouTube colors again

So the commit 55e7de7b1935 ("radeonsi: enable vcn jpeg decode for raven")
DIDN'T FIX anything but has only hidden the original problem. It stopped
Chromium from using Video Acceleration including VP9 hardware decoding.

*****

The problem is still there (in the 18.3.4, 19.0 and master) and needs to be
fixed :(

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2938 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken VP9 video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in Chromium

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 324 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

--- Comment #5 from Michael Eagle <xanto@egaming.ro> ---
Does the 'corrupted colors' situation improve if you start chromium with
the following:

allow_rgb10_configs=false chromium

?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1163 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 109080] Broken VP9 video playback colors on AMD Ryzen 5 (PRO) Mobile 2500U in Chromium

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=109080

GitLab Migration User <gitlab-migration@fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #6 from GitLab Migration User <gitlab-migration@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/1350.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2532 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel