[Bug 110248] IGT Meson build fails when "-Dbuild_tests=false" option is used

[Bug 110248] IGT Meson build fails when "-Dbuild_tests=false" option is used

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 836 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110248

            Bug ID: 110248
           Summary: IGT Meson build fails when "-Dbuild_tests=false"
                    option is used
           Product: DRI
           Version: DRI git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: IGT
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: eero.t.tamminen@intel.com

Setup:
* Ubuntu 18.04
* IGT git master

Test-case:
* meson -Dbuild_tests=false /path/to/repo/

Expected outcome:
* I can build just tooling from IGT

Actual outcome:
* runner/testdata/meson.build:15:0: ERROR:  Unknown variable "gen_testlist".

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2156 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110248] IGT Meson build fails when "-Dbuild_tests=false" option is used

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 694 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110248

Petri Latvala <petri.latvala@intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Petri Latvala <petri.latvala@intel.com> ---
commit 159c69e5318e934b5f1d83939191c8756280b758
Author: Petri Latvala <petri.latvala@intel.com>
Date:   Fri Apr 26 14:05:41 2019 +0300

    runner: Disable building if tests are not built

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2335 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110248] IGT Meson build fails when "-Dbuild_tests=false" option is used

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 2140 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110248

--- Comment #2 from Eero Tamminen <eero.t.tamminen@intel.com> ---
Thanks, I can verify that the Meson doesn't anymore fail.

However, it doesn't seem to disable all tests:
----------------------------------------------------------------
$ grep tests intel-gpu-tools_build.log
Message: Build tests: No
[3/328] Compiling C object
'lib/tests/lib@tests@@igt_can_fail_simple@exe/igt_can_fail_simple.c.o'.
[4/328] Compiling C object
'lib/tests/lib@tests@@igt_timeout@exe/igt_timeout.c.o'.
[5/328] Compiling C object
'lib/tests/lib@tests@@igt_can_fail@exe/igt_can_fail.c.o'.
[6/328] Compiling C object
'lib/tests/lib@tests@@igt_no_subtest@exe/igt_no_subtest.c.o'.
[7/328] Compiling C object
'lib/tests/lib@tests@@igt_simple_test_subtests@exe/igt_simple_test_subtests.c.o'.
[8/328] Compiling C object
'lib/tests/lib@tests@@igt_list_only@exe/igt_list_only.c.o'.
[10/328] Compiling C object
'lib/tests/lib@tests@@igt_fork_helper@exe/igt_fork_helper.c.o'.
[11/328] Compiling C object
'lib/tests/lib@tests@@igt_invalid_subtest_name@exe/igt_invalid_subtest_name.c.o'.
[12/328] Compiling C object
'lib/tests/lib@tests@@igt_segfault@exe/igt_segfault.c.o'.
[15/328] Compiling C object
'lib/tests/lib@tests@@igt_no_exit@exe/igt_no_exit.c.o'.
[17/328] Compiling C object 'lib/tests/lib@tests@@igt_fork@exe/igt_fork.c.o'.
[18/328] Compiling C object
'lib/tests/lib@tests@@igt_subtest_group@exe/igt_subtest_group.c.o'.
[22/328] Compiling C object
'lib/tests/lib@tests@@igt_exit_handler@exe/igt_exit_handler.c.o'.
[23/328] Compiling C object
'lib/tests/lib@tests@@igt_simulation@exe/igt_simulation.c.o'.
[30/328] Compiling C object
'lib/tests/lib@tests@@igt_hdmi_inject@exe/igt_hdmi_inject.c.o'.
[37/328] Compiling C object 'lib/tests/lib@tests@@igt_stats@exe/igt_stats.c.o'.
[45/328] Compiling C object
'lib/tests/lib@tests@@igt_assert@exe/igt_assert.c.o'.
----------------------------------------------------------------

Are these built on purpose even with tests building disabled?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3302 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel