[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1250 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

            Bug ID: 110443
           Summary: vaapi/vpp: wrong output for non 64-bytes align width
                    (ex: 1200)
           Product: Mesa
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/radeonsi
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: julien.isorce@gmail.com
        QA Contact: dri-devel@lists.freedesktop.org

vaDeriveImage reports wrong stride.

Indeed Mesa's vlVaDeriveImage always sets the stride to w * 4 for RGBA format
https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/image.c#n259 

This results in wrong video output, see
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/100

Is there a way to know the pipe_resource's stride
https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/image.c#n283
without exporting it to dmabuf (through whandle.stride) and without mapping it
(drv->pipe->transfer_map / pipe_transfer.stride) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2907 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1006 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #1 from Marek Olšák <maraeo@gmail.com> ---
(In reply to Julien Isorce from comment #0)
> vaDeriveImage reports wrong stride.
> 
> Indeed Mesa's vlVaDeriveImage always sets the stride to w * 4 for RGBA
> format
> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/
> image.c#n259 
> 
> This results in wrong video output, see
> https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/100
> 
> Is there a way to know the pipe_resource's stride
> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/
> image.c#n283 without exporting it to dmabuf (through whandle.stride) and
> without mapping it (drv->pipe->transfer_map / pipe_transfer.stride) ?

No, there isn't. whandle.stride is pipe_resource's stride and is for GPU
access. pipe_transfer.stride can be different and is for CPU access.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2191 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 757 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #2 from Julien Isorce <julien.isorce@gmail.com> ---
Thx for your comment. What about the following in vlVaDeriveImage:

-   w = align(surf->buffer->width, 2);
-   h = align(surf->buffer->height, 2);
+
+   alignment = screen->get_param(screen, PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT);
+   w = align(surf->buffer->width, alignment);
+   h = align(surf->buffer->height, alignment);

here
https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/va/image.c#n235

This is not entirely right but I feel it has more chance to succeed than the
current align 2. At least it works on my GFX6 card.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1701 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #3 from Marek Olšák <maraeo@gmail.com> ---
That's incorrect. The only way to get the stride is through winsys_handle. We
could add a separate query function though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1124 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 978 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #4 from Julien Isorce <julien.isorce@gmail.com> ---
Something like this:

--- a/src/gallium/include/pipe/p_screen.h
+++ b/src/gallium/include/pipe/p_screen.h
@@ -262,6 +262,15 @@ struct pipe_screen {
                                  struct winsys_handle *handle,
                                  unsigned usage);

+   boolean (*resource_get_stride)(struct pipe_screen *screen,
+                                  struct pipe_context *context,
+                                  struct pipe_resource *tex,
+                                  unsigned *stride);
+   boolean (*resource_get_offset)(struct pipe_screen *screen,
+                                  struct pipe_context *context,
+                                  struct pipe_resource *tex,
+                                  unsigned *offset);
+

? Thx

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1810 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 285 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #5 from Marek Olšák <maraeo@gmail.com> ---
Yes. It can be just 1 function returning both values and it doesn't have to
return boolean.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1094 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 310 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #6 from Julien Isorce <julien.isorce@gmail.com> ---
Thx for the suggestion, I submitted patches here
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/721.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1200 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 984 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |viktor_jaegerskuepper@freen
                   |                            |et.de

--- Comment #7 from Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de> ---
After commit 0e3a348bec436b9d949e85574e363a1fe0e7683c VLC crashes when I want
to play a video encoded in H.264 using VA-API. I have an AMD RV770, OS is Arch
Linux. From the merge request I see that there is an additional commit for
radeonsi to fix this bug, but not for r600. Since this bug is not closed yet,
is another commit for r600 necessary to not break that driver? Or should I open
another bug report for the crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2348 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 312 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #8 from Julien Isorce <julien.isorce@gmail.com> ---
Thx a lot for reporting this issue. It should fallback to previous path for
r600, at least, I will take a look.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1128 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 365 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #9 from Julien Isorce <julien.isorce@gmail.com> ---
I think it is missing a:

"if (screen->resource_get_info)"

here
https://gitlab.freedesktop.org/mesa/mesa/blob/master/src/gallium/state_trackers/va/image.c#L254

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1304 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 555 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #10 from Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de> ---
I tried to investigate a bit further, and I think video acceleration does not
really work on my RV770, neither with VA-API nor with VDPAU. However, even if I
deactivate hardware video decoding in VLC, it crashes when I want to play a
video.

So I think you're right, it should just fall back to whatever "worked" before
the change.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1399 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 260 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #11 from Julien Isorce <julien.isorce@gmail.com> ---
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/796

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1151 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 381 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #12 from Viktor Jägersküpper <viktor_jaegerskuepper@freenet.de> ---
I tested the commit in the merge request together with the r600-related change
which has already been committed to the master branch, VLC doesn't crash any
more.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1215 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 205 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #13 from Julien Isorce <julien.isorce@gmail.com> ---
Thx!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1022 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 382 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

--- Comment #14 from Julien Isorce <julien.isorce@gmail.com> ---
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/796
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/797
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/842

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1421 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110443] vaapi/vpp: wrong output for non 64-bytes align width (ex: 1200)

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 569 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110443

Juan A. Suarez <jasuarez@igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Juan A. Suarez <jasuarez@igalia.com> ---
The fixes landed in master, as well as in Mesa 19.1.0.

Closing this.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2116 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel