[Bug 110481] performance hot issues in amdgpu_cs_ib_vm_chunk

[Bug 110481] performance hot issues in amdgpu_cs_ib_vm_chunk

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 1115 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110481

            Bug ID: 110481
           Summary: performance hot issues in amdgpu_cs_ib_vm_chunk
           Product: DRI
           Version: DRI git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/AMDgpu
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: baopeng88_com@163.com

We have encountered performance hot issues in vce module. Cpu occupancy rate
has been in the alloc_vmap_area function.
We found that calling the alloc_vmap_area function mainly occurs in the
amdgpu_cs_ib_vm_chunk function. So we removed the main loop judgment logic of
amdgpu_cs_ib_vm_chunk.
as follows .
-       if (p->ring->funcs->parse_cs || p->ring->funcs->patch_cs_in_place) {
+       if (0)
If we don't delete, vce will be very slow.

Is this the fundamental way to solve the problem? Or there are other ways to
solve the problem？

3q very much.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2428 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110481] performance hot issues in amdgpu_cs_ib_vm_chunk

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 717 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110481

--- Comment #1 from baopeng <baopeng88_com@163.com> ---
performance hot stack:

start_thread ->
impl_thrd_routine ->
util_queue_thread_func ->                               
amdgpu_cs_submit_ib     ->
amdgpu_cs_submit_raw ->                                 
drmCommandWriteRead ->
ioctl ->
el0_svc ->
el0_svc_handler ->
el0_svc_common ->
__arm64_sys_ioctl ->
ksys_ioctl ->
do_vfs_ioctl ->         
amdgpu_drm_ioctl ->
drm_ioctl ->
drm_ioctl_kernel ->
amdgpu_cs_ioctl ->
amdgpu_bo_kmap->
ttm_bo_kmap ->
vmap ->
__get_vm_area_node ->           
alloc_vmap_area

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1556 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110481] performance hot issues in amdgpu_cs_ib_vm_chunk

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 726 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110481

--- Comment #2 from Christian König <christian.koenig@amd.com> ---
(In reply to baopeng from comment #0)
> -	if (p->ring->funcs->parse_cs || p->ring->funcs->patch_cs_in_place) {
> +       if (0)
> If we don't delete, vce will be very slow.
> 
> Is this the fundamental way to solve the problem?

Well certainly not, this code is important for VCE handle management.

> Or there are other ways to solve the problem？

Well what problem do you have? VCE usually uses less than 100 submissions per
second, so that you run into any performance bottleneck here is rather
unlikely.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1646 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 110481] performance hot issues in amdgpu_cs_ib_vm_chunk

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 805 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110481

Martin Peres <martin.peres@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #3 from Martin Peres <martin.peres@free.fr> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/drm/amd/issues/756.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2365 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel