[Bug 110963] Wrong condition and wrong variable substitution in libgl1-amdgpu-mesa-dri in postinst script - bugzilla-daemon

From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 110963] Wrong condition and wrong variable substitution in libgl1-amdgpu-mesa-dri in postinst script
Date: Sat, 22 Jun 2019 03:32:18 +0000	[thread overview]
Message-ID: <bug-110963-502@http.bugs.freedesktop.org/> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1127 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=110963

            Bug ID: 110963
           Summary: Wrong condition and wrong variable substitution in
                    libgl1-amdgpu-mesa-dri in postinst script
           Product: DRI
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: DRM/AMDgpu-pro
          Assignee: dri-devel@lists.freedesktop.org
          Reporter: ashark@linuxcomp.ru

19.20-812932 release for Ubuntu

In libgl1-amdgpu-mesa-dri in postinst script there is such condition:
    # Support I+A hybrid graphics 
    if [ -f ... ] && [ "str1" != "str2" ]; then
You just compare two different strings? I guess you wanted to compare folder
contents. But now that second condition will always be true.

Further there is:
    if [ "${f%%/*}" = ... ]; then
there is extra percent symbol, you should remove it. Btw, in rpm release
variant in scriptlet there is no such mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2484 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel