[Bug 111199] New: Bug in dither.depth property set - bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ

From: bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ@public.gmane.org
To: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: [Bug 111199] New: Bug in dither.depth property set
Date: Tue, 23 Jul 2019 09:38:33 +0000	[thread overview]
Message-ID: <bug-111199-8800@http.bugs.freedesktop.org/> (raw)

[-- Attachment #1.1: Type: text/plain, Size: 1239 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=111199

            Bug ID: 111199
           Summary: Bug in dither.depth property set
           Product: xorg
           Version: unspecified
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
          Reporter: max.kammerer-/E1597aS9LQAvxtiuMwx3w@public.gmane.org
        QA Contact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org

There is probably a bug in dither.depth property set cause its value compared
with dither.mode:

//nouveau_connector.c

if (property == disp->dithering_mode) {
    if (asyc->dither.mode != val) {
        asyc->dither.mode = val;
        asyc->set.dither = true;
    }
} else
if (property == disp->dithering_depth) {
    if (asyc->dither.mode != val) { //Should be dither.depth
        asyc->dither.depth = val;
        asyc->set.dither = true; //triggers dithering regardless of dither.mode
set above. Copy/Paste from above? Should be removed?
    }
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2534 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau