[Bug 14953] New: patch for checking double scan mode on correct crtc

[Bug 14953] New: patch for checking double scan mode on correct crtc

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=14953

           Summary: patch for checking double scan mode on correct crtc
           Product: xorg
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
        ReportedBy: obiwan-ajv+KCCKUOlAfugRpC6u6w@public.gmane.org
         QAContact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org


Created an attachment (id=15028)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=15028)
patch for getting correct overlay crtc

Last week I noticed I got occasionally problems with Xv because video was not
correctly placed in the window (using the overlay). Some further investigation
showed that the video was not only misplaced in the y direction, but also very
elongated.

The problem was due to CurrentLayout.mode being undefined under randr12, to
mode.Flags being some random number that occasionally lead the driver to think
i was using a doublescan mode. This was recently fixed in git by malc0 using
currentMode->Flags. However, malc0 noted in the changelog that this may also
not be correct for randr12 (It works here, but I think it may in some setups
not always point to the mode on the overlay crtc).

Attached patch should fix this.

Danny


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 14953] patch for checking double scan mode on correct crtc

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=14953


Danny <obiwan-ajv+KCCKUOlAfugRpC6u6w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15028|0                           |1
        is obsolete|                            |




--- Comment #1 from Danny <obiwan-ajv+KCCKUOlAfugRpC6u6w@public.gmane.org>  2008-03-11 05:22:28 PST ---
Created an attachment (id=15031)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=15031)
updated patch

obviously, the patch was wrong for the non-randr12 case. Here 's an updated
version.

d.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 14953] patch for checking double scan mode on correct crtc

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=14953


Stuart Bennett <sb476-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Stuart Bennett <sb476-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>  2008-03-11 10:16:56 PST ---
Thanks; pushed.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.