[Bug 17138] New: Randr12 on nv34m causes colour corruption on laptop panel.

[Bug 17138] New: Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138

           Summary: Randr12 on nv34m causes colour corruption on laptop
                    panel.
           Product: xorg
           Version: git
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
        ReportedBy: murray-Xhi4+0Yxd7rk1uMJSBkQmQ@public.gmane.org
         QAContact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org


Created an attachment (id=18284)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=18284)
vbtracetool vBIOS dump

Starting X with git nouveau and Randr12 disabled works perfectly.
Enabling Randr12 gives a somewhat corrupted screen which is predominantly red.

My system is a Dell Inspiron 5150 with a 1600x1200 screen and an nv34m.

The corruption is only on the internal panel. Any external screen on the VGA
output seems to be fine.

Bug #14403 seemed to be the closest to my experience and so I messed around
with nv_bios.c.

In the function parse_lvds_manufacturer_table_init the section labeled:

   /* adjust some things if straps are invalid (implies the panel has EDID) */

resets the lvdsmanufacturerindex from 3 to 0.

Putting in a line to set this back to 3 (or indeed 1 or 2) makes everything
seem to work fine.

I did a BIOS dump with vbtracetool. Does this help?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138





--- Comment #1 from Stuart Bennett <sb476-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>  2008-08-14 11:32:41 PST ---
Xorg.0.log while using randr12 as well please


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138





--- Comment #2 from Murray Campbell <murray-Xhi4+0Yxd7rk1uMJSBkQmQ@public.gmane.org>  2008-08-14 12:02:38 PST ---
Created an attachment (id=18285)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=18285)
Xorg.0.log without patch

This is the Xorg.0.log with Randr12 enabled and the original nv_bios.c


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138


Murray Campbell <murray-Xhi4+0Yxd7rk1uMJSBkQmQ@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18285|application/octet-stream    |text/plain
          mime type|                            |




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138





--- Comment #3 from Murray Campbell <murray-Xhi4+0Yxd7rk1uMJSBkQmQ@public.gmane.org>  2008-08-14 12:06:08 PST ---
Created an attachment (id=18286)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=18286)
Xorg.0.log with patch

This is the Xorg.0.log with Randr12 enabled and nv_bios.c modified by applying
the patch:

--- nv_bios.c   2008-08-14 19:56:33.000000000 +0100
+++ nv_bios.c.altered   2008-08-14 19:56:02.000000000 +0100
@@ -3154,6 +3154,8 @@
                         * lvdsmanufacturerindex in this case; we don't */
                }

+               lvdsmanufacturerindex=3;
+
                headerlen = 2;
                recordlen = bios->data[bios->fp.lvdsmanufacturerpointer + 1];



-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138





--- Comment #4 from Stuart Bennett <sb476-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>  2008-08-15 11:34:14 PST ---
Created an attachment (id=18301)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=18301)
(hopefully correct) fix

Try this. There's a lot of code motion, so I might have got something wrong
still.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138





--- Comment #5 from Murray Campbell <murray-Xhi4+0Yxd7rk1uMJSBkQmQ@public.gmane.org>  2008-08-15 14:26:02 PST ---
(In reply to comment #4)

> Try this. There's a lot of code motion, so I might have got something wrong
> still.

Well, it seems to work here. I'll let you know if anything unusual transpires.

There is a white thin-ish vertical line about half the screen high that
flickers once as X starts. This never happened before but, of course, it's not
a problem.

Thanks for looking into this so quickly.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 17138] Randr12 on nv34m causes colour corruption on laptop panel.

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=17138


Stuart Bennett <sb476-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from Stuart Bennett <sb476-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>  2008-08-15 16:33:19 PST ---
Committed to master


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.