All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [DPDK/ethdev Bug 1808] net/gve: possible misuse of comma
Date: Thu, 23 Oct 2025 23:43:51 +0000	[thread overview]
Message-ID: <bug-1808-3@http.bugs.dpdk.org/> (raw)

http://bugs.dpdk.org/show_bug.cgi?id=1808

            Bug ID: 1808
           Summary: net/gve: possible misuse of comma
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

If DPDK is built with clang and -Wcomma is enabled for drivers, then gve driver
has warnings:

[973/3622] Compiling C object drivers/...et_gve.a.p/net_gve_base_gve_adminq.c.o
../drivers/net/gve/base/gve_adminq.c:624:30: warning: possible misuse of comma
operator here [-Wcomma]
  624 |                         cpu_to_be64(rxq->mz->iova),
      |                                                   ^
../drivers/net/gve/base/gve_adminq.c:623:3: note: cast expression to void to
silence warning
  623 |                 cmd.create_rx_queue.rx_desc_ring_addr =
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 (void)(
  624 |                         cpu_to_be64(rxq->mz->iova),
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                   )
../drivers/net/gve/base/gve_adminq.c:626:35: warning: possible misuse of comma
operator here [-Wcomma]
  626 |                         cpu_to_be64(rxq->data_mz->iova),
      |                                                        ^
../drivers/net/gve/base/gve_adminq.c:625:3: note: cast expression to void to
silence warning
  625 |                 cmd.create_rx_queue.rx_data_ring_addr =
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 (void)(
  626 |                         cpu_to_be64(rxq->data_mz->iova),
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                        )
2 warnings generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.

                 reply	other threads:[~2025-10-23 23:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-1808-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.