[DPDK/ethdev Bug 1808] net/gve: possible misuse of comma

[DPDK/ethdev Bug 1808] net/gve: possible misuse of comma

[bugzilla]

http://bugs.dpdk.org/show_bug.cgi?id=1808

            Bug ID: 1808
           Summary: net/gve: possible misuse of comma
           Product: DPDK
           Version: 20.11
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: stephen@networkplumber.org
  Target Milestone: ---

If DPDK is built with clang and -Wcomma is enabled for drivers, then gve driver
has warnings:

[973/3622] Compiling C object drivers/...et_gve.a.p/net_gve_base_gve_adminq.c.o
../drivers/net/gve/base/gve_adminq.c:624:30: warning: possible misuse of comma
operator here [-Wcomma]
  624 |                         cpu_to_be64(rxq->mz->iova),
      |                                                   ^
../drivers/net/gve/base/gve_adminq.c:623:3: note: cast expression to void to
silence warning
  623 |                 cmd.create_rx_queue.rx_desc_ring_addr =
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 (void)(
  624 |                         cpu_to_be64(rxq->mz->iova),
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                   )
../drivers/net/gve/base/gve_adminq.c:626:35: warning: possible misuse of comma
operator here [-Wcomma]
  626 |                         cpu_to_be64(rxq->data_mz->iova),
      |                                                        ^
../drivers/net/gve/base/gve_adminq.c:625:3: note: cast expression to void to
silence warning
  625 |                 cmd.create_rx_queue.rx_data_ring_addr =
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 (void)(
  626 |                         cpu_to_be64(rxq->data_mz->iova),
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                        )
2 warnings generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.