[Bug 215177] New: Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[Bug 215177] New: Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215177

            Bug ID: 215177
           Summary: Stop exporting platform_profile interface for Lenovo
                    T14/P14s Gen2 AMD
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.15.5
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: bjoern.daase@gmail.com
        Regression: No

The T14/P14s Gen2 AMD (and maybe more?) have a completely broken platform
profile implementation. While advertising three profiles, they do not change
anything. See
https://forums.lenovo.com/t5/Other-Linux-Discussions/T14-AMD-subpar-CPU-performance/m-p/5089829?page=1#5386521
for details.

As some user space software (e.g. platform-profiles-daemon) expects them to
work correctly when they are available, they should not be exported for broken
devices.

Therefore, I suggest to stop exporting a platform_profile interface for the
Lenovo T14/P14s Gen2 AMD.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215177] Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215177

mario.limonciello@amd.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.limonciello@amd.com

--- Comment #1 from mario.limonciello@amd.com ---
It's fortunate that it's a noop right now and not causing a performance
degradation.   Presumably these systems DYTC interface *does* work on Windows
though, and with the modified calls right?

I suppose there are two short term ways to approach this:
1) Quirk thinkpad_acpi to these systems/ broken BIOS versions to disable
platform profiles.  This assumes it will be fixed in a future BIOS version.
2) Quirk thinkpad_acpi to use the corrected argument mapping on these systems,
mentioned in that linked issue.

IMO between those two options the second sounds better.

In the longer term though I think the discrepancy of expectations needs to be
fixed in thinkpad_acpi.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215177] Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215177

--- Comment #2 from bjoern.daase@gmail.com ---
That's indeed the better option. 
I just wasn't sure there is anyone who has the knowledge to fix this who also
wants to fix this, as this definitely sounds more complex than simply disabling
them.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215177] Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215177

Mark Pearson (markpearson@lenovo.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markpearson@lenovo.com

--- Comment #3 from Mark Pearson (markpearson@lenovo.com) ---
Just to note here, as is stated in the Lenovo forum thread where this was
originally raised, I am looking into this with the AMD platforms FW team to see
if we can add support.
I'll update once I have a better understanding of the best way to solve it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215177] Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215177

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #4 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
This has been fixed in 5.18 and later:
https://github.com/torvalds/linux/commit/e1c21608e3cfc4b44ecdf04e12986b6564667095

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215177] Stop exporting platform_profile interface for Lenovo T14/P14s Gen2 AMD

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215177

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|All                         |AMD
           Assignee|drivers_platform_x86@kernel |markpearson@lenovo.com
                   |-bugs.osdl.org              |

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.