[Bug 215730] New: acpi_bus_register_driver() does not work on Alder Lake

[Bug 215730] New: acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

            Bug ID: 215730
           Summary: acpi_bus_register_driver() does not work on Alder Lake
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.13, 5.16, maybe all.
          Hardware: x86-64
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: xuemin.wu@dbh.dynabook.com
        Regression: No

e.g.

in drivers/platform/x86/toshiba_acpi.c
acpi_bus_register_driver(&toshiba_acpi_driver);
does not work:

when execute acpi_bus_register_driver(&toshiba_acpi_driver).
the ".add" function is not called to add the driver.

and dmesg no errors/warnings have been reported when insmod this driver.

This issue exists on Alder Lake.
This issue does not exist on Tiger Lake.

Thank you.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

Matthew Garrett (mjg59-kernel@srcf.ucam.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjg59-kernel@srcf.ucam.org

--- Comment #1 from Matthew Garrett (mjg59-kernel@srcf.ucam.org) ---
Can you attach the output of acpidump? It's unlikely that this is down to the
CPU, but more likely that the device ID has changed.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #2 from xuemin (xuemin.wu@dbh.dynabook.com) ---
Created attachment 300602
  --> https://bugzilla.kernel.org/attachment.cgi?id=300602&action=edit
acpidump.output.txt

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #3 from xuemin (xuemin.wu@dbh.dynabook.com) ---
(In reply to Matthew Garrett from comment #1)
> Can you attach the output of acpidump? It's unlikely that this is down to
> the CPU, but more likely that the device ID has changed.
Hi Garrett,
Thank you for the infomation.
Please see the attached file above.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #4 from Matthew Garrett (mjg59-kernel@srcf.ucam.org) ---
Yes, no devices supported by toshiba_acpi are present in your ACPI tables, so
this is expected. Any functionality that toshiba_acpi has is probably
implemented via WMI instead on this device.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #5 from xuemin (xuemin.wu@dbh.dynabook.com) ---
Created attachment 300608
  --> https://bugzilla.kernel.org/attachment.cgi?id=300608&action=edit
acpidump.output.txt--after-updated-latest-BIOS

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #6 from xuemin (xuemin.wu@dbh.dynabook.com) ---
Hi Garrett

Thank you.


Which ACPI table related? which device id?
Would you tell some details about it?  
I checked the device on Windows, seems the functions are working without
problems.
(Windows uses the same ACPI tables/interfaces from BIOS too)

I have updated the latest BIOS for the device. but no luck to the problem.
I attached again the new acpidump out after updating the latest BIOS. 
Would your check if still the same issue ( devices id related?)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #7 from Matthew Garrett (mjg59-kernel@srcf.ucam.org) ---
acpi_bus_register_driver passes a set of supported ACPI device IDs to the
kernel. In the case of toshiba_acpi, it's:

       {"TOS6200", 0},
        {"TOS6207", 0},
        {"TOS6208", 0},
        {"TOS1900", 0},

If your firmware exposes any of these devices then the add method will be
called. Your firmware doesn't expose any of them, and so it isn't. The driver
simply doesn't support your hardware.

What functionality on your system is not working?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #8 from xuemin (xuemin.wu@dbh.dynabook.com) ---
All functions which depending on toshiba_acpi are not working.

static struct acpi_driver toshiba_acpi_driver = {
        .name   = "Toshiba ACPI driver",
        .owner  = THIS_MODULE,
        .ids    = toshiba_device_ids,
        .flags  = ACPI_DRIVER_ALL_NOTIFY_EVENTS,
        .ops    = {
                .add            = toshiba_acpi_add, // ===> here
                .remove         = toshiba_acpi_remove,
                .notify         = toshiba_acpi_notify,
        },
        .drv.pm = &toshiba_acpi_pm,
};

the toshiba_acpi_add(...){ ...} not be excuted on that device.
Thanks.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #9 from Matthew Garrett (mjg59-kernel@srcf.ucam.org) ---
Your laptop does not implement the ACPI interfaces that this driver needs.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

xuemin (xuemin.wu@dbh.dynabook.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #10 from xuemin (xuemin.wu@dbh.dynabook.com) ---
Hi Garrett

Thank you very much for your advise.
I confirmed with the BIOS team of the laptop.
A new device Id has been added from Alder Lake platfrom:
 { "DNBK0001",0}

I added above device Id and the toshiba_acpi driver works on the laptop.

Thank you.

Best regards.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 215730] acpi_bus_register_driver() does not work on Alder Lake

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=215730

--- Comment #11 from xuemin (xuemin.wu@dbh.dynabook.com) ---
*** Bug 215724 has been marked as a duplicate of this bug. ***

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.