From: bugzilla-daemon@kernel.org
To: linux-man@vger.kernel.org
Subject: [Bug 215848] fopen(3): Incorrect good practice suggestion
Date: Mon, 18 Apr 2022 03:32:14 +0000 [thread overview]
Message-ID: <bug-215848-11311-MPyqzJirxa@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-215848-11311@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=215848
--- Comment #1 from Avinash Sonawane (rootkea@gmail.com) ---
I think we should only mention using `fseek` as a good practice between read
and write operations since:
a. fflush can't be used on input stream i.e. if last operation was read while
fseek() can be used between read-write or write-read.
b. fsetpos needs fgetpos to be called first. So let's drop `fgetpos+fsetpos`
from the good practice suggestion
So I suggest this small change:
diff --git a/man3/fopen.3 b/man3/fopen.3
index a1d781706..fb289a537 100644
--- a/man3/fopen.3
+++ b/man3/fopen.3
@@ -138,8 +138,6 @@ result of writes other than the most recent.)
Therefore it is good practice (and indeed sometimes necessary
under Linux) to put an
.BR fseek (3)
-or
-.BR fgetpos (3)
operation between write and read operations on such a stream.
This operation may be an apparent no-op
(as in \fIfseek(..., 0L, SEEK_CUR)\fP
Thanks!
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
next prev parent reply other threads:[~2022-04-18 3:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-17 17:05 [Bug 215848] New: fopen(3): Incorrect good practice suggestion bugzilla-daemon
2022-04-18 3:32 ` bugzilla-daemon [this message]
2022-05-14 12:37 ` [Bug 215848] " bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-215848-11311-MPyqzJirxa@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@kernel.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.