[Bug 216455] New: PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[Bug 216455] New: PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

            Bug ID: 216455
           Summary: PCI AER error caused by LTR enablement on amdgpu with
                    LTR disabled on video card PCIe bridge
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.19.6
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
          Assignee: drivers_video-dri@kernel-bugs.osdl.org
          Reporter: wielkiegie@gmail.com
        Regression: No

Created attachment 301753
  --> https://bugzilla.kernel.org/attachment.cgi?id=301753&action=edit
dmesg with pci=earlydump (v5.19.5 + ltr debug patch)

Split off bug 216373 as this is a different issue than what it was initially
about.

To quote Bjorn:

> The issue you're seeing is an Unsupported Request error logged by a Switch
> Downstream Port when it received an LTR message sent by 44:00.0 when the
> Switch has LTR disabled:
>
>  pcieport 0000:43:00.0:   device [1022:1471] error
>  status/mask=00100000/00000000
>  pcieport 0000:43:00.0:    [20] UnsupReq               (First)
>  pcieport 0000:43:00.0: AER:   TLP Header: 34000000 44000010 00000000
>  84288428

The errors themselves can be masked by providing pci=noaer to the kernel.

The amdgpu.aspm=0 kernel option makes this issue disappear.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #1 from Gustaw Smolarczyk (wielkiegie@gmail.com) ---
Created attachment 301754
  --> https://bugzilla.kernel.org/attachment.cgi?id=301754&action=edit
lspci -vvnn on vega10 system

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #2 from Gustaw Smolarczyk (wielkiegie@gmail.com) ---
Hardware:
CPU: Ryzen Threadripper 1950X
MB: Asrock X399 Taichi
GPU: Radeon Vega 64 [1002:687f]

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #3 from Lijo Lazar (lijo.lazar@gmail.com) ---
Created attachment 301760
  --> https://bugzilla.kernel.org/attachment.cgi?id=301760&action=edit
LTR Fix

Does the attached patch help?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #4 from Gustaw Smolarczyk (wielkiegie@gmail.com) ---
Yes, it does. LTR+ is no longer being enabled with this patch.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

Alex Deucher (alexdeucher@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com

--- Comment #5 from Alex Deucher (alexdeucher@gmail.com) ---
(In reply to Lijo Lazar from comment #3)
> Created attachment 301760 [details]
> LTR Fix
> 
> Does the attached patch help?

The ASPM code in vi.c and cik.c and si.c should be similarly protected.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #6 from Lijo Lazar (lijo.lazar@gmail.com) ---
(In reply to Alex Deucher from comment #5)
> (In reply to Lijo Lazar from comment #3)
> > Created attachment 301760 [details]
> > LTR Fix
> > 
> > Does the attached patch help?
> 
> The ASPM code in vi.c and cik.c and si.c should be similarly protected.

Just checked. Actually, LTR settings are not changed in them.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #7 from Alex Deucher (alexdeucher@gmail.com) ---
(In reply to Lijo Lazar from comment #6)
> (In reply to Alex Deucher from comment #5)
> > (In reply to Lijo Lazar from comment #3)
> > > Created attachment 301760 [details]
> > > LTR Fix
> > > 
> > > Does the attached patch help?
> > 
> > The ASPM code in vi.c and cik.c and si.c should be similarly protected.
> 
> Just checked. Actually, LTR settings are not changed in them.

Yes, but they do setup ASPM which should be protected with CONFIG_PCIEASPM?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216455] PCI AER error caused by LTR enablement on amdgpu with LTR disabled on video card PCIe bridge

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216455

--- Comment #8 from Alex Deucher (alexdeucher@gmail.com) ---
Patch:
https://patchwork.freedesktop.org/patch/501912/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.