[Bug 216574] New: Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)

[Bug 216574] New: Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216574

            Bug ID: 216574
           Summary: Hybrid System Suspend broken HP EliteBook 845 G8
                    (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)
           Product: Drivers
           Version: 2.5
    Kernel Version: 6.0
          Hardware: AMD
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: kolAflash@kolahilft.de
        Regression: No

Created attachment 302984
  --> https://bugzilla.kernel.org/attachment.cgi?id=302984&action=edit
kernel log for hybrid sleep with s2idle: v6.0

Hybrid Sleep isn't working on the HP EliteBook 845 G8 Notebook.
Hybrid Sleep is documented here as "Hybrid System Suspend":
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/Documentation/admin-guide/pm/sleep-states.rst?h=v6.0.1#n220

uswsusp called this s2both.
(uswsusp is deprecated, but "Hybrid System Suspend" is currently supported by
the kernel if I don't get the documentation wrong)

This bug is forked off from:
https://bugzilla.kernel.org/show_bug.cgi?id=216516#c34



I initiate Hybrid Sleep this way:
echo suspend > /sys/power/disk
echo disk > /sys/power/state

But the system doesn't correctly enter Hybrid Sleep by activating s2idle.
Instead the system seems to do just a hibernation to disk.
So the system simply shuts down completely. At power on it resumes from
swapfile.

Correct behaviour would be to write the memory to swapfile (like hibernation to
disk), but then enter s2idle.
(the idea behind hybrid sleep is to prevent data loss if the battery is getting
drained while being in some suspend to memory)



The EliteBook 845 G8 (usually) only supports "s2idle" and no "deep" S3
mem_sleep mode.
See: https://bugzilla.kernel.org/show_bug.cgi?id=216516#c5

Using "systemctl start hybrid-sleep.target" yields the same result.
Please see attached dmesg output.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216574] Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216574

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.limonciello@amd.com

--- Comment #1 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Created attachment 302985
  --> https://bugzilla.kernel.org/attachment.cgi?id=302985&action=edit
Possible solution

I glanced through the kernel code and it seems to me it's currently hardcoded
to try to go into S3 instead of what the kernel is configured for (which may be
s2idle).

See if this patch helps.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216574] Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216574

--- Comment #2 from kolAflash (kolAflash@kolahilft.de) ---
@Mario

Your patch works like a charm :-)

v6.0.1 with your patch solves the problem.
Hybrid System Suspend works like intended.

v6.0.1 is still broken.

Do you need anything else from me to submit the patch to master?
(and maybe to stable branches)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216574] Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216574

Mario Limonciello (AMD) (mario.limonciello@amd.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #3 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
I've submitted it as
https://lore.kernel.org/linux-pm/20221013035017.5098-1-mario.limonciello@amd.com/T/#u
.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216574] Hybrid System Suspend broken HP EliteBook 845 G8 (a.k.a. Hybrid Sleep / s2both) (s2idle Notebook)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216574

--- Comment #4 from Mario Limonciello (AMD) (mario.limonciello@amd.com) ---
Fixed in 6.1-rc3 and also will trickle into stable kernels.
https://github.com/torvalds/linux/commit/85850af4fc47132f3f2f0dd698b90f67906600b4

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.