[Bug 218901] New: LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[Bug 218901] New: LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

            Bug ID: 218901
           Summary: LG Gram Laptop Extra Features not working on 2024
                    models (16Z90S)
           Product: Drivers
           Version: 2.5
    Kernel Version: 6.9,6.9.2,6.10-rc1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: agathe@boutmy.com
        Regression: No

On a 2024 LG Gram laptop, while the year is correctly identified by lg-laptop:
`[   12.865584] [    T528] lg_laptop: product: 16Z90S-G.AD7BF  year: 2022
`
some functionnalities such as battery charge limit and reader mode do not work.
The only error I have found so far is in dmesg: ```[   26.841164] [    T837]
lg_laptop: Cannot get handle
[   26.865830] [   T1167] lg_laptop: Cannot get handle
```
it seems to be related to ACPI as this is what is returned here:
https://github.com/torvalds/linux/blob/master/drivers/platform/x86/lg-laptop.c#L106
(among other emplacements in the code)

Trying to read the value in
`/sys/devices/platform/lg-laptop/battery_care_limit` or
`/sys/class/power_supply/BAT0/charge_control_end_threshold` results in a `cat:
/sys/class/power_supply/BAT0/charge_control_end_threshold: Input/output error
` in both cases and trying to write 80 or 100 returns the same error.
this also happens for `reader_mode`, `fan_mode`, `usb_charge` and `fn_lock`.
I have not tried the other variables but the keyboard lightning does not seem
to be impacted by this.

I have tried on both new installations of Manjaro and Fedora as well as Fedora
Rawhide and Manjaro with a 6.9.2 kernel and 6.10-rc1 kernel freshly compiled.

A colleague has the 2023 version of the laptop and the issue is not present on
kernel 6.9.1.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

Armin Wolf (W_Armin@gmx.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |W_Armin@gmx.de

--- Comment #1 from Armin Wolf (W_Armin@gmx.de) ---
Can you share the output of "acpidump"?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #2 from Agathe Boutmy (agathe@boutmy.com) ---
Created attachment 306358
  --> https://bugzilla.kernel.org/attachment.cgi?id=306358&action=edit
acpidump

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #3 from Agathe Boutmy (agathe@boutmy.com) ---
Comment on attachment 306358
  --> https://bugzilla.kernel.org/attachment.cgi?id=306358
acpidump

here is the acpidump, i wanted to join it to the initial report but couldn't
figure out how to install it at first on Manjaro, I just realized it was part
of acpica

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #4 from Armin Wolf (W_Armin@gmx.de) ---
It seems that the LGEX0820 device used by this driver is not mapped at \XINI,
but rather at \_SB.XINI. This should normally cause no problems, but it seems
that the driver is not using the ACPI driver model.

Can you compile and load kernel modules on this device?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #5 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #4)
> It seems that the LGEX0820 device used by this driver is not mapped at
> \XINI, but rather at \_SB.XINI. This should normally cause no problems, but
> it seems that the driver is not using the ACPI driver model.
> 
> Can you compile and load kernel modules on this device?

Yes, it's basically a new installation, if something breaks I can reinstall it
completely with no issue so I can test whatever is needed on it.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #6 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #4)
Did you have a specific kernel module in mind?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #7 from Armin Wolf (W_Armin@gmx.de) ---
I think i will send you an modified lg-laptop module for testing.
Before i do that, i have some questions for you:

1. Does /sys/bus/platform/devices/LGEX0820:00/ exist?

2. What is the content of /sys/bus/acpi/devices/LGEX0820:00/status ?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #8 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #7)
> I think i will send you an modified lg-laptop module for testing.
> Before i do that, i have some questions for you:
> 
> 1. Does /sys/bus/platform/devices/LGEX0820:00/ exist?

Yes!

> 2. What is the content of /sys/bus/acpi/devices/LGEX0820:00/status ?

31

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #9 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306399
  --> https://bugzilla.kernel.org/attachment.cgi?id=306399&action=edit
Prototype kernel module

This modified lg-laptop kernel module should work on you device.

You can compile it by executing the following commands inside the unpacked
directory:

1. make
2. sudo modprobe -r lg-laptop
3. sudo insmode lg-laptop.ko

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #10 from Armin Wolf (W_Armin@gmx.de) ---
Can you check that everything works now?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #11 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #10)
> Can you check that everything works now?

I wasn't able to load the module with insmod, I'm getting an unknown module
error.
dmesg lists the Unknown symbols as 

```
[ 5954.414920] lg_laptop: Unknown symbol sparse_keymap_entry_from_scancode (err
-2)
[ 5954.414956] lg_laptop: Unknown symbol sparse_keymap_report_entry (err -2)
[ 5954.415000] lg_laptop: Unknown symbol sparse_keymap_setup (err -2)
```

I couldn't figure how to fix it so I modprobed it instead:

1. zstd lg-laptop.ko
2. sudo cp -f lg-laptop.ko.zst /usr/lib/modules/$(uname
-r)/kernel/drivers/platform/x86/
3. sudo depmod
4. sudo modprobe lg-laptop

I think it's properly loaded now, however it does not work, I still have the
input output error when trying to read
/sys/class/power_supply/BAT0/charge_control_end_threshold and I don't know
whether that is normal but /sys/devices/platform/lg-laptop/ no longer exists.
I do have /sys/bus/platform/devices/lg-laptop/battery_care_limit however which
also returns an Input/Output Error.

On the dmesg side I have now: [   24.393457] lg-laptop lg-laptop: WMAB: call
failed when trying to cat one or the other.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #12 from Armin Wolf (W_Armin@gmx.de) ---
Did you unload the old module first?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #13 from Armin Wolf (W_Armin@gmx.de) ---
Or does dmesg show any ACPI errors?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #14 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306402
  --> https://bugzilla.kernel.org/attachment.cgi?id=306402&action=edit
Prototype kernel module v2

I made a mistake when calling the ACPI methods, can you try again?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #15 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #12)
> Did you unload the old module first?

yes

> Or does dmesg show any ACPI errors?

There is one that was already present before that I didn't mention because
after a little research it seemed to be unrelated, I'll post it here just in
case:

[   10.843998] ACPI Error: No handler for Region [XIN1] (00000000f9e347f6)
[UserDefinedRegion] (20240322/evregion-130)
[   10.844003] ACPI Error: Region UserDefinedRegion (ID=143) has no handler
(20240322/exfldio-261)
[   10.844007] ACPI Error: Aborting method \_SB.PC00.LPCB.H_EC.DPTF.SNRD due to
previous error (AE_NOT_EXIST) (20240322/psparse-529)
[   10.844010] ACPI Error: Aborting method \_SB.IETM.SEN2._TMP due to previous
error (AE_NOT_EXIST) (20240322/psparse-529)


> I made a mistake when calling the ACPI methods, can you try again?

It works!
(I think, I now longer have an input output error on battery care limit and I
have been able to set it to 80% and it seems to stop properly charging if I
believe what the power management service included with Manjaro is saying)
The other files are also correctly readable.
The 3 FN keys FN-F1, FN-F6, FN-F9 don't seem to do anything but strangely FN-F5
works (which it did before) maybe it's handled differently by the driver.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #16 from Agathe Boutmy (agathe@boutmy.com) ---
I just rebooted to check if the bios was now correctly saving the 80% charge
max value and it does, so it seems to be good on that end.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #17 from Agathe Boutmy (agathe@boutmy.com) ---
The /sys/devices/platform/lg-laptop/ folder is still missing so maybe that's
related to the issue with the 3 not working FN-keys.
Writing directly in /sys/bus/platform/devices/lg-laptop/reader_mode does not
seem to do anything, /sys/bus/platform/devices/lg-laptop/fn_lock however works.
I'm unsure whether fan_mode works or not.
I'm going to turn off the laptop and check if usb_charge works.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #18 from Agathe Boutmy (agathe@boutmy.com) ---
usb_charge works properly!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #19 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306403
  --> https://bugzilla.kernel.org/attachment.cgi?id=306403&action=edit
Prototype kernel module v3

This should fix the missing /sys/devices/platform/lg-laptop/ directory. Can you
test again please?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #20 from Armin Wolf (W_Armin@gmx.de) ---
Regarding the FN-keys: i think this is a different problem. As soon as the
lg-laptop module works on your device, we can focus on getting you FN-keys to
work.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #21 from Agathe Boutmy (agathe@boutmy.com) ---
New module works, the directory is now present.
I was having an issue with the v2 that didn't happen immediately, the wifi kept
deactivating and the bluetooth activating. It only stopped after unloading the
lg-laptop module.
It does not seem to be happening with the v3 at least for now.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #22 from Armin Wolf (W_Armin@gmx.de) ---
Could it be that one of the FN-keys acts as some sort of airplane mode hotkey?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #23 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #22)
> Could it be that one of the FN-keys acts as some sort of airplane mode
> hotkey?

I'm not sure, it kept happening after rebooting and without pressing anything

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #24 from Armin Wolf (W_Armin@gmx.de) ---
Oh no, seems like we need to do a bit more reverse-engineering

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #25 from Armin Wolf (W_Armin@gmx.de) ---
Does dmesg report any debug messages like "Type: XX Eventcode: 0xXX"?

If yes, then please send me the output of dmesg after pressing the FN-keys.
Should the wifi issue happen again, please send me the dmesg output too.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #26 from Armin Wolf (W_Armin@gmx.de) ---
I just added the maintainer of the lg-laptop driver to the CC list. Maybe he
can help with reverse-engineering.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #27 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #25)
> Does dmesg report any debug messages like "Type: XX Eventcode: 0xXX"?
> 
> If yes, then please send me the output of dmesg after pressing the FN-keys.
> Should the wifi issue happen again, please send me the dmesg output too.

Yes, here they are:

FN key pressed: [ 8437.457099] lg_laptop: Type: 1    Eventcode: 0x30010000
FN key released: [ 8469.382650] lg_laptop: Type: 1    Eventcode: 0x30010001 //
also happens when pressing and after releasing FN-F1..4 (twice when releasing
since 2 keys are being released I guess)
FN-F1: [ 8491.979548] lg_laptop: Type: 1    Eventcode: 0xf070002
FN-F2: [ 8545.037702] lg_laptop: Type: 1    Eventcode: 0x9000087
FN-F3: [ 8561.170853] lg_laptop: Type: 1    Eventcode: 0x9000086
FN-F4: [ 8642.087767] lg_laptop: Type: 1    Eventcode: 0x10300100

FN-F5 has a different behaviour than the previous four: Here is the full list
of code sent when pressing them:
[ 8737.235169] lg_laptop: Type: 1    Eventcode: 0x30010000 // here only fn is
pressed
[ 8739.068108] lg_laptop: event guid 2
[ 8739.068163] lg_laptop: Type: 1    Eventcode: 0x30010001 // fn held and F5
pressed
[ 8739.091282] lg_laptop: event guid 2
[ 8739.091331] lg_laptop: Type: 1    Eventcode: 0x30020000
[ 8739.117827] lg_laptop: event guid 2
[ 8739.117872] lg_laptop: Type: 1    Eventcode: 0x30020001
[ 8739.145947] lg_laptop: event guid 0
[ 8739.146019] lg_laptop: Type: 1    Eventcode: 0x74
[ 8739.231070] lg_laptop: event guid 2
[ 8739.231127] lg_laptop: Type: 1    Eventcode: 0x30010001 //both key released
[ 8740.811039] lg_laptop: event guid 2
[ 8740.811101] lg_laptop: Type: 1    Eventcode: 0x30010001

FN-F6: [ 8938.295301] lg_laptop: Type: 1    Eventcode: 0xf000002 //behaves like
F1..F4

FN-F7 doesn't seem to have a unique code, here's what I get (it does what it's
supposed to though):
[ 9016.134096] lg_laptop: event guid 2
[ 9016.134153] lg_laptop: Type: 1    Eventcode: 0x30010000
[ 9017.160755] lg_laptop: event guid 2
[ 9017.160813] lg_laptop: Type: 1    Eventcode: 0x30010001
[ 9017.183855] lg_laptop: event guid 2
[ 9017.183905] lg_laptop: Type: 1    Eventcode: 0x30020000
[ 9017.210594] lg_laptop: event guid 2
[ 9017.210644] lg_laptop: Type: 1    Eventcode: 0x30020001
[ 9017.260458] lg_laptop: event guid 2
[ 9017.260507] lg_laptop: Type: 1    Eventcode: 0x30010001
[ 9017.537250] lg_laptop: event guid 2
[ 9017.537335] lg_laptop: Type: 1    Eventcode: 0x30010001

FN-F8, the keyboard brightness control key seems to be the one starting a loop
of disconnecting the wifi and activating bluetooth, pressing it once leads to
having to deactivate the module if I want to return to a stable state, here's
the output:

[ 9104.362389] lg_laptop: Type: 1    Eventcode: 0x30010000
[ 9106.929029] lg_laptop: event guid 2
[ 9106.929083] lg_laptop: Type: 1    Eventcode: 0x30010001
[ 9106.952201] lg_laptop: event guid 2
[ 9106.955362] lg_laptop: Type: 1    Eventcode: 0x10000000
[ 9107.059296] lg_laptop: event guid 2
[ 9107.059390] lg_laptop: Type: 1    Eventcode: 0x30010001
[ 9107.799205] ACPI: \_SB_.XINI: notify: 192
[ 9107.821281] wlp0s20f3: deauthenticating from 68:3f:7d:36:0b:15 by local
choice (Reason: 3=DEAUTH_LEAVING)
[ 9108.098842] lg_laptop: event guid 2
[ 9108.098888] lg_laptop: Type: 1    Eventcode: 0x30010001
[ 9108.815812] ACPI: \_SB_.XINI: notify: 192
[ 9108.829467] iwlwifi 0000:00:14.3: WRT: Invalid buffer destination
[ 9108.985519] iwlwifi 0000:00:14.3: Not valid error log pointer 0x0024B5C0 for
RT uCode
[ 9108.985633] iwlwifi 0000:00:14.3: WFPM_UMAC_PD_NOTIFICATION: 0x1f
[ 9108.985651] iwlwifi 0000:00:14.3: WFPM_LMAC2_PD_NOTIFICATION: 0x1f
[ 9108.985658] iwlwifi 0000:00:14.3: WFPM_AUTH_KEY_0: 0x80
[ 9108.985666] iwlwifi 0000:00:14.3: CNVI_SCU_SEQ_DATA_DW9: 0x0
[ 9108.986425] iwlwifi 0000:00:14.3: RFIm is deactivated, reason = 4
[ 9112.617854] wlp0s20f3: authenticate with 68:3f:7d:36:0b:15 (local
address=e4:c7:67:24:ee:74)
[ 9112.618541] wlp0s20f3: send auth to 68:3f:7d:36:0b:15 (try 1/3)
[ 9112.648263] wlp0s20f3: authenticated
[ 9112.648833] wlp0s20f3: associate with 68:3f:7d:36:0b:15 (try 1/3)
[ 9112.652551] wlp0s20f3: RX AssocResp from 68:3f:7d:36:0b:15 (capab=0x1511
status=0 aid=74)
[ 9112.655106] wlp0s20f3: associated
[ 9112.668475] wlp0s20f3: Limiting TX power to 23 (23 - 0) dBm as advertised by
68:3f:7d:36:0b:15
[ 9114.722923] lg_laptop: event guid 2
[ 9114.722982] lg_laptop: Type: 1    Eventcode: 0x30010000
[ 9114.899608] ACPI: \_SB_.XINI: notify: 192

My understanding of what happens looking at dmesg in follow mode is that it
sends the even once when pressing FN-F8 and then any keyboard use after that
sends the event again (fn key or not) which means any input results in the
network connecting or disconnecting.
It doesn't turn airplane mode on though.

FN-F9: [ 9658.815309] lg_laptop: Type: 1    Eventcode: 0xf020000

FN-F10..12 same behaviour as FN-F7 which makes me think this is handled
somewhere which would make sense since it's not a functionnality exclusive to
the LG Gram.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #28 from Armin Wolf (W_Armin@gmx.de) ---
I think i found the culprit, the driver does not check which notification codes
it receives and just blindly assumes that its an rfkill notification.

I will try to fix this tomorrow.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #29 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306408
  --> https://bugzilla.kernel.org/attachment.cgi?id=306408&action=edit
Prototype kernel module v4

I have removed the airplane mode hotkey handling from the driver, can you test
again if the wifi issues are resolved now?

Can you also send me the output of dmesg after pressing FN+F8? I am curious if
the strange ACPI events are still happening.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #30 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #29)
> Created attachment 306408 [details]
> Prototype kernel module v4
> 
> I have removed the airplane mode hotkey handling from the driver, can you
> test again if the wifi issues are resolved now?

Yes, it no longers deactivate the wifi.

> Can you also send me the output of dmesg after pressing FN+F8? I am curious
> if the strange ACPI events are still happening.

it is still happening: here is the output once I press FN+F8:

[26146.735205] lg_laptop: event guid 2
[26146.735305] lg_laptop: Type: 1    Eventcode: 0x30010000
[26148.031450] lg_laptop: event guid 2
[26148.031517] lg_laptop: Type: 1    Eventcode: 0x30010001
[26148.054930] lg_laptop: event guid 2
[26148.058063] lg_laptop: Type: 1    Eventcode: 0x10000000
[26148.141362] lg_laptop: event guid 2
[26148.141429] lg_laptop: Type: 1    Eventcode: 0x30010001
[26148.301453] lg_laptop: event guid 2
[26148.301518] lg_laptop: Type: 1    Eventcode: 0x30010001
[26148.324300] ACPI: \_SB_.XINI: notify: 192
[26150.350874] ACPI: \_SB_.XINI: notify: 192
[26151.363858] ACPI: \_SB_.XINI: notify: 192
[26152.380376] ACPI: \_SB_.XINI: notify: 192


it keeps sending the acpi event with any key press.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #31 from Agathe Boutmy (agathe@boutmy.com) ---
It also doesn't look like the FN+F8 is able to change the keyboard lightning
anymore.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #32 from Armin Wolf (W_Armin@gmx.de) ---
Does this mean that before loading the new lg-laptop driver, you where able to
control the keyboard backlight with FN+F8?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #33 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #32)
> Does this mean that before loading the new lg-laptop driver, you where able
> to control the keyboard backlight with FN+F8?

I think I might have tested it too quickly. It works, I just don't have the HUD
anymore when using it.
It also looks like the ACPI event is only sent when the keyboard lights are on.
My intuition is that it is used to tell the system to keep them on as long as
the keyboard is being used?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #34 from Armin Wolf (W_Armin@gmx.de) ---
So when you disable the keyboard backlight, the ACPI 192 events stop?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #35 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #34)
> So when you disable the keyboard backlight, the ACPI 192 events stop?

Yes. And I think the hud issue might have been because the laptop was in
hibernation before I tried, after a reboot it seems to work properly
(hibernation seems to break sound as well but I think I found a workaround).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #36 from Armin Wolf (W_Armin@gmx.de) ---
Which HUD you are referring to exactly?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #37 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #36)
> Which HUD you are referring to exactly?

The KDE (i think it's part of it anyway) on screen display. I thought it might
have been an event not being sent but I think it's just hibernation messing
some things up in that case so it's unrelated.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #38 from Armin Wolf (W_Armin@gmx.de) ---
Ok, in this case i will prepare the necessary patches for upstreaming lg-laptop
support for your device.

Does you device have an airplane mode/rfkill button?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #39 from Agathe Boutmy (agathe@boutmy.com) ---
Created attachment 306409
  --> https://bugzilla.kernel.org/attachment.cgi?id=306409&action=edit
Function key row

It does, on FN-F6, I've added a picture for reference.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #40 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306410
  --> https://bugzilla.kernel.org/attachment.cgi?id=306410&action=edit
Prototype wireless kotkey driver

If this rfkill button does not work out-of-the-box with the new lg-laptop
driver, then please test this kernel module.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #41 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #40)
> Created attachment 306410 [details]
> Prototype wireless kotkey driver
> 
> If this rfkill button does not work out-of-the-box with the new lg-laptop
> driver, then please test this kernel module.

It seems to work great with this module inserted!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

Armin Wolf (W_Armin@gmx.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306399|0                           |1
        is obsolete|                            |
 Attachment #306402|0                           |1
        is obsolete|                            |
 Attachment #306403|0                           |1
        is obsolete|                            |
 Attachment #306408|0                           |1
        is obsolete|                            |

--- Comment #42 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306424
  --> https://bugzilla.kernel.org/attachment.cgi?id=306424&action=edit
Prototype lg-laptop driver v5

Final prototype of the lg-laptop driver for upstreaming.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

Armin Wolf (W_Armin@gmx.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306410|0                           |1
        is obsolete|                            |

--- Comment #43 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 306425
  --> https://bugzilla.kernel.org/attachment.cgi?id=306425&action=edit
Prototype wireless kotkey driver v2


Final prototype of the wireless-hotkey driver for upstreaming.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #44 from Armin Wolf (W_Armin@gmx.de) ---
Can you test if both modules work on your machine? I just want to verify that
the changes which i am going to send upstream are correct.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #45 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #44)
> Can you test if both modules work on your machine? I just want to verify
> that the changes which i am going to send upstream are correct.

I just tested both, as far as I can tell they both work without issue, dmesg
isn't complaining.
I can correctly write and read the files in /sys/devices/platform/lg-laptop as
well.


Regarding the reader_mode one, it might be very subtle, I can't see it at all
(I'm colourblind but not in the colour range it's supposed to affect) but my
partner who works as an artist and is very peculiar about colour choices and
nuances tells me the display is slightly pinkish when writing 1 to it so it
might just be an issue of it being a very subtle reader mode.
FN-F9 doesn't seem to affect that tho.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #46 from Matan Ziv-Av (matan@svgalib.org) ---
I will look at the code later, but regarding the reader mode:

In models after 2017 (I am not sure about the exact years) reader mode only
controls the reader mode led. The firmware does not change the color
temperature, as it does in 2017 and older models.

I guess that whatever changes pressing FN-F9 happen in windows are done by
installed LG software.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #47 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Matan Ziv-Av from comment #46)
> I will look at the code later, but regarding the reader mode:
> 
> In models after 2017 (I am not sure about the exact years) reader mode only
> controls the reader mode led. The firmware does not change the color
> temperature, as it does in 2017 and older models.
> 
> I guess that whatever changes pressing FN-F9 happen in windows are done by
> installed LG software.

ok, that would make sense. It's not a big deal anyway since night mode exist.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #48 from Armin Wolf (W_Armin@gmx.de) ---
The necessary patches are now upstreamed an will likely be released with kernel
6.11.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #49 from Armin Wolf (W_Armin@gmx.de) ---
Alright, the necessary patches are already included in kernel 6.10 and will
also be backported to kernel 6.9, 6.6 and 6.1 thanks to the stable team.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #50 from Armin Wolf (W_Armin@gmx.de) ---
You might close this bug report as fixed then.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

Agathe Boutmy (agathe@boutmy.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #51 from Agathe Boutmy (agathe@boutmy.com) ---
(In reply to Armin Wolf from comment #50)
> You might close this bug report as fixed then.

done, thanks a bunch for the patch :)

I'm having another issue with some thermal stuff not being handled properly now
(it's generating a lot of spam in dmesg) but I don't think this is directly
related as this wasn't happening when testing the module, I'll open a new issue
when I have the time.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #52 from Armin Wolf (W_Armin@gmx.de) ---
I think i found a solution for you thermal dmesg spam problems, see
https://bugzilla.kernel.org/show_bug.cgi?id=219075 for more details.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #53 from Chris (ghostwind@gmail.com) ---
Created attachment 306693
  --> https://bugzilla.kernel.org/attachment.cgi?id=306693&action=edit
DMESG DUMP 2

Here you go. I also had to manually "battery", "sparse_keymap" and "wmi" before
the module would load

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #54 from Chris (ghostwind@gmail.com) ---
please ignore the above post. wrong ticket

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

tacodog311@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tacodog311@gmail.com

--- Comment #55 from tacodog311@gmail.com ---
This is still a bug.

I have an LG 16T90SP-K.AD89U1 LG 2-in-1, which has had issues with the Fn keys
as long as I've owned it. Specifically the keyboard backlight, the microphone
mute, and
the camera disable buttons do not seem to do anything.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #56 from Armin Wolf (W_Armin@gmx.de) ---
Please execute "echo "file drivers/platform/x86/lg-laptop.c +p" >
/sys/kernel/debug/dynamic_debug/control" and check if "dmesg" records any
entries similar to "Type: X   Eventcode: X" when said keys are pressed. I can
then add those event codes to the driver.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #57 from tacodog311@gmail.com ---
I ran that command as root, and I have these lines now in that control file:
drivers/platform/x86/lg-laptop.c:238 [lg_laptop]wmi_notify =p "Type: %i   
Eventcode: 0x%llx\n"
drivers/platform/x86/lg-laptop.c:276 [lg_laptop]acpi_notify =p "notify: %d\n"
drivers/platform/x86/lg-laptop.c:679 [lg_laptop]lg_laptop_address_space_write
=p "HD audio power %s\n"
drivers/platform/x86/lg-laptop.c:688 [lg_laptop]lg_laptop_address_space_write
=p "Fan mode set to mode %u\n"
drivers/platform/x86/lg-laptop.c:692 [lg_laptop]lg_laptop_address_space_write
=p "CPU temperature is %u °C\n"
drivers/platform/x86/lg-laptop.c:695 [lg_laptop]lg_laptop_address_space_write
=p "CPU lower trip point set to %u °C\n"
drivers/platform/x86/lg-laptop.c:698 [lg_laptop]lg_laptop_address_space_write
=p "CPU higher trip point set to %u °C\n"
drivers/platform/x86/lg-laptop.c:701 [lg_laptop]lg_laptop_address_space_write
=p "Motherboard temperature is %u °C\n"
drivers/platform/x86/lg-laptop.c:704 [lg_laptop]lg_laptop_address_space_write
=p "Motherboard lower trip point set to %u °C\n"
drivers/platform/x86/lg-laptop.c:707 [lg_laptop]lg_laptop_address_space_write
=p "Motherboard higher trip point set to %u °C\n"
drivers/platform/x86/lg-laptop.c:919 [lg_laptop]acpi_init =p "Error registering
driver\n"


There are no "Type: X  Eventcode: X" lines in dmesg, but these lines apear
after each button press

Fn F1: (no effect - settings? button)
[1097723.464413] ACPI: \XINI: lg_laptop: notify: 130
[1097723.895908] ACPI: \XINI: lg_laptop: notify: 130
[1097724.018615] ACPI: \XINI: lg_laptop: notify: 130
[1097724.130833] ACPI: \XINI: lg_laptop: notify: 130

Fn F2: (works screen brightness down)
[1097761.246182] ACPI: \XINI: lg_laptop: notify: 130
[1097761.480285] ACPI: \XINI: lg_laptop: notify: 128
[1097761.674707] ACPI: \XINI: lg_laptop: notify: 130
[1097761.733056] ACPI: \XINI: lg_laptop: notify: 130

Fn F3: (works - screen brightness up)
[1097871.463304] ACPI: \XINI: lg_laptop: notify: 130
[1097871.931609] ACPI: \XINI: lg_laptop: notify: 128
[1097872.119712] ACPI: \XINI: lg_laptop: notify: 130
[1097872.224662] ACPI: \XINI: lg_laptop: notify: 130

Fn F4: (works - touchpad on/off)
[1097895.738841] ACPI: \XINI: lg_laptop: notify: 130
[1097896.223999] ACPI: \XINI: lg_laptop: notify: 128
[1097896.290507] ACPI: \XINI: lg_laptop: notify: 130
[1097896.403914] ACPI: \XINI: lg_laptop: notify: 130

Fn F5: (works - display output change)
[1097937.733774] ACPI: \XINI: lg_laptop: notify: 130
[1097938.585044] ACPI: \XINI: lg_laptop: notify: 130
[1097938.868729] ACPI: \XINI: lg_laptop: notify: 130

Fn F6: (doesn't work - keyboard brightness)
[1097982.681501] ACPI: \XINI: lg_laptop: notify: 130
[1097982.818509] ACPI: \XINI: lg_laptop: notify: 130

Fn F7: (doesn't work - fan speed)
[1098282.555102] ACPI: \XINI: lg_laptop: notify: 130
[1098282.909315] ACPI: \XINI: lg_laptop: notify: 130
[1098283.116257] ACPI: \XINI: lg_laptop: notify: 130
[1098283.201884] ACPI: \XINI: lg_laptop: notify: 130

Fn F8: (doesn't work - microphone mute)
[1098300.478939] ACPI: \XINI: lg_laptop: notify: 130
[1098300.982330] ACPI: \XINI: lg_laptop: notify: 130
[1098301.089168] ACPI: \XINI: lg_laptop: notify: 130
[1098301.242992] ACPI: \XINI: lg_laptop: notify: 130

Fn F9: (doesn't work - disable camera)
[1098322.727108] ACPI: \XINI: lg_laptop: notify: 130
[1098323.213560] ACPI: \XINI: lg_laptop: notify: 130
[1098323.321364] ACPI: \XINI: lg_laptop: notify: 130
[1098323.509275] ACPI: \XINI: lg_laptop: notify: 130

Fn F10: (works audio mute)
[1098340.794792] ACPI: \XINI: lg_laptop: notify: 130
[1098341.421561] ACPI: \XINI: lg_laptop: notify: 130
[1098341.432123] ACPI: \XINI: lg_laptop: notify: 128
[1098341.684261] ACPI: \XINI: lg_laptop: notify: 130

Fn F11: (works volume down)
[1098355.263622] ACPI: \XINI: lg_laptop: notify: 130
[1098355.723023] ACPI: \XINI: lg_laptop: notify: 128
[1098355.960150] ACPI: \XINI: lg_laptop: notify: 130
[1098355.989765] ACPI: \XINI: lg_laptop: notify: 130

Fn F12: (works volume up)
[1098367.928555] ACPI: \XINI: lg_laptop: notify: 130
[1098368.780921] ACPI: \XINI: lg_laptop: notify: 128
[1098369.017551] ACPI: \XINI: lg_laptop: notify: 130
[1098369.029370] ACPI: \XINI: lg_laptop: notify: 130

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #58 from Armin Wolf (W_Armin@gmx.de) ---
I think i now understand what is going on:

- older devices report the events using WMI and can be manually
switched over to a ACPI-based native interface by executing the
ACPI control method "OREP(4, 1)".

- newer devices (yours) always use the ACPI-based native interface

The driver currently uses the WMI-based interface and thus does not
receive any events on your device. I think we can fix this by modifying
lg-laptop to always use the ACPI-based interface.

I will try to come up with a patch, give me a couple days.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #59 from tacodog311@gmail.com ---
Created attachment 310219
  --> https://bugzilla.kernel.org/attachment.cgi?id=310219&action=edit
acpidump

"acpidump" for an LG Gram

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #60 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 310222
  --> https://bugzilla.kernel.org/attachment.cgi?id=310222&action=edit
Prototype driver for improved hotkey handling.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #61 from Armin Wolf (W_Armin@gmx.de) ---
Use the attached driver and try again.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #62 from tacodog311@gmail.com ---
I added the new driver, but Fn F6-F9 still don't have any effect.  Below is the
dmesg of each button press.

Fn F1:
[  234.298681] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  235.717630] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  235.722288] LG Gram Laptop Support LGEX0820:00: Received event 130
(252116994)
[  235.964304] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F2:
[  296.616380] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  297.040336] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
[  297.251384] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  297.316138] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F3:
[  325.225102] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  325.723084] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
[  325.857201] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  326.075831] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F4:

[  344.611414] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  345.024743] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  345.041044] LG Gram Laptop Support LGEX0820:00: Received event 128 (116)
[  345.141209] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F5:
[  371.095864] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  371.624840] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  371.737024] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F6:
[  396.319396] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  396.833509] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  396.834992] LG Gram Laptop Support LGEX0820:00: Received event 128
(268435456)
[  396.988001] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F7:
[  417.595014] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  417.936728] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371985)
[  418.106754] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  418.217023] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F8:
[  454.740476] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  455.211017] LG Gram Laptop Support LGEX0820:00: Received event 130
(1073872897)
[  455.264917] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  455.369903] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F9:
[  470.879991] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  471.576893] LG Gram Laptop Support LGEX0820:00: Received event 130
(1073872896)
[  471.677192] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  471.681958] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F10:
[  488.525493] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  489.053501] LG Gram Laptop Support LGEX0820:00: Received event 128 (120)
[  489.149477] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  489.184508] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F11:
[  503.160266] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  503.631288] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
[  503.765229] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  503.920250] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

Fn F12:
[  520.136252] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371904)
[  520.849363] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
[  521.035001] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)
[  521.160264] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371905)

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #63 from Armin Wolf (W_Armin@gmx.de) ---
Do the previously working hotkeys still work?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

4966508hayk@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |4966508hayk@gmail.com

--- Comment #64 from 4966508hayk@gmail.com ---
I have the same laptop as tacodog311 and almost the same problems with Fn keys,
except for me, Fn + F10,F11,F12 don't release after pressing down. The release
can be triggered by pressing some other working Fn key (like Fn+F2), and after
that the Fn + F10,F11,F12 don't respond.

I added the driver and notice no change in hotkey behaviour (both working and
not working), except Fn+F4 (touchpad on/off), which happens twice.

As a side note, I believe the dmesg output lines

[  ...] LG Gram Laptop Support LGEX0820:00: Received event 130 (805371904)

and 

[  ...] LG Gram Laptop Support LGEX0820:00: Received event 130 (805371905)

in tacodog311's response represent the action of pressing/releasing the Fn key
respectively.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #65 from Armin Wolf (W_Armin@gmx.de) ---
So on your device the hotkeys will spam events until another hotkey is pressed?
Do both touchpad on/off events come from the driver or is one of them received
over the keyboard controller?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #66 from tacodog311@gmail.com ---
Yes, all of the previously working hotkeys still work after installing the
driver.

Regarding the "don't release after pressing down" issue, I do recall having to
implement this udev rule to get the F10-F12 volume keys to work properly.

https://askubuntu.com/questions/1314193/fixing-broken-volume-up-down-and-mute-keys-on-lg-gram-14-2-in-1

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

Armin Wolf (W_Armin@gmx.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310222|0                           |1
        is obsolete|                            |

--- Comment #67 from Armin Wolf (W_Armin@gmx.de) ---
Created attachment 310254
  --> https://bugzilla.kernel.org/attachment.cgi?id=310254&action=edit
Prototype driver with improved hotkey handling.

This driver should now forward the missing hotkey scancodes.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #68 from Armin Wolf (W_Armin@gmx.de) ---
F1 -> KEY_CONFIG
F2 -> Ignored
F3 -> Ignored
F4 -> KEY_F21
F5 -> Ignored
F6 -> KEY_F16 and notifying the LED class device
F7 -> KEY_PERFORMANCE
F8 -> KEY_MICMUTE
F9 -> KEY_CAMERA_ACCESS_TOGGLE
F10 -> Ignored
F11 -> Ignored
F12 -> Ignored

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #69 from Armin Wolf (W_Armin@gmx.de) ---
Please both check if the hotkeys now emit the aforementioned keycodes, you can
use evtest for that.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #70 from tacodog311@gmail.com ---
I think we're making progress. Fn+F1 and Fn+F8 seem to be working, but Fn+F4 no
longer toggles the touchpad.

F1 -> KEY_CONFIG  -- Working now
F2 -> Ignored -- still working
F3 -> Ignored -- still working
F4 -> KEY_F21 -- used to work, now "touchpad on" appears on the screen, doesn't
toggle, I suspect it triggers twice (off/on)? 
F5 -> Ignored -- still works
F6 -> KEY_F16 and notifying the LED class device -- still no effect
F7 -> KEY_PERFORMANCE -- still no effect
F8 -> KEY_MICMUTE -- Working now
F9 -> KEY_CAMERA_ACCESS_TOGGLE -- still no effect
F10 -> Ignored -- still works
F11 -> Ignored -- still works
F12 -> Ignored -- still works

I also notices that Fn+Esc is supposed to toggle the Fn lock, and that does not
currently work.

This is my evdev:

Fn+F1:
Event: time 1780527642.116637, type 4 (EV_MSC), code 4 (MSC_SCAN), value
f070002
Event: time 1780527642.116637, type 1 (EV_KEY), code 171 (KEY_CONFIG), value 1
Event: time 1780527642.116637, -------------- SYN_REPORT ------------
Event: time 1780527642.116658, type 1 (EV_KEY), code 171 (KEY_CONFIG), value 0
Event: time 1780527642.116658, -------------- SYN_REPORT ------------

Fn+F4:
Event: time 1780527664.185518, type 4 (EV_MSC), code 4 (MSC_SCAN), value 74
Event: time 1780527664.185518, type 1 (EV_KEY), code 191 (KEY_F21), value 1
Event: time 1780527664.185518, -------------- SYN_REPORT ------------
Event: time 1780527664.185529, type 1 (EV_KEY), code 191 (KEY_F21), value 0
Event: time 1780527664.185529, -------------- SYN_REPORT ------------

Fn+F6:
Event: time 1780527716.168356, type 4 (EV_MSC), code 4 (MSC_SCAN), value
10000000
Event: time 1780527716.168356, type 1 (EV_KEY), code 186 (KEY_F16), value 1
Event: time 1780527716.168356, -------------- SYN_REPORT ------------
Event: time 1780527716.168372, type 1 (EV_KEY), code 186 (KEY_F16), value 0
Event: time 1780527716.168372, -------------- SYN_REPORT ------------

Fn+F7:
Event: time 1780527729.707137, type 4 (EV_MSC), code 4 (MSC_SCAN), value
30010051
Event: time 1780527729.707137, type 1 (EV_KEY), code 701 (?), value 1
Event: time 1780527729.707137, -------------- SYN_REPORT ------------
Event: time 1780527729.707147, type 1 (EV_KEY), code 701 (?), value 0
Event: time 1780527729.707147, -------------- SYN_REPORT ------------

Fn+F8:
Event: time 1780527743.793305, type 4 (EV_MSC), code 4 (MSC_SCAN), value
40020001
Event: time 1780527743.793305, type 1 (EV_KEY), code 248 (KEY_MICMUTE), value 1
Event: time 1780527743.793305, -------------- SYN_REPORT ------------
Event: time 1780527743.793320, type 1 (EV_KEY), code 248 (KEY_MICMUTE), value 0
Event: time 1780527743.793320, -------------- SYN_REPORT ------------

Fn+F9:
Event: time 1780527761.607632, type 4 (EV_MSC), code 4 (MSC_SCAN), value
40020000
Event: time 1780527761.607632, type 1 (EV_KEY), code 589
(KEY_CAMERA_ACCESS_TOGGLE), value 1
Event: time 1780527761.607632, -------------- SYN_REPORT ------------
Event: time 1780527761.607655, type 1 (EV_KEY), code 589
(KEY_CAMERA_ACCESS_TOGGLE), value 0
Event: time 1780527761.607655, -------------- SYN_REPORT ------------

Fn+Esc:
Event: time 1780527879.303527, type 4 (EV_MSC), code 4 (MSC_SCAN), value
40030001
Event: time 1780527879.303527, type 1 (EV_KEY), code 240 (KEY_UNKNOWN), value 1
Event: time 1780527879.303527, -------------- SYN_REPORT ------------
Event: time 1780527879.303550, type 1 (EV_KEY), code 240 (KEY_UNKNOWN), value 0
Event: time 1780527879.303550, -------------- SYN_REPORT ------------
Event: time 1780527879.456554, type 4 (EV_MSC), code 4 (MSC_SCAN), value
30010001
Event: time 1780527879.456554, type 1 (EV_KEY), code 240 (KEY_UNKNOWN), value 1
Event: time 1780527879.456554, -------------- SYN_REPORT ------------
Event: time 1780527879.456569, type 1 (EV_KEY), code 240 (KEY_UNKNOWN), value 0
Event: time 1780527879.456569, -------------- SYN_REPORT ------------

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #71 from Armin Wolf (W_Armin@gmx.de) ---
evtest shows that all keys emit their respective keycodes, it seems that your
desktop simply does not handle KEY_PERFORMANCE and KEY_CAMERA_ACCESS_TOGGLE by
default.

The touchpad toggle key also does emit KEY_F21, so i have no idea why is should
not be working.

Can you share the output of dmesg again (with Fn+Esc?).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #72 from Quaternion (4966508hayk@gmail.com) ---
In my evtest, KEY_PERFORMANCE and KEY_CAMERA_ACCESS_TOGGLE are present. Maybe
the Fn+F4 has something to do with the settings? The combination started
toggling twice after you fixed settings. As a possible workaround, I can
mention that the touchpad state can be easily toggled inside settings.

Here is the new dmesg response (I omit the Fn key press/release event):

Fn+Esc:
[  978.268869] LG Gram Laptop Support LGEX0820:00: Received event 130
(1073938433)
Fn+F1:
[  411.436702] LG Gram Laptop Support LGEX0820:00: Received event 130
(252116994)
Fn+F2:
[  413.325769] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
Fn+F3:
[  414.323986] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
Fn+F4:
[  421.565755] LG Gram Laptop Support LGEX0820:00: Received event 128 (116)
Fn+F5:
Ignored
Fn+F6:
[  425.480991] LG Gram Laptop Support LGEX0820:00: Received event 128
(268435456)
Fn+F7:
[  427.640268] LG Gram Laptop Support LGEX0820:00: Received event 130
(805371985)
Fn+F8:
[  428.620331] LG Gram Laptop Support LGEX0820:00: Received event 130
(1073872897)
Fn+F9:
[  429.512356] LG Gram Laptop Support LGEX0820:00: Received event 130
(1073872896)
Fn+F10:
[  429.976413] LG Gram Laptop Support LGEX0820:00: Received event 128 (120)
Fn+F11:
[  430.509555] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)
Fn+F12:
[  431.333337] LG Gram Laptop Support LGEX0820:00: Received event 128 (0)

I use the lgfnlock.sh script from

https://github.com/leoomi/LinuxLGGramScripts

to get the Fn lock working.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #73 from Armin Wolf (W_Armin@gmx.de) ---
It seems that your desktop environment already mapps KEY_F21 to "Touchpad
toggle", so the touchpad indeeds gets toggled twice. I will check if i can
detect this somehow.

Does the Fn-Lock state change automatically when you press Fn+Esc? If no then i
can map event 1073938433 onto KEY_FN_ESC so you can intercept this with a
script.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #74 from Quaternion (4966508hayk@gmail.com) ---
No, I just run lgfnlock.sh in terminal to turn the Fn lock on/off. I cannot
trigger the Fn lock on/off event by pressing Fn+Esc.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #75 from Armin Wolf (W_Armin@gmx.de) ---
Can you check with evtest where the second touchpad event comes from?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #76 from Quaternion (4966508hayk@gmail.com) ---
This is weird. When I run 

sudo evtest --grab /dev/input/event13,

only one touchpad event happens, so everything works normally. Otherwise, there
is the double-toggle, but only one touchpad event is registered in 

sudo evtest

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 218901] LG Gram Laptop Extra Features not working on 2024 models (16Z90S)

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=218901

--- Comment #77 from Armin Wolf (W_Armin@gmx.de) ---
Can you check if another input device emits this touchpad event?

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.