[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

Borislav Petkov (bp@alien8.de) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bp@alien8.de
           Assignee|platform_x86_64@kernel-bugs |drivers_platform_x86@kernel
                   |.osdl.org                   |-bugs.osdl.org

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@fedoraproject.or
                   |                            |g

--- Comment #8 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
bugreporter23 thank you for your work on debugging this.

I think that I know what the problem is, let me write and attach a patch which
should fix this.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #9 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Created attachment 308064
  --> https://bugzilla.kernel.org/attachment.cgi?id=308064&action=edit
[PATCH] platform/x86: asus-wmi: Fix wlan_ctrl_by_user detection

I think this patch should fix things.

If you are seeing this problem, please give this patch a try. See your
distributions documentation for how to build a local kernel with a patch
applied.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308064|0                           |1
        is obsolete|                            |

--- Comment #10 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Created attachment 308065
  --> https://bugzilla.kernel.org/attachment.cgi?id=308065&action=edit
[PATCH] platform/x86: asus-wmi: Fix wlan_ctrl_by_user detection

New version of the patch which I hope will fix things. Note only the commit
message has changed, if you've already started a build with the old patch that
is fine. I just wanted to make sure that anyone reading the commit message, for
an explanation of the fix, will be reading the fixed version.

If you are seeing this problem, please give this patch a try. See your
distributions documentation for how to build a local kernel with a patch
applied.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #11 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
bugreporter23 in case your wondering, this part of your logs:

[32267.286227] asus_wmi: asus_wmi_evaluate_method3 called (0x53545344) with
args: 0x00010011, 0x00000000, 0x00000000
[32267.286245] asus_wmi: Result: 0x00050000

Shows that a get status (0x53545344) on the wlan-devid (0x00010011) returns
0x00050000 since 0x00050000 has ASUS_WMI_DSTS_BIOS_BIT (0x00040000) set and
more importantly, does not have ASUS_WMI_DSTS_USER_BIT (0x00020000) set, the
device-set (0x53564544) call should also be done on the wlan-devid
(0x00010011).

But the logs show that instead this is being done on the wlan-led-devid
(0x00010012):

[32267.287502] asus_wmi: asus_wmi_evaluate_method3 called (0x53564544) with
args: 0x00010012, 0x00000001, 0x00000000
[32267.287508] asus_wmi: Result: 0xfffffffe
[32267.287511] asus_wmi: asus_wmi_evaluate_method3, (0x53564544), arg
0x00010012 failed: -19

The use of the wlan-led-devid instead of the wlan-devid is caused by
wlan_ctrl_by_user wrongly getting set when the get status call returns
0x00050000 and that is what my patch fixes.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #12 from lbtowers@proton.me ---
Just built a new kernel (6.14.4-arch1-2) with the patch. Seems to indeed have
fixed the issue:

❯ rfkill
ID TYPE      DEVICE              SOFT      HARD
 0 wlan      asus-wlan      unblocked unblocked
 1 bluetooth asus-bluetooth unblocked unblocked
 2 bluetooth hci0           unblocked unblocked
 3 wlan      phy0           unblocked unblocked

I'm not sure if this is solely due to this patch, but Wi-Fi also seems to
automatically be re-enabled after resuming from suspend. I'll have to test this
on a clean install some other time.

I had been mucking around the asus-wmi code for a while but couldn't figure out
what was going on such that asus-wlan was being soft-blocked. Turns out it was
an issue I had no hope of understanding, way out of my scope of knowledge.

Thank you so much for the fix!

Thank you so much as well, bugreporter23, sorry I couldn't help much further
with debugging, though, lol.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #13 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
Thank you for testing the patch so quickly

I've posted the patch upstream now:

https://lore.kernel.org/platform-driver-x86/20250501131702.103360-1-hdegoede@redhat.com/

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #14 from Charlie R (kernel.t8jyh@passmail.net) ---
Thank you for the patch, this is a great improvement.

Providing feedback -

With this patch, the Wi-Fi comes up automatically (great!).

The only quirk I can notice is that when I'm connected to a network, if I
toggle off Wi-Fi, it shows toggled on once again, and I have to toggle it off
twice to have it remain off. I would expect it would only have to be toggled
off once, but this does not hinder usability.  If I'm not connected to a
network, I can toggle it off once and it toggles off normally.

Toggling Wi-Fi on works as expected.

I am happy to provide additional/debug information if you need it.

Thank you for this patch!

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #15 from Louie Torres (lbtowers@proton.me) ---
> The only quirk I can notice is that when I'm connected to a network, if I
> toggle off Wi-Fi, it shows toggled on once again, and I have to toggle it off
> twice to have it remain off.

Are you running GNOME? I don't get this behavior on KDE. Toggling off Wi-Fi
immediately reflects the changes and disconnects me from the current network,
and the same goes for toggling it on.

The behavior is the same regardless of whether I am connected to a network.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

--- Comment #16 from Charlie R (kernel.t8jyh@passmail.net) ---
Interesting. Yes, that was in GNOME.  I switched to KDE and all works well.

Thanks for the patch and the quick feedback. Works great.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 219786] asus-wmi: WLAN is permanently soft-blocked on S5406SA, but can still connect to networks

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=219786

Ian Su (thisisianemail@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thisisianemail@gmail.com

--- Comment #17 from Ian Su (thisisianemail@gmail.com) ---
Tested on fedora 42, everything works beautifully. Thank you soooo much! By the
way I didn't experience the toggle wifi bug on gnome, everything function
normally.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.