[Bug 222138] New: hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[Bug 222138] New: hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

            Bug ID: 222138
           Summary: hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE
                    on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never
                    calls GMCF
           Product: Drivers
           Version: 2.5
          Hardware: AMD
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Platform_x86
          Assignee: drivers_platform_x86@kernel-bugs.osdl.org
          Reporter: lorenzocollevecchio17@gmail.com
        Regression: No

Created attachment 311136
  --> https://bugzilla.kernel.org/attachment.cgi?id=311136&action=edit
acpidump

Hardware: HP OmniBook 5 Laptop 16-ag1xxx (16-AG1002SL)
Board: HP 8DF4
BIOS: F.12, 04/10/2026
Kernels tested: 7.2.9-2-cachyos, 7.2.10-1-cachyos; also seen on
Linux Mint 22.3 (6.14.0-37-generic)

Symptoms (every boot):
 - \_SB.WMID.WHCM aborts with AE_AML_OPERAND_TYPE (three times at boot)
 - hp-wmi: "Failed to apply initial fan settings: -22"
 - \_SB.WMID.WQBC / WQBE abort with AE_AML_OPERAND_VALUE (these go
   away with modprobe.blacklist=hp_bioscfg)
 - hp hwmon device exposes only pwm1_enable; no pwm1, no fan inputs
 - acpi_fan works (fan1_input)
 - ACPI thermal: Invalid critical threshold (-274000), no valid trip points

Analysis (Krishna Chomal, on the platform-driver-x86 list): in WHCM,
the case for command 0x00020008 (HPWMI_GM) only does "RTCD = RTCC" and
never calls the dispatcher GMCF. Local2 is therefore never assigned,
and the later DerefOf (Local2 [Zero]) fails on an Integer, producing
AE_AML_OPERAND_TYPE. HPWMI_READ/WRITE commands still work.
This is a firmware bug and cannot be fixed in the driver; a driver
change to hide pwm1_enable/fan inputs when the fan count query fails
has been proposed.

Related: bug 222107 (board 8D9C), bug 221385.
acpidump and dmesg attached.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

--- Comment #1 from lorenzocollevecchio17@gmail.com ---
Created attachment 311137
  --> https://bugzilla.kernel.org/attachment.cgi?id=311137&action=edit
dmesg

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

Krishna Chomal (krishna.chomal108@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |krishna.chomal108@gmail.com

--- Comment #2 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Created attachment 311148
  --> https://bugzilla.kernel.org/attachment.cgi?id=311148&action=edit
Proposed patch for disabling fan support in hwmon

Hi Lorenzo,

Could you test the proposed patch and check if the WHCM errors appear only once
during driver init and not regularly.

Also, all hwmon attributes have been disabled, this includes:
- pwm1_enable
- pwm1
- pwm2
- fan1_input
- fan2_input

Thanks

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

--- Comment #3 from Krishna Chomal (krishna.chomal108@gmail.com) ---
The proposed patch (attachment 311148) is based on platform-drivers-x86 tree,
review-ilpo-next branch.

https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/?h=review-ilpo-next

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

--- Comment #4 from lorenzocollevecchio17@gmail.com ---
(In reply to Krishna Chomal from comment #2)
> Created attachment 311148 [details]
> Proposed patch for disabling fan support in hwmon
> 
> Hi Lorenzo,
> 
> Could you test the proposed patch and check if the WHCM errors appear only
> once during driver init and not regularly.
> 
> Also, all hwmon attributes have been disabled, this includes:
> - pwm1_enable
> - pwm1
> - pwm2
> - fan1_input
> - fan2_input
> 
> Thanks

Hi Krishna,

Tested your patch on the HP OmniBook 5 16-ag1xxx (board 8DF4, BIOS F.12).

Base: stable v7.2.10 (drivers/platform/x86/hp/hp-wmi.c), built out of tree
against 7.2.10-1-cachyos. Your diff does not apply to v7.2.10: hunks 2 and 4
fail, and the helpers hp_wmi_fan_control_supported(),
hp_wmi_fan_table_supported() and hp_wmi_get_active_fan_speed() do not exist in
this tree. I ported the same logic by hand:
  - added int fan_count to struct hp_wmi_hwmon_priv
  - in hp_wmi_hwmon_is_visible(): return 0 for hwmon_pwm and hwmon_fan when
priv->fan_count <= 0
  - in hp_wmi_setup_fan_settings(): priv->fan_count =
hp_wmi_get_fan_count_userdefine_trigger() right after priv->mode =
PWM_MODE_AUTO
  - in hp_wmi_hwmon_init(): the dev_info() and early return after the
IS_ERR(hwmon) check

Result after insmod of the patched module (stock hp_wmi unloaded first):

[ 1125.137950] hp_wmi: loading out-of-tree module taints kernel.
[ 1125.759817] input: HP WMI hotkeys as /devices/virtual/input/input27
[ 1126.171893] ACPI Error: Aborting method \_SB.WMID.WHCM due to previous error
(AE_AML_OPERAND_TYPE) (20260408/psparse-545)
[ 1126.172052] hp-wmi hp-wmi: No usable fans reported by WMI, disabling fan
support
[ 1126.582653] hp_wmi: Registered as platform profile handler

  - WHCM is logged once during init (the stock driver logged three, followed by
"Failed to apply initial fan settings: -22"). The -22 message is gone.
  - /sys/devices/platform/hp-wmi/hwmon/*/ contains only: device name power
subsystem uevent. No pwm1_enable, pwm1, pwm2, fan1_input or fan2_input.
  - Not regular: dmesg | grep -c WHCM was 4 (3 from boot + 1 from loading the
module) before and after calling sensors twice, and it stayed at 4.
  - The platform profile still registers (quiet balanced performance).

acpi_fan is unaffected by the patch: fan1_input is still present and readable
(it showed 0 RPM during a stress test at 80 °C).  Tested-by: Lorenzo
Collevecchio lorenzocollevecchio17@gmail.com

Thanks,
Lorenzo

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

--- Comment #5 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Hi Lorenzo,

As said, the patch was based on pdx86 tree, not stable branch. But looks like
you applied the relevant changes correctly and it seems to fix the issue. Do
you want to do more testing or should I proceed to send this patch to the
mailing list?

Thanks,
Krishna

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

--- Comment #6 from lorenzocollevecchio17@gmail.com ---
Hi Krishna,

Thanks for confirming, and sorry for not mentioning the base tree explicitly.

Please go ahead and send the patch to the mailing list. It fixes what it set
out to fix on my 8DF4: the -22 message is gone, pwm1_enable and the fan
attributes are hidden, and WHCM is logged once at init and not on every read.

For completeness, here is what I did not test: module unload/reload of the
patched driver, and suspend/resume with it loaded. If you would like me to
check either, tell me and I will.

You are welcome to add:

Tested-by: Lorenzo Collevecchio lorenzocollevecchio17@gmail.com

Thanks again for all the help.

Best regards,
Lorenzo

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 222138] hp-wmi: HPWMI_GM queries fail with AE_AML_OPERAND_TYPE on OmniBook 5 16-ag1xxx (8DF4); firmware WHCM never calls GMCF

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=222138

--- Comment #7 from Krishna Chomal (krishna.chomal108@gmail.com) ---
Hi Lorenzo,

I have added your tags and submitted it here[1].

Thanks,
Krishna

[1]:
https://lore.kernel.org/platform-driver-x86/20261017132421.279522-1-krishna.chomal108@gmail.com

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.