[Bug 23730] New: x11-base/nouveau-drm fails on drm_fb_helper.c with 'EINVAL' undeclared

[Bug 23730] New: x11-base/nouveau-drm fails on drm_fb_helper.c with 'EINVAL' undeclared

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=23730

           Summary: x11-base/nouveau-drm fails on drm_fb_helper.c with
                    'EINVAL' undeclared
           Product: xorg
           Version: unspecified
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
        AssignedTo: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
        ReportedBy: maxim.britov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
         QAContact: xorg-team-go0+a7rfsptAfugRpC6u6w@public.gmane.org


I have today on my Gentoo:
In file included from
/var/tmp/portage/x11-base/nouveau-drm-99999999/work/master-compat/drivers/gpu/drm/drm_fb_helper.c:30:
include/linux/sysrq.h: In function '__reterr':
include/linux/sysrq.h:66: error: 'EINVAL' undeclared (first use in this
function)
include/linux/sysrq.h:66: error: (Each undeclared identifier is reported only
once
include/linux/sysrq.h:66: error: for each function it appears in.)


With this patch it compiles fine

--- /master-compat/drivers/gpu/drm/drm_fb_helper.c        2009-09-01
22:50:00.000000000 +0300
+++ master-compat/drivers/gpu/drm/drm_fb_helper.c        2009-09-05
19:46:52.000000000 +0300
@@ -27,6 +27,7 @@
  *      Dave Airlie <airlied-cv59FeDIM0c@public.gmane.org>
  *      Jesse Barnes <jesse.barnes-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
  */
+#include <linux/errno.h>
 #include <linux/sysrq.h>
 #include <linux/fb.h>
 #include "drmP.h"


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 23730] x11-base/nouveau-drm fails on drm_fb_helper.c with 'EINVAL' undeclared

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=23730





--- Comment #1 from Pekka Paalanen <pq-X3B1VOXEql0@public.gmane.org>  2009-09-06 00:20:16 PST ---
Odd, no-one else has hit this. For me it works with both out-of-tree against
2.6.28 and nouveau/linux-2.6 git kernel. Compile failures are usually found
fast.

What kernel and arch do you use?

btw. that is not Nouveau code but DRM generic, so to fix it, you'd have to
reproduce it with Linus' kernel tree or Airlied's drm-next, and send the patch
to dri-devel mailing list.

Or is this a packaging problem in the x11 overlay? (Doesn't sounds like one,
but...)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 23730] x11-base/nouveau-drm fails on drm_fb_helper.c with 'EINVAL' undeclared

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=23730





--- Comment #2 from Maxim Britov <maxim.britov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>  2009-09-06 00:42:56 PST ---
linux-2.6.30-gentoo-r6

Seems kernel issue:
http://mirror.celinuxforum.org/gitstat/commit-detail.php?commit=82e3310ace59794ecf0f531eca94647b2863dfda


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 23730] x11-base/nouveau-drm fails on drm_fb_helper.c with 'EINVAL' undeclared

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

http://bugs.freedesktop.org/show_bug.cgi?id=23730


Maxim Britov <maxim.britov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID




--- Comment #3 from Maxim Britov <maxim.britov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>  2009-09-06 00:45:24 PST ---
Fixed in kernel 2.6.31-rc2-git1

http://www.kernel.org/pub/linux/kernel/v2.6/snapshots/patch-2.6.31-rc2-git1.log
commit 82e3310ace59794ecf0f531eca94647b2863dfda
Author: Tobias Doerffel <tobias.doerffel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date:   Sun Jul 5 12:08:23 2009 -0700

    linux/sysrq.h needs linux/errno.h

    In include/linux/sysrq.h the constant EINVAL is being used but is undefined
    if include/linux/errno.h is not included before.

    Fix this by adding #include <linux/errno.h> at the beginning.

    Signed-off-by: Tobias Doerffel <tobias.doerffel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
    Signed-off-by: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
    Signed-off-by: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.