[Bug 26329] New: [radeon KMS] new PM/clocks code only detects 1 powerstate

[Bug 26329] New: [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329

           Summary: [radeon KMS] new PM/clocks code only detects 1
                    powerstate
           Product: DRI
           Version: DRI CVS
          Platform: x86-64 (AMD64)
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: DRM/Radeon
        AssignedTo: dri-devel@lists.sourceforge.net
        ReportedBy: liquid.acid@gmx.net


Created an attachment (id=32917)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32917)
dmesg excerpt showing DRM infos

Hi there,

I just fetched latest drm-radeon-testing git from airlied's tree to test out
the new powermanagement / dynamic clocks bits.

Well, to make a long story short: it doesn't work like expected - I don't see
any downclocking of the chip even though I have only a terminal open in XFCE.

Looking at the dmesg output (attached) it looks like that the kernel driver
only detects ONE single power state for my card - this should be clearly wrong
since the Windows driver knows at least three predefined states (250MHz, 500MHz
and 750MHz GPU clock).

Any idea why the other states are not detected?

Greets,
Tobias


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #1 from Rafał Miłecki <zajec5@gmail.com>  2010-01-29 15:45:10 PST ---
Can you attach your bios, please?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #2 from Tobias Jakobi <liquid.acid@gmx.net>  2010-01-29 16:13:57 PST ---
You mean the VGA BIOS? If yes, then how do I do this?

Anyway, good work bringing this into the kernel Rafał! :)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #3 from Tobias Jakobi <liquid.acid@gmx.net>  2010-01-29 16:36:27 PST ---
Created an attachment (id=32918)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32918)
VGA BIOS??

I'm not sure if that's what you want?

Extracted 64K from 0xc0000 like explained in the coreboot wiki about VGA
support. Sadly /proc/iomem doesn't list any 'Video ROM' so have to assume the
default.

At least the dump contains some strings that indicate that it's really (only
parts?) of the VGA BIOS.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #4 from Rafał Miłecki <zajec5@gmail.com>  2010-01-29 17:06:48 PST ---
Bringing PM to KMS was done with big help from many ppl, so that's not only my
share :)


(Quoting Alex)
> Can you attach a copy of your video bios?  (as root):
> cd /sys/bus/pci/devices/<pci bus id>
> echo 1 > rom
> cat rom > /tmp/vbios.rom
> echo 0 > rom


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329


Tobias Jakobi <liquid.acid@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32918|0                           |1
        is obsolete|                            |




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #5 from Tobias Jakobi <liquid.acid@gmx.net>  2010-01-30 05:17:20 PST ---
Created an attachment (id=32928)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32928)
correct VGA BIOS


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #6 from Alex Deucher <agd5f@yahoo.com>  2010-01-30 07:34:35 PST ---
The driver probably needs loosen the power mode checking a bit.  The modes are
skipped since they are interpreted as overclock modes since the power mode mclk
is 800 Mhz vs the default mclk of 799 Mhz.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #7 from Rafał Miłecki <zajec5@gmail.com>  2010-01-30 08:41:07 PST ---
Created an attachment (id=32933)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32933)
drm/radeon/kms: PM: use some margin when validating power modes


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #8 from Tobias Jakobi <liquid.acid@gmx.net>  2010-01-30 09:45:05 PST ---
I have yet to try that patch, but wouldn't it be better to base the margin on
percentage rather than on a fixed offset?

What I mean is: as long as the clock deviation is no bigger than (for example)
1% accept the clocks


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #9 from Rafał Miłecki <zajec5@gmail.com>  2010-01-30 09:51:12 PST ---
(In reply to comment #8)
> What I mean is: as long as the clock deviation is no bigger than (for example)
> 1% accept the clocks

Maybe. I (just personal) don't like mul/div operations on low-level :)

Alex: can we use hardcoded 5MHz? Or should we make it relative?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #10 from Rafał Miłecki <zajec5@gmail.com>  2010-01-30 09:54:06 PST ---
Than differences in AtomBIOS tables should always be non-relative I guess (like
that 1MHz), I *do not* except situations where:
1) GPU with 100MHz default engine has differences about 1MHz
2) GPU with 800MHz default engine has differences about 10MHz

I think it's always the same low difference if any.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329





--- Comment #11 from Tobias Jakobi <liquid.acid@gmx.net>  2010-01-31 04:47:41 PST ---
Created an attachment (id=32944)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=32944)
new dmesg output

I think we're moving in the right direction. At least the driver now detects
some different power states.
But it looks like it select a power state with only one clock mode.

I'm not really sure if I have understood this whole PM stuff correctly, but am
I right that the three power states are actually PM profiles?

If that's the case then they're obviously incorrectly labeled:
State 2 provides maximum clocks all the time, but is named Default - how can
this be right?

Anyway, as you can guess I'm not seeing any reduction in clocks with this state
selected. Hmmmm...

Greets,
Tobias


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
--

[Bug 26329] [radeon KMS] new PM/clocks code only detects 1 powerstate

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26329


Tobias Jakobi <liquid.acid@gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Tobias Jakobi <liquid.acid@gmx.net>  2010-02-11 08:25:39 PST ---
I'm resolving this bug to FIXED, since the initial issue is no longer and now
all power states are at least detected.

Thanks again to Rafał and Alex for fixing this!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
http://p.sf.net/sfu/solaris-dev2dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel