[Bug 26852] New: Build libkms against in-tree xf86drm.h

[Bug 26852] New: Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26852

           Summary: Build libkms against in-tree xf86drm.h
           Product: DRI
           Version: XOrg CVS
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: libdrm
        AssignedTo: dri-devel@lists.sourceforge.net
        ReportedBy: chalserogers@gmail.com


Created an attachment (id=33703)
 --> (http://bugs.freedesktop.org/attachment.cgi?id=33703)
Add include dir to libkms Makefile

libkms includes files which include xf86drm.h, but doesn't include the in-tree
xf86drm.h in the library include path.  This means it will build against the
installed header in /usr/include which is probably not the expected behaviour,
or if built in a clean chroot will simply fail to build.

Trivial patch attached to fix.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26852


Sérgio M. B. <sergio@sergiomb.no-ip.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sergio@sergiomb.no-ip.org




--- Comment #1 from Sérgio M. B. <sergio@sergiomb.no-ip.org>  2010-03-02 20:13:53 PST ---
The question is, if libkms depends on kernel ? and yes I thinks so .
Therefore, if libkms , depends on kernel should use xf86drm.h of /usr/include.
In this point of view, libkms should know deal with different kernels or even
warn if kernel version is not good.

"built in a clean chroot will simply fail to build" , I think that solves
install kernel-sources first .

Note: this is my opinion, may not be write. 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=26852





--- Comment #2 from Michel Dänzer <michel@daenzer.net>  2010-03-03 03:15:54 PST ---
(In reply to comment #1)
> The question is, if libkms depends on kernel ? and yes I thinks so .
> Therefore, if libkms , depends on kernel should use xf86drm.h of /usr/include.
> In this point of view, libkms should know deal with different kernels or even
> warn if kernel version is not good.

It needs to deal with that at runtime, not build time.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

--- Comment #3 from Christopher James Halse Rogers <chalserogers@gmail.com> 2010-05-25 23:35:04 PDT ---
So, until there's an actual kernel incompatibility introduced for which runtime
detection in libkms is necessary, is there any reason not to apply this patch?  

Building against the headers shipped in the source alongside it makes much more
sense to me.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

--- Comment #4 from Julien Cristau <jcristau@debian.org> 2010-06-10 14:09:20 PDT ---
the headers part was fixed in ae57dcf6e063860200b7949d5e2365e80ac4aea7, but
libdrm is still missing from libkms_la_LIBADD.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

--- Comment #5 from Sérgio M. B. <sergio@sergiomb.no-ip.org> 2010-06-15 21:12:52 PDT ---
What I'm try to say is, I think the ./configure of libdrm, should check what
kernel version we have on system and require a version of kernel bigger than a
number which libdrm, we are compiling, works. 

Is not logic, build libdrm-2.4.21 with a kernel <= 2.6.26 , I think. So libdrm
should avoid those situations.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

Julien Cristau <jcristau@debian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freetz@gmx.net

--- Comment #6 from Julien Cristau <jcristau@debian.org> 2010-10-11 13:32:58 PDT ---
*** Bug 30782 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

Cyril Brulebois <kibi@debian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kibi@debian.org

--- Comment #7 from Cyril Brulebois <kibi@debian.org> 2011-03-05 10:10:11 PST ---
Ping? As described in the initial report, there's no reason to prefer system
headers over those in the same source… I don't understand Sérgio's objection (I
fail to see what's illogical).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

--- Comment #8 from Sérgio M. B. <sergio@sergiomb.no-ip.org> 2011-03-05 17:28:01 PST ---
(In reply to comment #7)
> Ping? As described in the initial report, there's no reason to prefer system
> headers over those in the same source… I don't understand Sérgio's objection (I
> fail to see what's illogical).

The illogical is, without that depending on kernel, you may try compile very
new libdrm with a older kernel. 
libdrm-2.4.21 needs kms on kernel but kernel <= 2.6.26 don't have it.   

my 2 cents

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

Matt Turner <mattst88@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mattst88@gmail.com

--- Comment #9 from Matt Turner <mattst88@gmail.com> 2011-03-05 18:07:50 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > Ping? As described in the initial report, there's no reason to prefer system
> > headers over those in the same source… I don't understand Sérgio's objection (I
> > fail to see what's illogical).
> 
> The illogical is, without that depending on kernel, you may try compile very
> new libdrm with a older kernel. 
> libdrm-2.4.21 needs kms on kernel but kernel <= 2.6.26 don't have it.   
> 
> my 2 cents

I think you're failing to understand the issue.

xf86drm.h is provided by libdrm. libkms (which is part of libdrm) uses
xf86drm.h, but the Makefile searches in /usr/include instead of the $(top_src)
directory, where libdrm's xf86drm.h is.

This is like if you have a library that consists of lib.c and lib.h, where
lib.c includes lib.h. The Makefile would be incorrect in using lib.h found in
/usr/include over the lib.h in the same folder as lib.c.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

Christopher James Halse Rogers <chalserogers@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Christopher James Halse Rogers <chalserogers@gmail.com> 2011-03-06 20:57:41 PST ---
This was fixed in ae57dcf6 anyway :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 26852] Build libkms against in-tree xf86drm.h

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=26852

--- Comment #11 from Julien Cristau <jcristau@debian.org> 2011-03-07 10:30:26 PST ---
> --- Comment #10 from Christopher James Halse Rogers <chalserogers@gmail.com> 2011-03-06 20:57:41 PST ---
> This was fixed in ae57dcf6 anyway :)
> 
only partly, see comment#4.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.