[Bug 27055] New: r600: software fallback for readpixels

[Bug 27055] New: r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055

           Summary: r600: software fallback for readpixels
           Product: Mesa
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/R600
        AssignedTo: dri-devel@lists.sourceforge.net
        ReportedBy: edwintorok@gmail.com


RADEON_DEBUG=fall has shown me this while running wine 1.1.40, glsl disabled,
orm=backbuffer:

Falling back to sw for ReadPixels (format GL_BGRA, type
GL_UNSIGNED_INT_8_8_8_8_REV)

Using latest mesa git.

glxinfo|grep OpenGL
OpenGL vendor string: Advanced Micro Devices, Inc.
OpenGL renderer string: Mesa DRI R600 (RV730 9498) 20090101  TCL DRI2
OpenGL version string: 2.0 Mesa 7.9-devel
OpenGL shading language version string: 1.10


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27055] r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055


Török Edwin <edwintorok@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |enhancement




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27055] r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055





--- Comment #1 from Török Edwin <edwintorok@gmail.com>  2010-03-13 04:15:55 PST ---
This patch appears to solve this case, and piglit doesn't complain. The switch
should probably contain more formats though.

diff --git a/src/mesa/drivers/dri/radeon/radeon_pixel_read.c
b/src/mesa/drivers/dri/radeon/radeon_pixel_read.c
index b180c1d..943c034 100644
--- a/src/mesa/drivers/dri/radeon/radeon_pixel_read.c
+++ b/src/mesa/drivers/dri/radeon/radeon_pixel_read.c
@@ -68,6 +68,12 @@ static gl_format gl_format_and_type_to_mesa_format(GLenum
format, GLenum type)
                     return MESA_FORMAT_ARGB8888_REV;
             }
             break;
+       case GL_BGRA:
+           switch (type) {
+                case GL_UNSIGNED_INT_8_8_8_8_REV:
+                    return MESA_FORMAT_ARGB8888;
+           }
+           break;
     }

     return MESA_FORMAT_NONE;


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27055] r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055





--- Comment #2 from Maciej Cencora <m.cencora@gmail.com>  2010-03-13 05:11:45 PST ---
What app are you hitting this fallback with?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27055] r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055





--- Comment #3 from Török Edwin <edwintorok@gmail.com>  2010-03-13 06:03:14 PST ---
(In reply to comment #2)
> What app are you hitting this fallback with?
> 

World of Warcraft running under wine 1.1.40, glsl disabled, orm=backbuffer.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27055] r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055





--- Comment #4 from Maciej Cencora <m.cencora@gmail.com>  2010-03-13 08:39:19 PST ---
I've pushed extended version of your patch that handles also other formats.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27055] r600: software fallback for readpixels

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27055


Török Edwin <edwintorok@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Török Edwin <edwintorok@gmail.com>  2010-03-13 08:51:50 PST ---
(In reply to comment #4)
> I've pushed extended version of your patch that handles also other formats.
> 

Thanks, it works!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel