[Bug 27339] New: Problem with stale cliprects from the classic r300 in r300g

[Bug 27339] New: Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339

           Summary: Problem with stale cliprects from the classic r300 in
                    r300g
           Product: Mesa
           Version: git
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/r300
        AssignedTo: dri-devel@lists.sourceforge.net
        ReportedBy: Mathias.Froehlich@web.de


Hi,

When using the classic r300 driver together with r300g in the same session, the
cliprect registers used to clip the viewport in classic r300 seem to bleed into
the r300g environment.
The problem I observe is that when I start an application with the classic r300
driver and stop that  application. Then switch to the r300g driver by setting
the LIBGL_DRIVERS_PATH environment variable, the r300g context is always
clipped to the viewport of the previous classic r300 viewport.
This happens on my mesa test account which uses non composited X11 on rawhide.

The attached patch fixes this by initializing these clip rects on context
startup.
I am not sure which registers should be initialized by which different
component, which means I am not sure if this is the right place to fix this.
But I provide that here as a hopefully good hint what goes wrong.

Please fix

Mathias


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339





--- Comment #1 from Marek Olšák <maraeo@gmail.com>  2010-03-27 06:57:58 PST ---
I think the classic driver shouldn't set those regs on KMS. Some time ago I
removed the emission of the regs in classic and it didn't really add any
regressions.

Please try this:
Change src/gallium/drivers/r300/r300_state_invariant.c:134 to:

    OUT_CS_REG(R300_SC_CLIP_RULE, 0);

and please let me know if it helps.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339





--- Comment #2 from Mathias Fröhlich <Mathias.Froehlich@web.de>  2010-03-27 08:07:58 PST ---
(In reply to comment #1)
> I think the classic driver shouldn't set those regs on KMS. Some time ago I
> removed the emission of the regs in classic and it didn't really add any
> regressions.

Hmm, looking again deeper into the code I just observed that r300 used
R300_CLIPRECT* to do scissor clipping to viewport boundaries whereas r300g uses
R300_SCISSOR*.

> Please try this:
> Change src/gallium/drivers/r300/r300_state_invariant.c:134 to:
> 
>     OUT_CS_REG(R300_SC_CLIP_RULE, 0);
> 
> and please let me know if it helps.
> 
I have reverted to master and applied that change but:
That does not help.
With that change the whole window is not painted at all - you just see stale
buffer content.
I believe that this value is some kind of bitmask to tell the card which side
of the R300_CLIPRECT* coordinate to clip away.
It appeared to me that you can not easily switch those off, rather than just
'clip the other side'. ... not looked into the documentation.

Don't know if r300 should or should not use these registers, but it seems to me
that r300 just still uses them as well as the kms kernel lets r300 classic set
those registers.

So altogether It would be good to have something that helps testing r300g as an
alternative to r300 classic in an easy way.

Greetings

Mathias


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339





--- Comment #3 from Marek Olšák <maraeo@gmail.com>  2010-03-27 09:09:45 PST ---
Could you please give me the exact steps how to reproduce this bug?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339





--- Comment #4 from Nicolai Hähnle <nhaehnle@gmail.com>  2010-03-27 14:19:18 PST ---
Clipping works like this:

You have four cliprects. Each pixel is compared to all of them. The pass/fail
result gives you a bitmask which is interpreted as a number N between 0 and 15
(inclusive). Then you look at the N-th bit of the clip rule register. If it is
1, continue, if it is 0, discard the pixel.

Therefore, you need to set the clip rule register to 0xFFFF to disable this
clipping functionality.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339


Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Marek Olšák <maraeo@gmail.com>  2010-03-27 14:49:00 PST ---
Thanks Nicolai! I knew it would be either all zeros or all ones.. ;) I've
pushed the fix to master.

I am closing the bug. Please reopen if it still regresses.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339





--- Comment #6 from Mathias Fröhlich <Mathias.Froehlich@web.de>  2010-03-28 00:34:50 PST ---
Works with your checkin.
Thanks!

Mathias


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27339] Problem with stale cliprects from the classic r300 in r300g

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27339


Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED




-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel