[Bug 28745] New: RS780: dynpm makes my cat levitate (div by 0)

[Bug 28745] New: RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

           Summary: RS780: dynpm makes my cat levitate (div by 0)
           Product: DRI
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: DRM/Radeon
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: zajec5@gmail.com


drm-radeon-testing, RS780

[  379.169870] [drm:radeon_set_power_state], Setting: e: 0
[  379.169938] divide error: 0000 [#1] PREEMPT SMP
(...)
[  379.170077] Call Trace:
[  379.170105]  [<f96e20e6>] ? rs690_bandwidth_update+0x96/0xb60 [radeon]

Will provide more info.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #1 from Rafał Miłecki <zajec5@gmail.com> 2010-06-24 10:31:53 PDT ---
Created an attachment (id=36467)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36467)
dmesg with div by 0 call trace

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #2 from Rafał Miłecki <zajec5@gmail.com> 2010-06-25 10:48:21 PDT ---
Created an attachment (id=36489)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36489)
dmesg with some own debugging messages

Alex could you take a look at this?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #3 from Rafał Miłecki <zajec5@gmail.com> 2010-06-25 11:05:40 PDT ---
Created an attachment (id=36495)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36495)
vbios

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #4 from Rafał Miłecki <zajec5@gmail.com> 2010-06-25 11:07:38 PDT ---
Created an attachment (id=36496)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36496)
dmesg: power states picked by driver

Please note downclocked mode is marked as performance one :|

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #5 from Alex Deucher <agd5f@yahoo.com> 2010-06-25 12:08:13 PDT ---
Created an attachment (id=36497)
 View: https://bugs.freedesktop.org/attachment.cgi?id=36497
 Review: https://bugs.freedesktop.org/review?bug=28745&attachment=36497

fix div by 0

This should fix the issue.  IGP chips have the same clocks for the low
performance and battery states, so it doesn't matter which we choose.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #6 from Rafał Miłecki <zajec5@gmail.com> 2010-06-25 13:09:52 PDT ---
Created an attachment (id=36498)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36498)
dmesg with patch

It works fine, hope that's what you expected :)

Can you submit to Dave?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #7 from Rafał Miłecki <zajec5@gmail.com> 2010-06-25 13:13:53 PDT ---
Could you by the way explain that magic cycling through the power states? 

I thought of doing same patch for r100.c, but there exists another condition:

if (rdev->pm.current_power_state_index == 0)

is that alright? I guess patch for r100.c is nod needed then?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #8 from Alex Deucher <agd5f@yahoo.com> 2010-06-25 13:20:32 PDT ---
(In reply to comment #6)
> Created an attachment (id=36498)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=36498)
> dmesg with patch
> 
> It works fine, hope that's what you expected :)
> 
> Can you submit to Dave?

Will do.

(In reply to comment #7)
> Could you by the way explain that magic cycling through the power states? 
> 
> I thought of doing same patch for r100.c, but there exists another condition:
> 
> if (rdev->pm.current_power_state_index == 0)
> 
> is that alright? I guess patch for r100.c is nod needed then?

Yes, r100 doesn't need a similar patch as the power states are ordered
differently.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

Alex Deucher <agd5f@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Alex Deucher <agd5f@yahoo.com> 2010-06-25 13:22:22 PDT ---
Patch sent.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #10 from Rafał Miłecki <zajec5@gmail.com> 2010-06-25 13:39:52 PDT ---
(In reply to comment #7)
> Could you by the way explain that magic cycling through the power states? 

Ping? :)

Why do we cycle through the (all?) power states?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 28745] RS780: dynpm makes my cat levitate (div by 0)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=28745

--- Comment #11 from Alex Deucher <agd5f@yahoo.com> 2010-06-25 14:11:50 PDT ---
(In reply to comment #10)
> 
> Why do we cycle through the (all?) power states?

It's a simple algo :)
I suppose the alternative would be to just switch between a low and high one. 
It's easier for the plls to lock after a small change, so there's less of a
delay when making small changes to the clocks, but that's about it.  If we had
more advanced pm algos there might be advantages to staying in intermediate
states for certain reasons (e.g., to maintain enough bandwidth or performance
for certain tasks, etc.).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.