* [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines
@ 2011-02-20 2:29 bugzilla-daemon
2011-02-20 3:02 ` [Bug 29502] " bugzilla-daemon
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: bugzilla-daemon @ 2011-02-20 2:29 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=29502
Summary: Change to legacy algo to preferring lower post
dividers breaks certain modelines
Product: Drivers
Version: 2.5
Kernel Version: 2.6.38-rc5
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: Video(DRI - non Intel)
AssignedTo: drivers_video-dri@kernel-bugs.osdl.org
ReportedBy: bitbytebit@gmail.com
Regression: Yes
There's an issue with some legacy chips plus low dotclocks in the 2.6.38-rc5
kernel, This is the change/patch that broke them. Reverting this patch, they
work as they did before...
"Also, switch the legacy algo back to preferring lower post dividers."
@@ -849,7 +951,7 @@ void radeon_compute_pll(struct radeon_pll *pll,
max_fractional_feed_div = pll->max_frac_feedback_div;
}
- for (post_div = max_post_div; post_div >= min_post_div; --post_div) {
+ for (post_div = min_post_div; post_div <= max_post_div; ++post_div) {
uint32_t ref_div;
if ((pll->flags & RADEON_PLL_NO_ODD_POST_DIV) && (post_div & 1))
A person has a ATI Radeon 9200SE 5964 (AGP)and with 2.6.38-rc4-git4+ it works
while with 2.6.38-rc5 there are certain (not all) modelines with low dotclocks
that end up being totally out of sync.
Here's an example of a non-working modeline for him with the newer kernel, vs.
the older one step back before the patch with the above change...
# toki 256x224@59.61 15.6774Khz
ModeLine "256x224x59.61" 5.518455 256 272 304 352 224 235 238 263
-HSync -VSync
There's a lot of other ones thought that can work with the same lower
dotclocks, so I'm not sure why that is, he tested that change with the legacy
pll computation reversed back to how it was and now works again with modelines
like the above.
Thanks,
Chris
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 29502] Change to legacy algo to preferring lower post dividers breaks certain modelines
2011-02-20 2:29 [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines bugzilla-daemon
@ 2011-02-20 3:02 ` bugzilla-daemon
2011-02-21 5:13 ` bugzilla-daemon
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2011-02-20 3:02 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=29502
--- Comment #1 from Chris Kennedy <bitbytebit@gmail.com> 2011-02-20 03:02:06 ---
On the above entry, I meant that it works in 2.6.38-rc3 or before the patch
that included the change above with the legacy algo lower post divider change.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 29502] Change to legacy algo to preferring lower post dividers breaks certain modelines
2011-02-20 2:29 [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines bugzilla-daemon
2011-02-20 3:02 ` [Bug 29502] " bugzilla-daemon
@ 2011-02-21 5:13 ` bugzilla-daemon
2011-02-21 6:11 ` bugzilla-daemon
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2011-02-21 5:13 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=29502
--- Comment #2 from Alex Deucher <alexdeucher@gmail.com> 2011-02-21 05:13:34 ---
Created an attachment (id=48532)
--> (https://bugzilla.kernel.org/attachment.cgi?id=48532)
revert
revert that patch. It's not needed any more as the bugs it originally fixed
were fixed via an alternate method.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 29502] Change to legacy algo to preferring lower post dividers breaks certain modelines
2011-02-20 2:29 [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines bugzilla-daemon
2011-02-20 3:02 ` [Bug 29502] " bugzilla-daemon
2011-02-21 5:13 ` bugzilla-daemon
@ 2011-02-21 6:11 ` bugzilla-daemon
2011-02-24 9:24 ` bugzilla-daemon
2011-03-04 23:41 ` bugzilla-daemon
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2011-02-21 6:11 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=29502
Chris Kennedy <bitbytebit@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |CODE_FIX
--- Comment #3 from Chris Kennedy <bitbytebit@gmail.com> 2011-02-21 06:11:50 ---
Great, reverting works.
Thanks,
Chris
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 29502] Change to legacy algo to preferring lower post dividers breaks certain modelines
2011-02-20 2:29 [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines bugzilla-daemon
` (2 preceding siblings ...)
2011-02-21 6:11 ` bugzilla-daemon
@ 2011-02-24 9:24 ` bugzilla-daemon
2011-03-04 23:41 ` bugzilla-daemon
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2011-02-24 9:24 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=29502
Rafael J. Wysocki <rjw@sisk.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |florian@mickler.org,
| |maciej.rutecki@gmail.com,
| |rjw@sisk.pl
Blocks| |27352
Resolution|CODE_FIX |PATCH_ALREADY_AVAILABLE
--- Comment #4 from Rafael J. Wysocki <rjw@sisk.pl> 2011-02-24 09:24:03 ---
Patch : https://bugzilla.kernel.org/attachment.cgi?id=48532
Handled-By : Alex Deucher <alexdeucher@gmail.com>
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug 29502] Change to legacy algo to preferring lower post dividers breaks certain modelines
2011-02-20 2:29 [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines bugzilla-daemon
` (3 preceding siblings ...)
2011-02-24 9:24 ` bugzilla-daemon
@ 2011-03-04 23:41 ` bugzilla-daemon
4 siblings, 0 replies; 6+ messages in thread
From: bugzilla-daemon @ 2011-03-04 23:41 UTC (permalink / raw)
To: dri-devel
https://bugzilla.kernel.org/show_bug.cgi?id=29502
Florian Mickler <florian@mickler.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
Resolution|PATCH_ALREADY_AVAILABLE |CODE_FIX
--- Comment #5 from Florian Mickler <florian@mickler.org> 2011-03-04 23:41:08 ---
merged in .38-rc7:
commit bd6a60afeb4c9ada3ff27f1d13db1a2b5c11d8c0
Author: Alex Deucher <alexdeucher@gmail.com>
Date: Mon Feb 21 01:11:59 2011 -0500
Revert "drm/radeon/kms: switch back to min->max pll post divider iteration"
This reverts commit a6f9761743bf35b052180f4a8bdae4d2cc0465f6.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
What You Don't Know About Data Connectivity CAN Hurt You
This paper provides an overview of data connectivity, details
its effect on application quality, and explores various alternative
solutions. http://p.sf.net/sfu/progress-d2d
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-04 23:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-20 2:29 [Bug 29502] New: Change to legacy algo to preferring lower post dividers breaks certain modelines bugzilla-daemon
2011-02-20 3:02 ` [Bug 29502] " bugzilla-daemon
2011-02-21 5:13 ` bugzilla-daemon
2011-02-21 6:11 ` bugzilla-daemon
2011-02-24 9:24 ` bugzilla-daemon
2011-03-04 23:41 ` bugzilla-daemon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.