[Bug 30286] New: Rendering Artefacts for "EffectFrames" with KWin trunk

[Bug 30286] New: Rendering Artefacts for "EffectFrames" with KWin trunk

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=30286

           Summary: Rendering Artefacts for "EffectFrames" with KWin trunk
           Product: Mesa
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/nouveau
        AssignedTo: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
        ReportedBy: kde-DczxDNHMV8knNWVl+fqZflaTQe2KTcn/@public.gmane.org


Created an attachment (id=38827)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=38827)
PresentWindows effect showing artefacts.

I noticed that KWin's EffectFrames are rendered incorrectly with nouveau and
current kwin trunk (please see attached screenshot). There has been a change
between 4.5 and current trunk, so I cannot say if the same problem exsists with
4.5. as well.

The EffectFrame is a GLTexture generated with TextureFromPixmap from a Qt
QPixmap. In the screenshot we see that the icons are rendered correctly (also
using QPixmap -> TFP -> GLTexture conversion) while the other textures are
rendered incorrectly. This includes the pure black background texture, the
textures generated from Plasma's FrameSvg and text textures.

The relevant code is in kwin trunk scene_opengl.cpp [1]
SceneOpenGL::EffectFrame::render() at line 2002. An example for creating a
texture can be found in SceneOpenGL::EffectFrame::updateTextTexture() at line
2264. If you want to have any other information to the code, do not hesistate
to ask, as I recently refactored that code.

I am using nouveau, dri and kernel from debian experimental. glxinfo says it's
Mesa 7.8.2

[1]
http://websvn.kde.org/trunk/KDE/kdebase/workspace/kwin/scene_opengl.cpp?view=markup

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30286] Rendering Artefacts for "EffectFrames" with KWin trunk

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

https://bugs.freedesktop.org/show_bug.cgi?id=30286

--- Comment #1 from Martin Gräßlin <kde@martin-graesslin.com> 2010-10-10 04:29:24 PDT ---
I added a workaround to KWin by keeping the QPixmap around as long as a texture
is bound from that pixmap.

SVN commit 1184458 by graesslin:

Make EffectFrames work with Nouveau driver.

This worksaround a problem with the nouveau driver causing
the text frames to be incorrectly rendered. We need to keep
the QPixmap around as long as we have a texture created from
that texture.
This applies for the text and the unstyled effect frame. For
the frames generated from Plasma's FrameSvgs it is not required.
Addresses freedesktop.org bug 30286

 M  +20 -9     scene_opengl.cpp  
 M  +2 -0      scene_openg

http://websvn.kde.org/?view=revision&revision=1184458

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 30286] Rendering Artefacts for "EffectFrames" with KWin trunk

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 339 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=30286

--- Comment #2 from chemtech <patsev.anton-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Martin Gräßlin,
Do you still experience this issue with newer drivers ?
Please check the status of your issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1131 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 30286] Rendering Artefacts for "EffectFrames" with KWin trunk

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 893 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=30286

Martin Gräßlin <mgraesslin-RoXCvvDuEio@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #3 from Martin Gräßlin <mgraesslin-RoXCvvDuEio@public.gmane.org> ---
(In reply to comment #2)
> Martin Gräßlin,
> Do you still experience this issue with newer drivers ?
> Please check the status of your issue.
I can no longer test as I don't have an NVIDIA system any more. With radeon and
Intel I do not face this issue, though it's difficult to say as also KWin has
changed a lot over the last 2.5 years.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2495 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau