[Bug 30374] New: ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[Bug 30374] New: ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

           Summary: ums 3D lock since drm: kill kernel_context_switch
                    callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f
           Product: Mesa
           Version: git
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/R600
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: lists@andyfurniss.entadsl.com


git d-r-t, mesa, ddx and xserver. rv790 PCIE card.

UMS radeon/r600c with current d-r-t soft locks when a mesa demo is run.

Log shows many

[drm:drm_lock_take] *ERROR* 1 holds heavyweight lock

bisect came up with

1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f is first bad commit
commit 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Mon Aug 23 22:53:24 2010 +0200

    drm: kill kernel_context_switch callbacks

    Not used by any in-kernel driver. So drop it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30374] ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

--- Comment #1 from Daniel Vetter <daniel@ffwll.ch> 2010-09-25 11:33:52 PDT ---
Created an attachment (id=38952)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=38952)
readd drm_lock_free

Does this patch help?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30374] ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

Alex Deucher <agd5f@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38952|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #38952|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30374] ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

--- Comment #2 from Andy Furniss <lists@andyfurniss.entadsl.com> 2010-09-25 14:15:38 PDT ---
(In reply to comment #1)
> Created an attachment (id=38952)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38952
 Review: https://bugs.freedesktop.org/review?bug=30374&attachment=38952

> readd drm_lock_free
> 
> Does this patch help?

  CC [M]  drivers/gpu/drm/drm_lock.o
drivers/gpu/drm/drm_lock.c: In function 'drm_unlock':
drivers/gpu/drm/drm_lock.c:164: error: 'master' undeclared (first use in this
function)
drivers/gpu/drm/drm_lock.c:164: error: (Each undeclared identifier is reported
only once
drivers/gpu/drm/drm_lock.c:164: error: for each function it appears in.)
make[3]: *** [drivers/gpu/drm/drm_lock.o] Error 1
make[2]: *** [drivers/gpu/drm] Error 2
make[1]: *** [drivers/gpu] Error 2
make: *** [drivers] Error 2

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30374] ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

Daniel Vetter <daniel@ffwll.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #38952|0                           |1
        is obsolete|                            |

--- Comment #3 from Daniel Vetter <daniel@ffwll.ch> 2010-09-25 14:28:56 PDT ---
Created an attachment (id=38955)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38955
 Review: https://bugs.freedesktop.org/review?bug=30374&attachment=38955

readd drm_lock_free

Sorry for wasting your time. This time actually compile-tested.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30374] ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

--- Comment #4 from Andy Furniss <lists@andyfurniss.entadsl.com> 2010-09-25 15:06:58 PDT ---
(In reply to comment #3)
> Created an attachment (id=38955)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38955
 Review: https://bugs.freedesktop.org/review?bug=30374&attachment=38955

> readd drm_lock_free
> 
> Sorry for wasting your time. This time actually compile-tested.

np and yes, the patch fixes it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 30374] ums 3D lock since drm: kill kernel_context_switch callbacks 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=30374

Daniel Vetter <daniel@ffwll.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Daniel Vetter <daniel@ffwll.ch> 2010-09-26 01:52:45 PDT ---
Patch merged into drm-core-next.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.