[Bug 32325] New: [radeon] DRM version check only looks at minor number.

[Bug 32325] New: [radeon] DRM version check only looks at minor number.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32325

           Summary: [radeon] DRM version check only looks at minor number.
           Product: Mesa
           Version: git
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/Radeon
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: rankincj@googlemail.com


Created an attachment (id=41020)
 View: https://bugs.freedesktop.org/attachment.cgi?id=41020
 Review: https://bugs.freedesktop.org/review?bug=32325&attachment=41020

[PATCH] Enable HyperZ and microtiling for R100 if DRM >= v2.x

I have noticed that Mesa 7.9 prints the following message with a recent 2.6.3x
kernel:

"DRM version 1.6 too old to support HyperZ, disabling."

The reason for this is that the DRM in the 2.6.36 kernel is v2.6:

[drm] Initialized radeon 2.6.0 20080528 for 0000:01:00.0 on minor 0

and Mesa only checks the minor version number. (Assuming that the major version
number is always 1.)

I have attached a patch that will also enable both HyperZ and texture
microtiling(?) on R100 if DRM >= v2.x.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32325] [radeon] DRM version check only looks at minor number.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32325

--- Comment #1 from Chris Rankin <rankincj@googlemail.com> 2010-12-11 14:58:51 PST ---
There is a similar absence of DRM major version number checking in the
radeonCreateScreen() function in radeon_screen.c. (This probably affect r600c
as well, seeing as how the file is shared.)

And radeonInitContext() in radeon_common_context.c only loads the DRM minor
version into the DRI fields:

        /* DRI fields */
        radeon->dri.context = driContextPriv;
        radeon->dri.screen = sPriv;
        radeon->dri.hwContext = driContextPriv->hHWContext;
        radeon->dri.hwLock = &sPriv->pSAREA->lock;
        radeon->dri.hwLockCount = 0;
        radeon->dri.fd = sPriv->fd;
        radeon->dri.drmMinor = sPriv->drm_version.minor;

Is this enough now?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32325] [radeon] DRM version check only looks at minor number.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=32325

Chris Rankin <rankincj@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #41020|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Rankin <rankincj@googlemail.com> 2010-12-12 06:07:52 PST ---
Created an attachment (id=41038)
 View: https://bugs.freedesktop.org/attachment.cgi?id=41038
 Review: https://bugs.freedesktop.org/review?bug=32325&attachment=41038

[PATCH] Don't even consider enabling HyperZ or microtiling unless DRM major
version is 1.

If DRM v2.x can't support this yet then the current DRM version check in Mesa
is no longer adequate.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 32325] [radeon] DRM version check only looks at minor number.

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 840 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=32325

GitLab Migration User <gitlab-migration@fdo.invalid> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |MOVED
             Status|NEW                         |RESOLVED

--- Comment #3 from GitLab Migration User <gitlab-migration@fdo.invalid> ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/277.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2453 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel