[Bug 33851] New: [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[Bug 33851] New: [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

           Summary: [KMS Evergreen bisected] Crash on modeset on HP
                    dv6-3050eo laptop
           Product: DRI
           Version: unspecified
          Platform: x86-64 (AMD64)
        OS/Version: Linux (All)
            Status: NEW
          Severity: critical
          Priority: medium
         Component: DRM/Radeon
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: ahlaht@gmail.com


Created an attachment (id=42866)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42866
 Review: https://bugs.freedesktop.org/review?bug=33851&attachment=42866

Hack that allows me to boot on recent kernels.

My HP Pavilion dv6-3050eo laptop does not boot anymore with 2.6.38-rc1 or
2.6.38-rc3 kernels. It freezes when doing modeset. It only boots without KMS. I
bisected the problem to this commit:

commit 9ace9f7b168fef492f731ba60da5c76bc0776e6d
Author: Alex Deucher <alexdeucher@gmail.com>
Date:   Thu Jan 6 21:19:26 2011 -0500

drm/radeon/kms: adjust default clock/vddc tracking for pm on DCE5


Partially reverting this patch allows me to boot with KMS on 2.6.38-rc3. I'm
attaching a patch that fixes the problem for me and it also adds some printks.

Here are the results of those printks:

radeon_pm_init clock.default_sclk 10000
radeon_pm_init clock.default_mclk 15700
radeon_set_power_state sclk 10000
radeon_set_power_state clock.default_sclk 10000
radeon_set_power_state pm.default_sclk 900
radeon_set_power_state mclk 15700
radeon_set_power_state clock.default_mclk 15700
radeon_set_power_state pm.default_mclk 15701

I suppose that number 900 (9 MHz?) is causing the lockup, but I couldn't figure
out where it comes from. (And apparently radeon_pm_resume is never called so
that part of the patch may be just noise.)

This laptop is equipped with Intel+Evergreen switchable graphics and there is
no BIOS option to turn off GPU switching. The attached patch allows me to boot
with 2.6.38-rc3 KMS enabled but if I start Xorg and Radeon GPU is active the
system seems to freeze again. (But this might be a different problem.) If Intel
GPU is active Xorg starts just fine.

With kernel 2.6.37 (-rc8?) modesettings works AND Xorg works with both Intel
and Radeon GPUs.

I suppose I also need to add that Linux Radeon 3D has never worked properly on
this laptop. 3D works only on Win 7. R600c can sometimes run glxgears if I'm
careful. R600g usually hard locks the computer right away. But again, this
might be a different problem and I haven't been able to test this recently.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #1 from Antti Lahtinen <ahlaht@gmail.com> 2011-02-02 13:48:46 PST ---
Created an attachment (id=42867)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42867)
dmesg on latest kernel with my patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #2 from Antti Lahtinen <ahlaht@gmail.com> 2011-02-02 13:50:10 PST ---
Created an attachment (id=42868)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42868)
lspci -vvv

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #3 from Alex Deucher <agd5f@yahoo.com> 2011-02-02 14:44:08 PST ---
Please attach a copy of your vbios:

(as root)
(use lspci to get the bus id)
cd /sys/bus/pci/devices/<pci bus id>
echo 1 > rom
cat rom > /tmp/vbios.rom
echo 0 > rom

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #4 from Antti Lahtinen <ahlaht@gmail.com> 2011-02-02 15:07:08 PST ---
Created an attachment (id=42875)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42875)
vbios

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #5 from Alex Deucher <agd5f@yahoo.com> 2011-02-02 15:23:23 PST ---
I see the problem, you have more power modes than space allocated to hold them.
 This patch should fix the issue:

diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
index 49a6890..59750dc 100644
--- a/drivers/gpu/drm/radeon/radeon.h
+++ b/drivers/gpu/drm/radeon/radeon.h
@@ -815,7 +815,7 @@ struct radeon_pm {
        fixed20_12              mclk;
        fixed20_12              needed_bandwidth;
        /* XXX: use a define for num power modes */
-       struct radeon_power_state power_state[8];
+       struct radeon_power_state power_state[16];
        /* number of valid power states */
        int                     num_power_states;
        int                     current_power_state_index;


I'll write up a better one to dynamically allocate space depending on the
number of tables.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #6 from Alex Deucher <agd5f@yahoo.com> 2011-02-02 15:25:55 PST ---
(In reply to comment #4)
> Created an attachment (id=42875)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42875)
> vbios

This looks like the intel vbios unfortunately.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #7 from Alex Deucher <agd5f@yahoo.com> 2011-02-02 15:40:30 PST ---
Created an attachment (id=42878)
 View: https://bugs.freedesktop.org/attachment.cgi?id=42878
 Review: https://bugs.freedesktop.org/review?bug=33851&attachment=42878

dynamically allocate power state space

This patch should fix the issue.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #8 from Antti Lahtinen <ahlaht@gmail.com> 2011-02-02 15:46:59 PST ---
Created an attachment (id=42879)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42879)
Here is another vbios if still needed

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

--- Comment #9 from Antti Lahtinen <ahlaht@gmail.com> 2011-02-02 16:07:51 PST ---
Thank you! You were right. I tested both patches and they both seem to work.
Even Xorg and OpenGL seem to work now. --> FIXED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 33851] [KMS Evergreen bisected] Crash on modeset on HP dv6-3050eo laptop

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=33851

Alex Deucher <agd5f@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #10 from Alex Deucher <agd5f@yahoo.com> 2011-02-02 16:11:36 PST ---
I've sent the patch to Dave for 2.6.38 and stable.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.