[Bug 35312] New: r600g: Automatic mipmap generation doesn't work properly

[Bug 35312] New: r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

           Summary: r600g: Automatic mipmap generation doesn't work
                    properly
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r600
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: wielkiegie@gmail.com


Automatic mipmap generation using glGenerateMipmap (util_gen_mipmap) fills
mipmaps with wrong rendering. Piglit tests fbo-generatemipmap* are failing.
Software fallback works properly, as does llvmpipe.

Hardware:
rv670 (HD3870), amd64
Software:
kernel 2.6.38rc8, mesa from git, libdrm from git

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

--- Comment #1 from Francis Whittle <FJ.Whittle@gmail.com> 2011-04-13 22:36:09 PDT ---
Created an attachment (id=45598)
 View: https://bugs.freedesktop.org/attachment.cgi?id=45598
 Review: https://bugs.freedesktop.org/review?bug=35312&attachment=45598

short patch to test problem

Can you try this patch to mesa and say if it fixes the issue?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

--- Comment #2 from Gustaw Smolarczyk <wielkiegie@gmail.com> 2011-04-15 00:40:53 PDT ---
Indeed it helps. Piglit test fbo-generatemipmap-formats is still failing, but
may be unrelated problem. Basic functionality now works properly.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

--- Comment #3 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-04-15 04:30:30 PDT ---
(In reply to comment #1)
> Created an attachment (id=45598)
 View: https://bugs.freedesktop.org/attachment.cgi?id=45598
 Review: https://bugs.freedesktop.org/review?bug=35312&attachment=45598

> short patch to test problem
> 
> Can you try this patch to mesa and say if it fixes the issue?

It also fixes a rv670 lodbias regression -

https://bugs.freedesktop.org/show_bug.cgi?id=35367

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

--- Comment #4 from Francis Whittle <FJ.Whittle@gmail.com> 2011-04-16 00:08:05 PDT ---
Patch is strictly a work-around and a bloody hack (dripping even).  Indicates
there's something should be happening in the driver code that isn't.  "Fixes"
was a bad word choice.

Anyway, I can confirm this bug on RS880 (Radeon HD 4200).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

Alex Deucher <agd5f@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Alex Deucher <agd5f@yahoo.com> 2011-05-05 22:57:40 PDT ---
This should be fixed by the following patches:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d116fe51c1aee3453290ac30ffe993bc131c53f7
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5066f7cd0e010db46b42f8f08a33c10cb34f8726
http://cgit.freedesktop.org/mesa/mesa/commit/?id=bf7a3ddca6fcc73eebdd9afdc45a485b38477bd9

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

--- Comment #6 from Francis Whittle <FJ.Whittle@gmail.com> 2011-05-11 02:00:42 PDT ---
Still doesn't work on RS880 until it's added to the conditional on line 813 of
r600_hw_context.c

I wonder if this should apply to rv620, rv635 (and rs780?) also?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 35312] r600g: Automatic mipmap generation doesn't work properly

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=35312

--- Comment #7 from Alex Deucher <agd5f@yahoo.com> 2011-05-11 09:15:29 PDT ---
fixed in b9f2750900efb2667bc1dfc428b71d8a08b212be.

rv610/630/620/635 all work fine without the additional hack.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.