[Bug 43096] New: r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[Bug 43096] New: r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

             Bug #: 43096
           Summary: r300g: r300_emit_draw_elements() refusing to render
                    when max_index = 0xffffffff
    Classification: Unclassified
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r300
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: tstellar@gmail.com


Created attachment 53692
  --> https://bugs.freedesktop.org/attachment.cgi?id=53692
Callstack from error message

I'm not exactly sure if this is a bug in r300g or st/mesa, but none of the
leader portraits are rendered in Civ4 and this error message is being printed:

r300: Got a huge number of vertices: 310, refusing to render (max_index: -1).

The reason this error message is being printed is because max_index is
0xffffffff, so this if statement at r300_render.c:448 evaluates to true:

if (count >= (1 << 24) || max_index >= (1 << 24)) {
        fprintf(stderr, "r300: Got a huge number of vertices: %i, "
                "refusing to render (max_index: %i).\n", count, max_index);
        return;
}

I'm not sure if the state tracker is wrong for passing 0xffffffff as the
max_index or if the driver needs to handle a max_index of 0xffffffff as a
special case, because it is the default value for pipe_draw_info->max_index.  I
have captured the call stack when this error message is printed and attached it
to this bug report.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53692|application/octet-stream    |text/plain
          mime type|                            |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

--- Comment #1 from Marek Olšák <maraeo@gmail.com> 2011-11-19 20:22:03 PST ---
Could you try this branch?

git://people.freedesktop.org/~mareko/mesa vbufmgr-fixes

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

--- Comment #2 from Tom Stellard <tstellar@gmail.com> 2011-11-19 20:48:46 PST ---
(In reply to comment #1)
> Could you try this branch?
> 
> git://people.freedesktop.org/~mareko/mesa vbufmgr-fixes

Still they same problem, but now max_index is -2 instead of -1.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

--- Comment #3 from Marek Olšák <maraeo@gmail.com> 2011-11-20 07:35:27 PST ---
I pushed the branch anyway because it fixes some other bugs.

What happens if you do in r300_draw_vbo:

info.max_index = max_count == ~0 ? 0xffffff : max_count - 1;

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

--- Comment #4 from Tom Stellard <tstellar@gmail.com> 2011-11-20 08:11:12 PST ---
(In reply to comment #3)
> I pushed the branch anyway because it fixes some other bugs.
> 
> What happens if you do in r300_draw_vbo:
> 
> info.max_index = max_count == ~0 ? 0xffffff : max_count - 1;

This fixes the error, but the leader portraits still aren't being rendered, so
I guess there is some other problem causing this.  I'll have to bisect to find
out exactly what it is.  This bug can be closed once the above fix or something
equivalent is committed to mater.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

--- Comment #5 from Marek Olšák <maraeo@gmail.com> 2011-11-20 09:33:32 PST ---
The problem is there are no vertex attribs which are per-vertex (i.e. not
constant and not per-instance), therefore there is nothing to compute the max
index from.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

--- Comment #6 from Tom Stellard <tstellar@gmail.com> 2011-11-20 09:54:59 PST ---
(In reply to comment #4)
> This fixes the error, but the leader portraits still aren't being rendered, so
> I guess there is some other problem causing this.  I'll have to bisect to find
> out exactly what it is.  This bug can be closed once the above fix or something
> equivalent is committed to mater.

I found the real problem, shaders are being failed for having too many varyings
/ uniforms (Bug 42930 and Bug 43121).  When those shaders compile successfully,
the portraits are rendered, and I don't get the "refusing to render" error.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 43096] r300g: r300_emit_draw_elements() refusing to render when max_index = 0xffffffff

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=43096

Marek Olšák <maraeo@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |MOVED

--- Comment #7 from Marek Olšák <maraeo@gmail.com> 2011-11-20 13:16:27 PST ---
OK, closing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel