[Bug 46004] New: [r300g, bisected] piglit glsl-fs-discard-02 fails

[Bug 46004] New: [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

             Bug #: 46004
           Summary: [r300g, bisected] piglit glsl-fs-discard-02 fails
    Classification: Unclassified
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r300
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: pavel.ondracka@email.cz
                CC: vljn@ovi.com


Piglit glsl-fs-discard-02 fails with r300g since:

10937e651222501c0e9f4f44e6b842c261e2edfb is the first bad commit
commit 10937e651222501c0e9f4f44e6b842c261e2edfb
Author: Vincent Lejeune <vljn@ovi.com>
Date:   Mon Jan 2 20:17:38 2012 +0100

    glsl_to_tgsi: Use the GLSL compiler's new remove-output-reads pass.

    The existing glsl_to_tgsi::remove_output_read pass did not work properly
    when indirect addressing was involved; this commit replaces it with a
    lowering pass that occurs before TGSI code generation.

    Fixes varying-array related piglit tests.

    Signed-off-by: Vincent Lejeune <vljn@ovi.com>
    Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
    Signed-off-by: Dave Airlie <airlied@redhat.com>

GPU: RV530
Mesa: df1cd55ebf362948788c04d2fa7da55c80991605
Kernel: 3.2.3
Libdrm: 2.4.31

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

--- Comment #3 from Tom Stellard <tstellar@gmail.com> 2012-02-13 18:44:05 UTC ---
Created attachment 57003
  --> https://bugs.freedesktop.org/attachment.cgi?id=57003
Possible fix

Can you try this patch?  If it doesn't work can you get the debug output (RADEON_DEBUG=fp,vp) from when the test was passing?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

--- Comment #1 from vincent <vljn@ovi.com> 2012-02-13 12:03:38 PST ---
Hi,

could you please provide the error output for this test, and the generated opcodes using RADEON_DEBUG=fp,vp envar ?

RADEON_DEBUG /path/to/piglit/bin/glsl-fs-discard-02

Regards,
Vincent

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

--- Comment #2 from Pavel Ondračka <pavel.ondracka@email.cz> 2012-02-13 12:16:22 PST ---
Created attachment 56987
  --> https://bugs.freedesktop.org/attachment.cgi?id=56987
RADEON_DEBUG=fp,vp log

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

--- Comment #4 from Pavel Ondračka <pavel.ondracka@email.cz> 2012-02-14 00:36:35 PST ---
Created attachment 57014
  --> https://bugs.freedesktop.org/attachment.cgi?id=57014
RADEON_DEBUG=fp,vp log (piglit pass)

The patch doesn't help. Attaching a new log with 6d4b35c03619148cde89bc5eedaac3288001edd3 (right before the regression).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

--- Comment #6 from Pavel Ondračka <pavel.ondracka@email.cz> 2012-02-15 00:12:15 UTC ---
(In reply to comment #5)
> I'm guessing that this is a bug in the vertex shader.  Does running with RADEON_NO_TCL=1 fix it?

Yes, the test pass with RADEON_NO_TCL=1 set.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

--- Comment #5 from Tom Stellard <tstellar@gmail.com> 2012-02-14 19:38:21 PST ---
I'm guessing that this is a bug in the vertex shader.  Does running with RADEON_NO_TCL=1 fix it?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 46004] [r300g, bisected] piglit glsl-fs-discard-02 fails

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=46004

vincent <vljn@ovi.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
         AssignedTo|dri-devel@lists.freedesktop |vljn@ovi.com
                   |.org                        |

--- Comment #7 from vincent <vljn@ovi.com> 2012-02-23 00:26:52 PST ---
Created attachment 57507
  --> https://bugs.freedesktop.org/attachment.cgi?id=57507
Output remove less aggressive patch

Can you try this patch ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.