[Bug 50230] New: offset mapping in nexuiz results in bad texturing with the llvm compiler

[Bug 50230] New: offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

             Bug #: 50230
           Summary: offset mapping in nexuiz results in bad texturing with
                    the llvm compiler
    Classification: Unclassified
           Product: Mesa
           Version: git
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r600
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: aaalmosss@gmail.com


tested with nexuiz 2.5.2 and mesa 7a75e7d6e85d27e102ff7e15583c33b1ce282fe4

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #2 from Vadim Girlin <ptpzz@yandex.ru> 2012-05-22 23:42:10 UTC ---
In fact it seems the problem is with the first commit, second just made it much
more noticeable.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #1 from Vadim Girlin <ptpzz@yandex.ru> 2012-05-22 22:58:23 PDT ---
Created attachment 61997
  --> https://bugs.freedesktop.org/attachment.cgi?id=61997
[PATCH] Revert "r600g: set round_mode to truncate and get rid of  tgsi_f2i on
evergreen"

I see some regression with both compilers. Have you tested it with non-llvm
compiler? IIRC you are using BARTS card?

It seems the issue is triggered by the combination of commits:

60bf0f05 "r600g: set round_mode to truncate and get rid of tgsi_f2i on
evergreen"  and 
04e32400 "gallium: remove PIPE_SHADER_CAP_OUTPUT_READ".

Reverting any of them fixes the problem for me, I'll try to figure out what
exactly is going wrong. You might want to test the attached patch (reverts
first commit).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #3 from almos <aaalmosss@gmail.com> 2012-05-23 01:49:30 PDT ---
I only see this with the LLVM compiler, the old one seems fine. There is a
texture flickering on some surfaces, but that affects both of them (I use the
level Q1DM6 for testing).

Yes, I use a BARTS card (HD6850).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #4 from Vadim Girlin <ptpzz@yandex.ru> 2012-05-23 02:37:16 PDT ---
(In reply to comment #3)
> I only see this with the LLVM compiler, the old one seems fine. There is a
> texture flickering on some surfaces, but that affects both of them (I use the
> level Q1DM6 for testing).

That flickering is the issue I was talking about. The patch attached earlier
should help with it.

I don't see anything wrong with both compilers after applying the patch. If
there is another issue and the patch doesn't fix it, could you provide some
screenshots and hints how to reproduce it? 

> 
> Yes, I use a BARTS card (HD6850).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #5 from almos <aaalmosss@gmail.com> 2012-05-23 04:05:49 PDT ---
Created attachment 62012
  --> https://bugs.freedesktop.org/attachment.cgi?id=62012
nexuiz problem.jpg

Attaching screenshot of the problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #6 from almos <aaalmosss@gmail.com> 2012-05-23 04:12:41 PDT ---
Created attachment 62013
  --> https://bugs.freedesktop.org/attachment.cgi?id=62013
nexuiz settings.jpg

These are the settings I use. Basicaly everything is enabled. On the video tab
gl2 shaders and occlusion queries are enabled, vbos for vertices and triangles
and texture compression is set to good.

If I disable offset mapping, texturing returns to normal. Relief mapping is
indifferent, and so are all the other settings.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #7 from Vadim Girlin <ptpzz@yandex.ru> 2012-05-23 08:22:16 PDT ---
I can't reproduce it neither with latest mesa, nor with 7a75e7d6. 

Do you have any errors in dmesg? You might want to try latest mesa, kernel,
etc. Also you might want to try debug build of the mesa (with --enable-debug)
to see if there are any errors/asserts.

If it doesn't help, please attach the shader dump (output with
"R600_DUMP_SHADERS=1" env var).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #8 from almos <aaalmosss@gmail.com> 2012-05-23 08:54:18 PDT ---
Created attachment 62020
  --> https://bugs.freedesktop.org/attachment.cgi?id=62020
nexuiz_stderr.txt.gz

(In reply to comment #7)
> I can't reproduce it neither with latest mesa, nor with 7a75e7d6. 
> 
> Do you have any errors in dmesg? You might want to try latest mesa, kernel,
> etc. Also you might want to try debug build of the mesa (with --enable-debug)
> to see if there are any errors/asserts.
I'm using kernel 3.3.1 with the tiling patches from J. Glisse. I'll try 3.4
later. I always compile with enable-debug, but there are no errors printed.
There is nothing in dmesg either.

> 
> If it doesn't help, please attach the shader dump (output with
> "R600_DUMP_SHADERS=1" env var).
Attaching stderr. I just started the game, loaded Q1DM3, and exited.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #9 from Vadim Girlin <ptpzz@yandex.ru> 2012-05-24 07:38:10 PDT ---
Created attachment 62057
  --> https://bugs.freedesktop.org/attachment.cgi?id=62057
[PATCH] radeon/llvm: fix sampler index in llvm_emit_tex

Does this patch help?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

--- Comment #10 from almos <aaalmosss@gmail.com> 2012-05-24 13:25:32 PDT ---
(In reply to comment #9)
> Created attachment 62057 [details] [review]
> [PATCH] radeon/llvm: fix sampler index in llvm_emit_tex
> 
> Does this patch help?
Yes, the patch fixes it. I also tried the revert patch, and that fixes the
lightmap flickering.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 50230] offset mapping in nexuiz results in bad texturing with the llvm compiler

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=50230

almos <aaalmosss@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from almos <aaalmosss@gmail.com> 2012-05-25 10:54:31 PDT ---
I see the fixes were pushed to mesa master. Closing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.