[dpdk-dev] [Bug 553] iavf_fdir/negative_case: run command with invalid port 'flow flush 2', it can't print error info or warning info.

[dpdk-dev] [Bug 553] iavf_fdir/negative_case: run command with invalid port 'flow flush 2', it can't print error info or warning info.

[bugzilla]

https://bugs.dpdk.org/show_bug.cgi?id=553

            Bug ID: 553
           Summary: iavf_fdir/negative_case: run command with invalid port
                    'flow flush 2', it can't print error info or warning
                    info.
           Product: DPDK
           Version: 20.11
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: testpmd
          Assignee: dev@dpdk.org
          Reporter: weix.xie@intel.com
  Target Milestone: ---

Environment:
•DPDK version: 20.11.0-rc0  commit 0e995cbcfc81e1d86d92dfb871ebe14ee5b8d9e4
•OS: Ubuntu 20.04.1 LTS / 5.4.0-45-generic
•Compiler: gcc (Ubuntu 9.3.0-10ubuntu2) 9.3.0
•Hardware platform: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz
•NIC hardware: Intel Corporation Ethernet Controller E810-C for QSFP
[8086:1592]
•NIC firmware: 2.10 0x8000433e 1.2789.0
•ICE driver: 1.1.4
•PKG: ice_comms-1.3.20.0.pkg


Steps to reproduce:
1. Generate 2 VFs from PF.
# echo 2 > /sys/bus/pci/devices/0000\:81\:00.0/sriov_numvfs
2. Bind 2 VFs to vfio-pci.
# dpdk-devbind.py -b vfio-pci 0000:81:01.0 0000:81:01.1
3.Launch testpmd.
# x86_64-native-linuxapp-gcc/app/dpdk-testpmd  -l 32,33,34,35 -n 4 -w
0000:81:01.0 -w 0000:81:01.1 -- -i --rxq=16 --txq=16
testpmd> start
testpmd> flow destroy 2 rule 0
testpmd> flow flush 2


Actual Result:
testpmd> flow destroy 2 rule 0
Invalid port 2
testpmd> flow flush 2
testpmd>
Print info is empty.


Expected Result:
testpmd> flow destroy 2 rule 0
Invalid port 2
testpmd> flow flush 2
port_flow_complain(): Caught PMD error type 1 (cause unspecified): No such
device: No such device


Regression:
Is this issue a regression: Y
First bad commit:
commit 2a449871a12dacef6a644254e42175e09a316617 (HEAD)
Author: Thomas Monjalon <thomas@monjalon.net>
Date: Tue Sep 29 01:14:34 2020 +0200

app/testpmd: align behaviour of multi-port detach

A port can be closed in multiple situations:
 - close command calling close_port() -> rte_eth_dev_close()
 - exit calling close_port() -> rte_eth_dev_close()
 - hotplug calling close_port() -> rte_eth_dev_close()
 - hotplug calling detach_device() -> rte_dev_remove()
 - port detach command, detach_device() -> rte_dev_remove()
 - device detach command, detach_devargs() -> rte_eal_hotplug_remove()

The flow rules are flushed before each close.
 It was already done in close_port(), detach_devargs() and
 detach_port_device() which calls detach_device(),
 but not in detach_device(). As a consequence, it was missing for siblings
 of port detach command and unplugged device.
 The check before calling port_flow_flush() is moved inside the function.

The state of the port to close is checked to be stopped.
 As above, this check was missing in detach_device(),
 impacting the cases of a multi-port device unplugged or detached
 with the port detach command.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
 Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
 Acked-by: Stephen Hemminger <stephen@networkplumber.org>

-- 
You are receiving this mail because:
You are the assignee for the bug.