[Bug 57660] New: nv?? show error nv??_screen_get_param:??? - unknown PIPE_CAP 76

[Bug 57660] New: nv?? show error nv??_screen_get_param:??? - unknown PIPE_CAP 76

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 833 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

          Priority: medium
            Bug ID: 57660
          Assignee: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
           Summary: nv?? show error nv??_screen_get_param:??? - unknown
                    PIPE_CAP 76
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
          Hardware: All
            Status: NEW
           Version: git
         Component: Drivers/DRI/nouveau
           Product: Mesa

Created attachment 70747
  --> https://bugs.freedesktop.org/attachment.cgi?id=70747&action=edit
Patch to fix it

Unhandled case PIPE_CAP_CUBE_MAP_ARRAY in nv??_screen.c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] nv?? show error nv??_screen_get_param:??? - unknown PIPE_CAP 76

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 365 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #1 from Maarten Lankhorst <m.b.lankhorst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
I think nouveau could probably easily get support for it, so I don't know if we
should default to false, would be better to leave it open.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1145 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] nv?? show error nv??_screen_get_param:??? - unknown PIPE_CAP 76

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 233 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #2 from Hristo Venev <mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Working on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1005 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] nv?? show error nv??_screen_get_param:??? - unknown PIPE_CAP 76

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 407 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #3 from Hristo Venev <mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
In nv50_ir_lowering_nv50.cpp in handleTEX, arguments to the texture instruction
i are (x, y, z, face, something).
What do they need to be transformed to? Is it (x, y, 6*z+face, something)?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1179 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] nv?? show error nv??_screen_get_param:??? - unknown PIPE_CAP 76

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 923 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

Hristo Venev <mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nouveau-PD4FTy7X32lNgt0PjOBp93rCq3LdnpKM@public.gmane.org |mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
                   |rg                          |
  Attachment #70747|0                           |1
        is obsolete|                            |

--- Comment #4 from Hristo Venev <mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> ---
Created attachment 70799
  --> https://bugs.freedesktop.org/attachment.cgi?id=70799&action=edit
Partial implementation

This is a partial implementation. It is probably slow and renders incorrectly
for some reason.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2351 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 621 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org        |nouveau-PD4FTy7X32lNgt0PjOBp93rCq3LdnpKM@public.gmane.org
                   |                            |rg
                 CC|                            |mustrumr97-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1281 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 935 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #8 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Sounds like what's left to be done is to test it. Just need to apply the below
patch and see if it works (looks like there are a couple of piglit tests... ls
bin/*cube_map_array* -- they ought to pass on the nva3+ hardware).

--- a/src/gallium/drivers/nv50/nv50_screen.c
+++ b/src/gallium/drivers/nv50/nv50_screen.c
@@ -114,10 +114,7 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum
pipe_cap param)
    case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
       return 0;
    case PIPE_CAP_CUBE_MAP_ARRAY:
-      return 0;
-      /*
       return nv50_screen(pscreen)->tesla->oclass >= NVA3_3D_CLASS;
-      */
    case PIPE_CAP_TWO_SIDED_STENCIL:
    case PIPE_CAP_DEPTH_CLIP_DISABLE:
    case PIPE_CAP_POINT_SPRITE:

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1718 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 433 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70799|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1077 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 1487 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #9 from Martin Peres <martin.peres-Iz16wY1oaNPLSKGbIzaifA@public.gmane.org> ---
(In reply to comment #8)
> Sounds like what's left to be done is to test it. Just need to apply the
> below patch and see if it works (looks like there are a couple of piglit
> tests... ls bin/*cube_map_array* -- they ought to pass on the nva3+
> hardware).
> 
> --- a/src/gallium/drivers/nv50/nv50_screen.c
> +++ b/src/gallium/drivers/nv50/nv50_screen.c
> @@ -114,10 +114,7 @@ nv50_screen_get_param(struct pipe_screen *pscreen, enum
> pipe_cap param)
>     case PIPE_CAP_SEAMLESS_CUBE_MAP_PER_TEXTURE:
>        return 0;
>     case PIPE_CAP_CUBE_MAP_ARRAY:
> -      return 0;
> -      /*
>        return nv50_screen(pscreen)->tesla->oclass >= NVA3_3D_CLASS;
> -      */
>     case PIPE_CAP_TWO_SIDED_STENCIL:
>     case PIPE_CAP_DEPTH_CLIP_DISABLE:
>     case PIPE_CAP_POINT_SPRITE:

I tested this patch with piglit, it doesn't look good :D

* arb_texture_cube_map_array-get: PASS
* arb_texture_cube_map_array-teximage3d-invalid-values: PASS
* arb_texture_cube_map_array-cubemap: FAIL (http://codepad.org/sZpx3ajS)
* arb_texture_cube_map_array-cubemap-lod: FAIL (http://codepad.org/5E8EPmpx)
* arb_texture_cube_map_array-fbo-cubemap-array: FAIL
(http://codepad.org/0QqPUEAE)
* arb_texture_cube_map_array-sampler-cube-array-shadow: FAIL
(http://codepad.org/orzd5RoU)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2574 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 457 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #10 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
I think there are a bunch of places in the nv50 driver where things check for
PIPE_TEXTURE_{1D,2D}_ARRAY but also need to check for PIPE_TEXTURE_CUBE_ARRAY.
One such place is nv50_create_texture_view but there are probably a bunch of
others.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1216 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 519 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #11 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
Created attachment 93636
  --> https://bugs.freedesktop.org/attachment.cgi?id=93636&action=edit
cubemap array patch

Well, this fixes the one place I found by copying what nvc0 did. But from
Martin's test it seems like this probably won't be sufficient, since this just
takes layer offsets into account.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1491 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 780 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

--- Comment #12 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
(In reply to comment #11)
> Created attachment 93636 [details] [review]
> cubemap array patch
> 
> Well, this fixes the one place I found by copying what nvc0 did. But from
> Martin's test it seems like this probably won't be sufficient, since this
> just takes layer offsets into account.

In case there was any suspense about it, this doesn't work either. It seems
like the texprep instruction doesn't actually adjust for the layer (or we're
passing the layer in wrong) -- cubemap works for layer 0 but not layer 1. Will
need some traces to figure out what's up.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1899 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau

[Bug 57660] [NVA3:NVC0] Turn on support for PIPE_CAP_CUBE_MAP_ARRAY

[bugzilla-daemon-CC+yJ3UmIYqDUpFQwHEjaQ]

[-- Attachment #1.1: Type: text/plain, Size: 800 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=57660

Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> ---
A working impl is in mesa-git now.
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e71c65db0df86401f2caf26209ff73e3715443a

The sampler-cube-array-shadow test fails, but so does sampler-cube-shadow (on
nva0+), so I'm guessing those two failures are highly related.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 2330 bytes --]

[-- Attachment #2: Type: text/plain, Size: 181 bytes --]

_______________________________________________
Nouveau mailing list
Nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
http://lists.freedesktop.org/mailman/listinfo/nouveau