[Bug 60824] [PATCH][regression] Cambridge Silicon Radio, Ltd Bluetooth Dongle unusable

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=60824

Zijun Hu (quic_zijuhu@quicinc.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |quic_zijuhu@quicinc.com

--- Comment #239 from Zijun Hu (quic_zijuhu@quicinc.com) ---
i maybe find the root cause for this issue.

the device seems a fake device actually but it is not detected as fake device.


below error show it seems a fake device and HCI_QUIRK_BROKEN_FILTER_CLEAR_ALL
should be set

< HCI Command: Set Event Filter (0x03|0x0005) plen 1        #23 [hci0] 4.130423
        Type: Clear All Filters (0x00)
> HCI Event: Command Complete (0x0e) plen 4                 #24 [hci0] 4.133374
      Set Event Filter (0x03|0x0005) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

but current fake device detect logic miss this new device.
< HCI Command: Read Local Version In.. (0x04|0x0001) plen 0  #1 [hci0] 4.073336
> HCI Event: Command Complete (0x0e) plen 12                 #2 [hci0] 4.077324
      Read Local Version Information (0x04|0x0001) ncmd 1
        Status: Success (0x00)
        HCI version: Bluetooth 4.0 (0x06) - Revision 12576 (0x3120)
        LMP version: Bluetooth 4.0 (0x06) - Subversion 8891 (0x22bb)
        Manufacturer: Cambridge Silicon Radio (10)


i will fix it as below:

+++ b/drivers/bluetooth/btusb.c
@@ -2155,7 +2155,7 @@ static int btusb_setup_csr(struct hci_dev *hdev)
                is_fake = true;

        else if (le16_to_cpu(rp->lmp_subver) <= 0x22bb &&
-                le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_4_0)
+                le16_to_cpu(rp->hci_ver) >= BLUETOOTH_VER_4_0)
                is_fake = true;

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are the assignee for the bug.