* [dpdk-dev] [Bug 665] i40e MBUF_FAST_FREE wrong check
@ 2021-03-24 22:59 bugzilla
0 siblings, 0 replies; only message in thread
From: bugzilla @ 2021-03-24 22:59 UTC (permalink / raw)
To: dev
https://bugs.dpdk.org/show_bug.cgi?id=665
Bug ID: 665
Summary: i40e MBUF_FAST_FREE wrong check
Product: DPDK
Version: 20.05
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: sbaranoff@gmail.com
Target Milestone: ---
In i40e_rxtx.c in i40e_set_tx_function_flag there's an assignment to
ad->tx_simple_allowed that includes a check for enabling "tx_simple_allowed":
txq->offloads == (txq->offloads & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
This appears to be wrong to me. If no offload flags are set then 0 == 0 &
<anything> is true. This means that if DEV_TX_OFFLOAD_MBUF_FAST_FREE is NOT set
(and no other flags are set) then this check will still enable
`tx_simple_allowed`.
As best I can tell, this causes an issue with multiple mbuf pools are being
used to feed a single TX queue and no offload flags enable.
--
You are receiving this mail because:
You are the assignee for the bug.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-24 22:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-24 22:59 [dpdk-dev] [Bug 665] i40e MBUF_FAST_FREE wrong check bugzilla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.