[Bug 66601] New: Compile error

[Bug 66601] New: Compile error

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=66601

            Bug ID: 66601
           Summary: Compile error
           Product: Backports project
           Version: unspecified
    Kernel Version: 3.4.x
          Hardware: ARM
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: Backports
          Assignee: backports@vger.kernel.org
          Reporter: richard.rojfors@gmail.com
        Regression: No

Created attachment 117591
  --> https://bugzilla.kernel.org/attachment.cgi?id=117591&action=edit
[PATCH] compat.3.7, compat.3.8: Adds missing of.h include

This applies to 3.13-rc2

The compat-3.7.c och compat-3.8.c uses of-functions if supported by the kernel,
but there is a missing include for linux/of.h

| NOTE: make -j 8 ARCH=arm KLIB_BUILD=/path/usr/src/kernel KLIB=/path/image
|   CC [M]  /path/backports-3.13-rc2-1/compat/compat-3.7.o
| /path/backports-3.13-rc2-1/compat/compat-3.7.c: In function
'of_get_child_by_name':
| /path/backports-3.13-rc2-1/compat/compat-3.7.c:274:1: error: unknown type
name 'z'
| /path/backports-3.13-rc2-1/compat/compat-3.7.c:276:3: error: expected '=',
',', ';', 'asm' or '__attribute__' before 'if'
| make[6]: *** [/path/backports-3.13-rc2-1/compat/compat-3.7.o] Error 1
| make[5]: *** [/path/backports-3.13-rc2-1/compat] Error 2
| make[4]: *** [_module_/path/backports/3.13-rc2-1-r0/backports-3.13-rc2-1]
Error 2
| make[3]: *** [modules] Error 2
| make[2]: *** [modules] Error 2
| make[1]: *** [modules] Error 2
| make: *** [default] Error 2

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 66601] [PATCH] missing of.h include in compat-*.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=66601

Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alan@lxorguk.ukuu.org.uk
            Summary|Compile error               |[PATCH] missing of.h
                   |                            |include in compat-*.c

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 66601] [PATCH] missing of.h include in compat-*.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=66601

Luis R. Rodriguez <mcgrof@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcgrof@gmail.com

--- Comment #1 from Luis R. Rodriguez <mcgrof@gmail.com> ---
Thanks for the patch !

If this fixes an issue opening up a bugzilla entry seems like a rather
cumbersome way to get the changes merged. Please consider sending the patch
with an appropriate Singed-off-by tag if you agree to the Developer Certificate
of Origin (same as the Linux kernel) and send it to backports mailing list.
Will you close the bug entry yourself?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 66601] [PATCH] missing of.h include in compat-*.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=66601

Richard Röjfors <richard.rojfors@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #2 from Richard Röjfors <richard.rojfors@gmail.com> ---
Makes sense, mailed patch to the mailinglist.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 66601] [PATCH] missing of.h include in compat-*.c

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=66601

Hauke Mehrtens <hauke@hauke-m.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hauke@hauke-m.de

--- Comment #3 from Hauke Mehrtens <hauke@hauke-m.de> ---
I already created a patch which adds the missing include, it was added in the
last release, see:
https://git.kernel.org/cgit/linux/kernel/git/backports/backports.git/commit/?id=a9081420811be2a9c7386b4693c5cf1b93b3ae23

This should be fixed in backports-20131206.

-- 
You are receiving this mail because:
You are the assignee for the bug.