[Bug 71723] New: [GLSL] Sampler arrays indexed with non-constant expressions

* [Bug 71723] New: [GLSL] Sampler arrays indexed with non-constant expressions
@ 2013-11-18  7:20 bugzilla-daemon
  2013-11-18 12:51 ` [Bug 71723] " bugzilla-daemon
  0 siblings, 1 reply; 2+ messages in thread
From: bugzilla-daemon @ 2013-11-18  7:20 UTC (permalink / raw)
  To: dri-devel

[-- Attachment #1.1: Type: text/plain, Size: 1784 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=71723

          Priority: medium
            Bug ID: 71723
          Assignee: dri-devel@lists.freedesktop.org
           Summary: [GLSL] Sampler arrays indexed with non-constant
                    expressions
          Severity: normal
    Classification: Unclassified
                OS: Linux (All)
          Reporter: vluchits@gmail.com
          Hardware: x86-64 (AMD64)
            Status: NEW
           Version: 9.2
         Component: Drivers/DRI/Radeon
           Product: Mesa

Created attachment 89383
  --> https://bugs.freedesktop.org/attachment.cgi?id=89383&action=edit
Test vertex shader

Hello,

in my opinion GLSL compiler in mesa is too restrictive when it comes to sampler
arrays. The attached vertex shader can not be compiled due to the "sampler
arrays indexed with non-constant expressions is forbidden in GLSL 1.30 and
later":

Lines 159-136 of src/glsl/ast_array_index.cpp say:

    * This restriction was added in GLSL 1.30.  Shaders using earlier version
    * of the language should not be rejected by the compiler front-end for
    * using this construct.  This allows useful things such as using a loop
    * counter as the index to an array of samplers.  If the loop in unrolled,
    * the code should compile correctly.  Instead, emit a warning.

If compiler actually attempted to unroll the loop above, it would notice that
the code does compile correctly in that case. Instead it just emits and error
and, in my opinion, contradicts the comment above by not allowing the
aforementioned "useful thing".

Can the compiler be changed to _first_ attempt to unroll the loop and then
check for sampler array indices being constants?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 3226 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 2+ messages in thread